diff mbox series

[1/2] dt-bindings: serial: add generic DT binding for announcing RTS/CTS lines

Message ID 20200520133932.30441-2-erwan.leray@st.com (mailing list archive)
State Mainlined
Commit b2cc2b5111db43b35b5de7252127bbc8d6806e34
Headers show
Series add generic DT binding for RTS/CTS | expand

Commit Message

Erwan LE RAY May 20, 2020, 1:39 p.m. UTC
Add support of generic DT binding for annoucing RTS/CTS lines. The initial
binding 'st,hw-flow-control' is not needed anymore since generic binding
is available, but is kept for backward compatibility.

Signed-off-by: Erwan Le Ray <erwan.leray@st.com>

Comments

Greg Kroah-Hartman June 27, 2020, 2:18 p.m. UTC | #1
On Wed, May 20, 2020 at 03:39:31PM +0200, Erwan Le Ray wrote:
> Add support of generic DT binding for annoucing RTS/CTS lines. The initial
> binding 'st,hw-flow-control' is not needed anymore since generic binding
> is available, but is kept for backward compatibility.
> 
> Signed-off-by: Erwan Le Ray <erwan.leray@st.com>
> 
> diff --git a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
> index 75b8521eb7cb..06d5f251ec88 100644
> --- a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
> +++ b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
> @@ -35,9 +35,11 @@ properties:
>      description: label associated with this uart
>  
>    st,hw-flow-ctrl:
> -    description: enable hardware flow control
> +    description: enable hardware flow control (deprecated)
>      $ref: /schemas/types.yaml#/definitions/flag
>  
> +  uart-has-rtscts: true
> +
>    dmas:
>      minItems: 1
>      maxItems: 2
> -- 
> 2.17.1
> 

Did this get ignored by the DT maintainers?  :(
Erwan LE RAY June 29, 2020, 8:13 a.m. UTC | #2
On 6/27/20 4:18 PM, Greg Kroah-Hartman wrote:
> On Wed, May 20, 2020 at 03:39:31PM +0200, Erwan Le Ray wrote:
>> Add support of generic DT binding for annoucing RTS/CTS lines. The initial
>> binding 'st,hw-flow-control' is not needed anymore since generic binding
>> is available, but is kept for backward compatibility.
>>
>> Signed-off-by: Erwan Le Ray <erwan.leray@st.com>
>>
>> diff --git a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
>> index 75b8521eb7cb..06d5f251ec88 100644
>> --- a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
>> +++ b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
>> @@ -35,9 +35,11 @@ properties:
>>       description: label associated with this uart
>>   
>>     st,hw-flow-ctrl:
>> -    description: enable hardware flow control
>> +    description: enable hardware flow control (deprecated)
>>       $ref: /schemas/types.yaml#/definitions/flag
>>   
>> +  uart-has-rtscts: true
>> +
>>     dmas:
>>       minItems: 1
>>       maxItems: 2
>> -- 
>> 2.17.1
>>
> Did this get ignored by the DT maintainers?  :(

Hi Rob,

Gentle reminder. Could you please provide your feedback on this patch ?

Best Regards, Erwan.
Rob Herring June 30, 2020, 6:35 p.m. UTC | #3
On Sat, Jun 27, 2020 at 8:18 AM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Wed, May 20, 2020 at 03:39:31PM +0200, Erwan Le Ray wrote:
> > Add support of generic DT binding for annoucing RTS/CTS lines. The initial
> > binding 'st,hw-flow-control' is not needed anymore since generic binding
> > is available, but is kept for backward compatibility.
> >
> > Signed-off-by: Erwan Le Ray <erwan.leray@st.com>
> >
> > diff --git a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
> > index 75b8521eb7cb..06d5f251ec88 100644
> > --- a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
> > +++ b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
> > @@ -35,9 +35,11 @@ properties:
> >      description: label associated with this uart
> >
> >    st,hw-flow-ctrl:
> > -    description: enable hardware flow control
> > +    description: enable hardware flow control (deprecated)
> >      $ref: /schemas/types.yaml#/definitions/flag
> >
> > +  uart-has-rtscts: true
> > +
> >    dmas:
> >      minItems: 1
> >      maxItems: 2
> > --
> > 2.17.1
> >
>
> Did this get ignored by the DT maintainers?  :(

When it doesn't go to the DT list, you are playing roulette whether I
happen to see it. :(

Anyways,

Reviewed-by: Rob Herring <robh@kernel.org>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
index 75b8521eb7cb..06d5f251ec88 100644
--- a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
+++ b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
@@ -35,9 +35,11 @@  properties:
     description: label associated with this uart
 
   st,hw-flow-ctrl:
-    description: enable hardware flow control
+    description: enable hardware flow control (deprecated)
     $ref: /schemas/types.yaml#/definitions/flag
 
+  uart-has-rtscts: true
+
   dmas:
     minItems: 1
     maxItems: 2