| Message ID | 20200522034533.61716-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 472f0a240250df443ffc4f39835e829916193ca1 |
| Headers | show |
| Series | [-next] mt76: mt7915: Fix build error | expand |
YueHaibing <yuehaibing@huawei.com> writes: > In file included from ./include/linux/firmware.h:6:0, > from drivers/net/wireless/mediatek/mt76/mt7915/mcu.c:4: > In function ‘__mt7915_mcu_msg_send’, > inlined from ‘mt7915_mcu_send_message’ at drivers/net/wireless/mediatek/mt76/mt7915/mcu.c:370:6: > ./include/linux/compiler.h:396:38: error: call to ‘__compiletime_assert_545’ declared with attribute error: BUILD_BUG_ON failed: cmd == MCU_EXT_CMD_EFUSE_ACCESS && mcu_txd->set_query != MCU_Q_QUERY > _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) > ^ > ./include/linux/compiler.h:377:4: note: in definition of macro ‘__compiletime_assert’ > prefix ## suffix(); \ > ^~~~~~ > ./include/linux/compiler.h:396:2: note: in expansion of macro ‘_compiletime_assert’ > _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) > ^~~~~~~~~~~~~~~~~~~ > ./include/linux/build_bug.h:39:37: note: in expansion of macro ‘compiletime_assert’ > #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) > ^~~~~~~~~~~~~~~~~~ > ./include/linux/build_bug.h:50:2: note: in expansion of macro ‘BUILD_BUG_ON_MSG’ > BUILD_BUG_ON_MSG(condition, "BUILD_BUG_ON failed: " #condition) > ^~~~~~~~~~~~~~~~ > drivers/net/wireless/mediatek/mt76/mt7915/mcu.c:280:2: note: in expansion of macro ‘BUILD_BUG_ON’ > BUILD_BUG_ON(cmd == MCU_EXT_CMD_EFUSE_ACCESS && > ^~~~~~~~~~~~ > > BUILD_BUG_ON is meaningless here, chang it to WARN_ON. > > Fixes: e57b7901469f ("mt76: add mac80211 driver for MT7915 PCIe-based chipsets") > Signed-off-by: YueHaibing <yuehaibing@huawei.com> I'm curious why I don't see this build error? I was about to send a pull request to Dave, should I hold off the pull request due to this problem?
YueHaibing <yuehaibing@huawei.com> wrote: > In file included from ./include/linux/firmware.h:6:0, > from drivers/net/wireless/mediatek/mt76/mt7915/mcu.c:4: > In function ‘__mt7915_mcu_msg_send’, > inlined from ‘mt7915_mcu_send_message’ at drivers/net/wireless/mediatek/mt76/mt7915/mcu.c:370:6: > ./include/linux/compiler.h:396:38: error: call to ‘__compiletime_assert_545’ declared with attribute error: BUILD_BUG_ON failed: cmd == MCU_EXT_CMD_EFUSE_ACCESS && mcu_txd->set_query != MCU_Q_QUERY > _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) > ^ > ./include/linux/compiler.h:377:4: note: in definition of macro ‘__compiletime_assert’ > prefix ## suffix(); \ > ^~~~~~ > ./include/linux/compiler.h:396:2: note: in expansion of macro ‘_compiletime_assert’ > _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) > ^~~~~~~~~~~~~~~~~~~ > ./include/linux/build_bug.h:39:37: note: in expansion of macro ‘compiletime_assert’ > #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) > ^~~~~~~~~~~~~~~~~~ > ./include/linux/build_bug.h:50:2: note: in expansion of macro ‘BUILD_BUG_ON_MSG’ > BUILD_BUG_ON_MSG(condition, "BUILD_BUG_ON failed: " #condition) > ^~~~~~~~~~~~~~~~ > drivers/net/wireless/mediatek/mt76/mt7915/mcu.c:280:2: note: in expansion of macro ‘BUILD_BUG_ON’ > BUILD_BUG_ON(cmd == MCU_EXT_CMD_EFUSE_ACCESS && > ^~~~~~~~~~~~ > > BUILD_BUG_ON is meaningless here, chang it to WARN_ON. > > Fixes: e57b7901469f ("mt76: add mac80211 driver for MT7915 PCIe-based chipsets") > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Patch applied to wireless-drivers-next.git, thanks. 472f0a240250 mt76: mt7915: Fix build error
Yuehaibing <yuehaibing@huawei.com> writes: > On 2020/5/22 18:11, Kalle Valo wrote: >> YueHaibing <yuehaibing@huawei.com> writes: >> >>> In file included from ./include/linux/firmware.h:6:0, >>> from drivers/net/wireless/mediatek/mt76/mt7915/mcu.c:4: >>> In function ‘__mt7915_mcu_msg_send’, >>> inlined from ‘mt7915_mcu_send_message’ at drivers/net/wireless/mediatek/mt76/mt7915/mcu.c:370:6: >>> ./include/linux/compiler.h:396:38: error: call to ‘__compiletime_assert_545’ declared with attribute error: BUILD_BUG_ON failed: cmd == MCU_EXT_CMD_EFUSE_ACCESS && mcu_txd->set_query != MCU_Q_QUERY >>> _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) >>> ^ >>> ./include/linux/compiler.h:377:4: note: in definition of macro ‘__compiletime_assert’ >>> prefix ## suffix(); \ >>> ^~~~~~ >>> ./include/linux/compiler.h:396:2: note: in expansion of macro ‘_compiletime_assert’ >>> _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) >>> ^~~~~~~~~~~~~~~~~~~ >>> ./include/linux/build_bug.h:39:37: note: in expansion of macro ‘compiletime_assert’ >>> #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) >>> ^~~~~~~~~~~~~~~~~~ >>> ./include/linux/build_bug.h:50:2: note: in expansion of macro ‘BUILD_BUG_ON_MSG’ >>> BUILD_BUG_ON_MSG(condition, "BUILD_BUG_ON failed: " #condition) >>> ^~~~~~~~~~~~~~~~ >>> drivers/net/wireless/mediatek/mt76/mt7915/mcu.c:280:2: note: in expansion of macro ‘BUILD_BUG_ON’ >>> BUILD_BUG_ON(cmd == MCU_EXT_CMD_EFUSE_ACCESS && >>> ^~~~~~~~~~~~ >>> >>> BUILD_BUG_ON is meaningless here, chang it to WARN_ON. >>> >>> Fixes: e57b7901469f ("mt76: add mac80211 driver for MT7915 PCIe-based chipsets") >>> Signed-off-by: YueHaibing <yuehaibing@huawei.com> >> >> I'm curious why I don't see this build error? I was about to send a pull >> request to Dave, should I hold off the pull request due to this problem? > > The config is attached > > gcc version 7.5.0 (Ubuntu 7.5.0-3ubuntu1~18.04) Thanks, I was able to reproduce the error with gcc-10 using your config but didn't have time to investigate what was different in my config and why I didn't see it.
diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c index f00ad2b66761..99eeea42478f 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c +++ b/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c @@ -277,8 +277,8 @@ static int __mt7915_mcu_msg_send(struct mt7915_dev *dev, struct sk_buff *skb, } mcu_txd->s2d_index = MCU_S2D_H2N; - BUILD_BUG_ON(cmd == MCU_EXT_CMD_EFUSE_ACCESS && - mcu_txd->set_query != MCU_Q_QUERY); + WARN_ON(cmd == MCU_EXT_CMD_EFUSE_ACCESS && + mcu_txd->set_query != MCU_Q_QUERY); exit: if (wait_seq)
In file included from ./include/linux/firmware.h:6:0, from drivers/net/wireless/mediatek/mt76/mt7915/mcu.c:4: In function ‘__mt7915_mcu_msg_send’, inlined from ‘mt7915_mcu_send_message’ at drivers/net/wireless/mediatek/mt76/mt7915/mcu.c:370:6: ./include/linux/compiler.h:396:38: error: call to ‘__compiletime_assert_545’ declared with attribute error: BUILD_BUG_ON failed: cmd == MCU_EXT_CMD_EFUSE_ACCESS && mcu_txd->set_query != MCU_Q_QUERY _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) ^ ./include/linux/compiler.h:377:4: note: in definition of macro ‘__compiletime_assert’ prefix ## suffix(); \ ^~~~~~ ./include/linux/compiler.h:396:2: note: in expansion of macro ‘_compiletime_assert’ _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) ^~~~~~~~~~~~~~~~~~~ ./include/linux/build_bug.h:39:37: note: in expansion of macro ‘compiletime_assert’ #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) ^~~~~~~~~~~~~~~~~~ ./include/linux/build_bug.h:50:2: note: in expansion of macro ‘BUILD_BUG_ON_MSG’ BUILD_BUG_ON_MSG(condition, "BUILD_BUG_ON failed: " #condition) ^~~~~~~~~~~~~~~~ drivers/net/wireless/mediatek/mt76/mt7915/mcu.c:280:2: note: in expansion of macro ‘BUILD_BUG_ON’ BUILD_BUG_ON(cmd == MCU_EXT_CMD_EFUSE_ACCESS && ^~~~~~~~~~~~ BUILD_BUG_ON is meaningless here, chang it to WARN_ON. Fixes: e57b7901469f ("mt76: add mac80211 driver for MT7915 PCIe-based chipsets") Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/net/wireless/mediatek/mt76/mt7915/mcu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)