diff mbox series

arm64: dts: imx8mm-beacon: Fix voltages on LDO1 and LDO2

Message ID 20200526170939.104111-1-aford173@gmail.com (mailing list archive)
State Mainlined
Commit e353b325948d04f1305a7b4ad32eca87ba0823a2
Headers show
Series arm64: dts: imx8mm-beacon: Fix voltages on LDO1 and LDO2 | expand

Commit Message

Adam Ford May 26, 2020, 5:09 p.m. UTC
LDO1 and LDO2 settings are wrong and case the voltage to go above the
maximum level of 2.15V permitted by the SoC to 3.0V.

This patch is based on work done on the i.MX8M Mini-EVK which utilizes
the same fix.

Fixes: 593816fa2f35 ("arm64: dts: imx: Add Beacon i.MX8m-Mini development kit")

Signed-off-by: Adam Ford <aford173@gmail.com>

Comments

Daniel Baluta May 26, 2020, 5:43 p.m. UTC | #1
On Tue, May 26, 2020 at 8:11 PM Adam Ford <aford173@gmail.com> wrote:
>
> LDO1 and LDO2 settings are wrong and case the voltage to go above the
> maximum level of 2.15V permitted by the SoC to 3.0V.
>
> This patch is based on work done on the i.MX8M Mini-EVK which utilizes
> the same fix.
>
> Fixes: 593816fa2f35 ("arm64: dts: imx: Add Beacon i.MX8m-Mini development kit")
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
No need for a new line between fixes and signed-off-by.

With that:

Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>
Shawn Guo June 18, 2020, 2:35 p.m. UTC | #2
On Tue, May 26, 2020 at 08:43:24PM +0300, Daniel Baluta wrote:
> On Tue, May 26, 2020 at 8:11 PM Adam Ford <aford173@gmail.com> wrote:
> >
> > LDO1 and LDO2 settings are wrong and case the voltage to go above the
> > maximum level of 2.15V permitted by the SoC to 3.0V.
> >
> > This patch is based on work done on the i.MX8M Mini-EVK which utilizes
> > the same fix.
> >
> > Fixes: 593816fa2f35 ("arm64: dts: imx: Add Beacon i.MX8m-Mini development kit")
> >
> > Signed-off-by: Adam Ford <aford173@gmail.com>
> No need for a new line between fixes and signed-off-by.

I fixed it up and applied the patch.

> 
> With that:
> 
> Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>

Thanks.

Shawn
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi
index fb0137a8611c..94911b1707ef 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi
@@ -136,7 +136,7 @@ 
 
 			ldo1_reg: LDO1 {
 				regulator-name = "LDO1";
-				regulator-min-microvolt = <3000000>;
+				regulator-min-microvolt = <1600000>;
 				regulator-max-microvolt = <3300000>;
 				regulator-boot-on;
 				regulator-always-on;
@@ -144,7 +144,7 @@ 
 
 			ldo2_reg: LDO2 {
 				regulator-name = "LDO2";
-				regulator-min-microvolt = <900000>;
+				regulator-min-microvolt = <800000>;
 				regulator-max-microvolt = <900000>;
 				regulator-boot-on;
 				regulator-always-on;