| Message ID | 20200602104405.28851-1-aishwaryarj100@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | net: stmmac: Drop condition with no effect | expand |
From: Aishwarya Ramakrishnan <aishwaryarj100@gmail.com> Date: Tue, 2 Jun 2020 16:14:04 +0530 > As the "else if" and "else" branch body are identical the > condition has no effect. So removing "else if" condition. > > Signed-off-by: Aishwarya Ramakrishnan <aishwaryarj100@gmail.com> I'm not applying these patches, the conditional tests serve as documentation.
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c index bcda49dcf619..f59813a0405c 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c @@ -229,8 +229,6 @@ static int stmmac_mtl_setup(struct platform_device *pdev, plat->tx_sched_algorithm = MTL_TX_ALGORITHM_WFQ; else if (of_property_read_bool(tx_node, "snps,tx-sched-dwrr")) plat->tx_sched_algorithm = MTL_TX_ALGORITHM_DWRR; - else if (of_property_read_bool(tx_node, "snps,tx-sched-sp")) - plat->tx_sched_algorithm = MTL_TX_ALGORITHM_SP; else plat->tx_sched_algorithm = MTL_TX_ALGORITHM_SP;
As the "else if" and "else" branch body are identical the condition has no effect. So removing "else if" condition. Signed-off-by: Aishwarya Ramakrishnan <aishwaryarj100@gmail.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 2 -- 1 file changed, 2 deletions(-)