| Message ID | 20200605224403.181015-2-sebastian.reichel@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | misc. gpio-charger patches | expand |
On Sat, Jun 6, 2020 at 12:44 AM Sebastian Reichel <sebastian.reichel@collabora.com> wrote: > Convert the gpio-charger bindings from text format to > new YAML based representation. > > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> Looks good to me, if it passes the checks: Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On Sat, 06 Jun 2020 00:43:58 +0200, Sebastian Reichel wrote: > Convert the gpio-charger bindings from text format to > new YAML based representation. > > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> > --- > .../bindings/power/supply/gpio-charger.txt | 31 ---------- > .../bindings/power/supply/gpio-charger.yaml | 58 +++++++++++++++++++ > 2 files changed, 58 insertions(+), 31 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/power/supply/gpio-charger.txt > create mode 100644 Documentation/devicetree/bindings/power/supply/gpio-charger.yaml > Reviewed-by: Rob Herring <robh@kernel.org>
Hi, On Sat, Jun 06, 2020 at 12:43:58AM +0200, Sebastian Reichel wrote: > Convert the gpio-charger bindings from text format to > new YAML based representation. > > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> > --- Thanks, queued. -- Sebastian > .../bindings/power/supply/gpio-charger.txt | 31 ---------- > .../bindings/power/supply/gpio-charger.yaml | 58 +++++++++++++++++++ > 2 files changed, 58 insertions(+), 31 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/power/supply/gpio-charger.txt > create mode 100644 Documentation/devicetree/bindings/power/supply/gpio-charger.yaml > > diff --git a/Documentation/devicetree/bindings/power/supply/gpio-charger.txt b/Documentation/devicetree/bindings/power/supply/gpio-charger.txt > deleted file mode 100644 > index 0fb33b2c62a6..000000000000 > --- a/Documentation/devicetree/bindings/power/supply/gpio-charger.txt > +++ /dev/null > @@ -1,31 +0,0 @@ > -gpio-charger > - > -Required properties : > - - compatible : "gpio-charger" > - - gpios : GPIO indicating the charger presence. > - See GPIO binding in bindings/gpio/gpio.txt . > - - charger-type : power supply type, one of > - unknown > - battery > - ups > - mains > - usb-sdp (USB standard downstream port) > - usb-dcp (USB dedicated charging port) > - usb-cdp (USB charging downstream port) > - usb-aca (USB accessory charger adapter) > - > -Optional properties: > - - charge-status-gpios: GPIO indicating whether a battery is charging. > - > -Example: > - > - usb_charger: charger { > - compatible = "gpio-charger"; > - charger-type = "usb-sdp"; > - gpios = <&gpd 28 GPIO_ACTIVE_LOW>; > - charge-status-gpios = <&gpc 27 GPIO_ACTIVE_LOW>; > - }; > - > - battery { > - power-supplies = <&usb_charger>; > - }; > diff --git a/Documentation/devicetree/bindings/power/supply/gpio-charger.yaml b/Documentation/devicetree/bindings/power/supply/gpio-charger.yaml > new file mode 100644 > index 000000000000..78b167c62ab1 > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/supply/gpio-charger.yaml > @@ -0,0 +1,58 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/power/supply/gpio-charger.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: simple battery chargers only communicating through GPIOs > + > +maintainers: > + - Sebastian Reichel <sre@kernel.org> > + > +description: > + This binding is for all chargers, which are working more or less > + autonomously, only providing some status GPIOs and possibly some > + GPIOs for limited control over the charging process. > + > +properties: > + compatible: > + const: gpio-charger > + > + charger-type: > + enum: > + - unknown > + - battery > + - ups > + - mains > + - usb-sdp # USB standard downstream port > + - usb-dcp # USB dedicated charging port > + - usb-cdp # USB charging downstream port > + - usb-aca # USB accessory charger adapter > + description: > + Type of the charger, e.g. "mains" for a wall charger. > + > + gpios: > + maxItems: 1 > + description: GPIO indicating the charger presence > + > + charge-status-gpios: > + maxItems: 1 > + description: GPIO indicating the charging status > + > +required: > + - compatible > + - gpios > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/gpio/gpio.h> > + > + charger { > + compatible = "gpio-charger"; > + charger-type = "usb-sdp"; > + > + gpios = <&gpd 28 GPIO_ACTIVE_LOW>; > + charge-status-gpios = <&gpc 27 GPIO_ACTIVE_LOW>; > + }; > -- > 2.26.2 >
diff --git a/Documentation/devicetree/bindings/power/supply/gpio-charger.txt b/Documentation/devicetree/bindings/power/supply/gpio-charger.txt deleted file mode 100644 index 0fb33b2c62a6..000000000000 --- a/Documentation/devicetree/bindings/power/supply/gpio-charger.txt +++ /dev/null @@ -1,31 +0,0 @@ -gpio-charger - -Required properties : - - compatible : "gpio-charger" - - gpios : GPIO indicating the charger presence. - See GPIO binding in bindings/gpio/gpio.txt . - - charger-type : power supply type, one of - unknown - battery - ups - mains - usb-sdp (USB standard downstream port) - usb-dcp (USB dedicated charging port) - usb-cdp (USB charging downstream port) - usb-aca (USB accessory charger adapter) - -Optional properties: - - charge-status-gpios: GPIO indicating whether a battery is charging. - -Example: - - usb_charger: charger { - compatible = "gpio-charger"; - charger-type = "usb-sdp"; - gpios = <&gpd 28 GPIO_ACTIVE_LOW>; - charge-status-gpios = <&gpc 27 GPIO_ACTIVE_LOW>; - }; - - battery { - power-supplies = <&usb_charger>; - }; diff --git a/Documentation/devicetree/bindings/power/supply/gpio-charger.yaml b/Documentation/devicetree/bindings/power/supply/gpio-charger.yaml new file mode 100644 index 000000000000..78b167c62ab1 --- /dev/null +++ b/Documentation/devicetree/bindings/power/supply/gpio-charger.yaml @@ -0,0 +1,58 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/power/supply/gpio-charger.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: simple battery chargers only communicating through GPIOs + +maintainers: + - Sebastian Reichel <sre@kernel.org> + +description: + This binding is for all chargers, which are working more or less + autonomously, only providing some status GPIOs and possibly some + GPIOs for limited control over the charging process. + +properties: + compatible: + const: gpio-charger + + charger-type: + enum: + - unknown + - battery + - ups + - mains + - usb-sdp # USB standard downstream port + - usb-dcp # USB dedicated charging port + - usb-cdp # USB charging downstream port + - usb-aca # USB accessory charger adapter + description: + Type of the charger, e.g. "mains" for a wall charger. + + gpios: + maxItems: 1 + description: GPIO indicating the charger presence + + charge-status-gpios: + maxItems: 1 + description: GPIO indicating the charging status + +required: + - compatible + - gpios + +additionalProperties: false + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + + charger { + compatible = "gpio-charger"; + charger-type = "usb-sdp"; + + gpios = <&gpd 28 GPIO_ACTIVE_LOW>; + charge-status-gpios = <&gpc 27 GPIO_ACTIVE_LOW>; + };
Convert the gpio-charger bindings from text format to new YAML based representation. Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> --- .../bindings/power/supply/gpio-charger.txt | 31 ---------- .../bindings/power/supply/gpio-charger.yaml | 58 +++++++++++++++++++ 2 files changed, 58 insertions(+), 31 deletions(-) delete mode 100644 Documentation/devicetree/bindings/power/supply/gpio-charger.txt create mode 100644 Documentation/devicetree/bindings/power/supply/gpio-charger.yaml