| Message ID | 20200615095525.43414-1-codrin.ciubotariu@microchip.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/3] ARM: dts: at91: sama5d2_xplained: classd: pull-down the R1 and R3 lines | expand |
On 15/06/2020 12:55:23+0300, Codrin Ciubotariu wrote: > The R1 and R3 lines drive NMOS transistors that are OFF with a low level. > On the SAMA5D2 Xplained board, if the pins corresponding to R1 and R3 > have pull-ups enabled, there is an extra 2 x 30uA power consumption. > Use pull-downs for these 2 lines to remove the unnecessary power > consumption. > > Fixes: b133ca7a653c ("ARM: dts: at91: sama5d2_xplained: add pin muxing and enable classd") > Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com> > --- > arch/arm/boot/dts/at91-sama5d2_xplained.dts | 14 +++++++++----- > 1 file changed, 9 insertions(+), 5 deletions(-) > Applied, thanks.
diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts b/arch/arm/boot/dts/at91-sama5d2_xplained.dts index 055ee53e4773..54d96649da77 100644 --- a/arch/arm/boot/dts/at91-sama5d2_xplained.dts +++ b/arch/arm/boot/dts/at91-sama5d2_xplained.dts @@ -430,14 +430,18 @@ pinctrl_charger_lbo: charger_lbo { bias-pull-up; }; - pinctrl_classd_default: classd_default { + pinctrl_classd_default_pfets: classd_default_pfets { pinmux = <PIN_PB1__CLASSD_R0>, - <PIN_PB2__CLASSD_R1>, - <PIN_PB3__CLASSD_R2>, - <PIN_PB4__CLASSD_R3>; + <PIN_PB3__CLASSD_R2>; bias-pull-up; }; + pinctrl_classd_default_nfets: classd_default_nfets { + pinmux = <PIN_PB2__CLASSD_R1>, + <PIN_PB4__CLASSD_R3>; + bias-pull-down; + }; + pinctrl_flx0_default: flx0_default { pinmux = <PIN_PB28__FLEXCOM0_IO0>, <PIN_PB29__FLEXCOM0_IO1>; @@ -614,7 +618,7 @@ pinctrl_pwm0_pwm2_default: pwm0_pwm2_default { classd: classd@fc048000 { pinctrl-names = "default"; - pinctrl-0 = <&pinctrl_classd_default>; + pinctrl-0 = <&pinctrl_classd_default_pfets &pinctrl_classd_default_nfets>; atmel,pwm-type = "diff"; atmel,non-overlap-time = <10>; status = "okay";
The R1 and R3 lines drive NMOS transistors that are OFF with a low level. On the SAMA5D2 Xplained board, if the pins corresponding to R1 and R3 have pull-ups enabled, there is an extra 2 x 30uA power consumption. Use pull-downs for these 2 lines to remove the unnecessary power consumption. Fixes: b133ca7a653c ("ARM: dts: at91: sama5d2_xplained: add pin muxing and enable classd") Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com> --- arch/arm/boot/dts/at91-sama5d2_xplained.dts | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-)