diff mbox series

[09/73] ARM: tegra: gr2d is not backwards-compatible

Message ID 20200616135238.3001888-10-thierry.reding@gmail.com (mailing list archive)
State New, archived
Headers show
Series ARM: tegra: Various fixes for DT schema validation | expand

Commit Message

Thierry Reding June 16, 2020, 1:51 p.m. UTC
From: Thierry Reding <treding@nvidia.com>

The instantiation of gr2d in Tegra114 is not backwards-compatible with
the version found on earlier chips. Remove the misleading compatible
string.

Signed-off-by: Thierry Reding <treding@nvidia.com>
---
 arch/arm/boot/dts/tegra114.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Dmitry Osipenko June 17, 2020, 4:21 p.m. UTC | #1
16.06.2020 16:51, Thierry Reding пишет:
> From: Thierry Reding <treding@nvidia.com>
> 
> The instantiation of gr2d in Tegra114 is not backwards-compatible with
> the version found on earlier chips. Remove the misleading compatible
> string.
> 
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
>  arch/arm/boot/dts/tegra114.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/tegra114.dtsi b/arch/arm/boot/dts/tegra114.dtsi
> index a0ac9ea9ec9d..d583dfba688f 100644
> --- a/arch/arm/boot/dts/tegra114.dtsi
> +++ b/arch/arm/boot/dts/tegra114.dtsi
> @@ -35,7 +35,7 @@ host1x@50000000 {
>  		ranges = <0x54000000 0x54000000 0x01000000>;
>  
>  		gr2d@54140000 {
> -			compatible = "nvidia,tegra114-gr2d", "nvidia,tegra20-gr2d";
> +			compatible = "nvidia,tegra114-gr2d";
>  			reg = <0x54140000 0x00040000>;
>  			interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>;
>  			clocks = <&tegra_car TEGRA114_CLK_GR2D>;
> 

Could you please explain what's the difference? AFAIK, the 2D HW is
identical on T20/30/114.
Thierry Reding June 22, 2020, 3:22 p.m. UTC | #2
On Wed, Jun 17, 2020 at 07:21:30PM +0300, Dmitry Osipenko wrote:
> 16.06.2020 16:51, Thierry Reding пишет:
> > From: Thierry Reding <treding@nvidia.com>
> > 
> > The instantiation of gr2d in Tegra114 is not backwards-compatible with
> > the version found on earlier chips. Remove the misleading compatible
> > string.
> > 
> > Signed-off-by: Thierry Reding <treding@nvidia.com>
> > ---
> >  arch/arm/boot/dts/tegra114.dtsi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/boot/dts/tegra114.dtsi b/arch/arm/boot/dts/tegra114.dtsi
> > index a0ac9ea9ec9d..d583dfba688f 100644
> > --- a/arch/arm/boot/dts/tegra114.dtsi
> > +++ b/arch/arm/boot/dts/tegra114.dtsi
> > @@ -35,7 +35,7 @@ host1x@50000000 {
> >  		ranges = <0x54000000 0x54000000 0x01000000>;
> >  
> >  		gr2d@54140000 {
> > -			compatible = "nvidia,tegra114-gr2d", "nvidia,tegra20-gr2d";
> > +			compatible = "nvidia,tegra114-gr2d";
> >  			reg = <0x54140000 0x00040000>;
> >  			interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>;
> >  			clocks = <&tegra_car TEGRA114_CLK_GR2D>;
> > 
> 
> Could you please explain what's the difference? AFAIK, the 2D HW is
> identical on T20/30/114.

My understanding is that the IP core itself is identical. However, the
compatible string really describes the integration of the IP, which in
case of Tegra114 is slightly different in that it's part of the HEG
power partition, whereas it wasn't previously.

That means that without knowledge of the power partition we won't be
able to access the gr2d IP on Tegra114 at all and hence it isn't
backwards compatible with Tegra20.

Thierry
Dmitry Osipenko June 22, 2020, 3:29 p.m. UTC | #3
22.06.2020 18:22, Thierry Reding пишет:
> On Wed, Jun 17, 2020 at 07:21:30PM +0300, Dmitry Osipenko wrote:
>> 16.06.2020 16:51, Thierry Reding пишет:
>>> From: Thierry Reding <treding@nvidia.com>
>>>
>>> The instantiation of gr2d in Tegra114 is not backwards-compatible with
>>> the version found on earlier chips. Remove the misleading compatible
>>> string.
>>>
>>> Signed-off-by: Thierry Reding <treding@nvidia.com>
>>> ---
>>>  arch/arm/boot/dts/tegra114.dtsi | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm/boot/dts/tegra114.dtsi b/arch/arm/boot/dts/tegra114.dtsi
>>> index a0ac9ea9ec9d..d583dfba688f 100644
>>> --- a/arch/arm/boot/dts/tegra114.dtsi
>>> +++ b/arch/arm/boot/dts/tegra114.dtsi
>>> @@ -35,7 +35,7 @@ host1x@50000000 {
>>>  		ranges = <0x54000000 0x54000000 0x01000000>;
>>>  
>>>  		gr2d@54140000 {
>>> -			compatible = "nvidia,tegra114-gr2d", "nvidia,tegra20-gr2d";
>>> +			compatible = "nvidia,tegra114-gr2d";
>>>  			reg = <0x54140000 0x00040000>;
>>>  			interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>;
>>>  			clocks = <&tegra_car TEGRA114_CLK_GR2D>;
>>>
>>
>> Could you please explain what's the difference? AFAIK, the 2D HW is
>> identical on T20/30/114.
> 
> My understanding is that the IP core itself is identical. However, the
> compatible string really describes the integration of the IP, which in
> case of Tegra114 is slightly different in that it's part of the HEG
> power partition, whereas it wasn't previously.
> 
> That means that without knowledge of the power partition we won't be
> able to access the gr2d IP on Tegra114 at all and hence it isn't
> backwards compatible with Tegra20.

Thank you very much for the clarification! Will nice if this could be
added into the commit's description.
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/tegra114.dtsi b/arch/arm/boot/dts/tegra114.dtsi
index a0ac9ea9ec9d..d583dfba688f 100644
--- a/arch/arm/boot/dts/tegra114.dtsi
+++ b/arch/arm/boot/dts/tegra114.dtsi
@@ -35,7 +35,7 @@  host1x@50000000 {
 		ranges = <0x54000000 0x54000000 0x01000000>;
 
 		gr2d@54140000 {
-			compatible = "nvidia,tegra114-gr2d", "nvidia,tegra20-gr2d";
+			compatible = "nvidia,tegra114-gr2d";
 			reg = <0x54140000 0x00040000>;
 			interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>;
 			clocks = <&tegra_car TEGRA114_CLK_GR2D>;