| Message ID | 20200624150704.2729736-6-lee.jones@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Fix a bunch of W=1 warnings in MFD | expand |
Hi Lee, On Wed, Jun 24, 2020 at 11:07 PM Lee Jones <lee.jones@linaro.org> wrote: > > Sparse reports: > > drivers/mfd/sprd-sc27xx-spi.c:59:23: warning: symbol 'sprd_pmic_detect_charger_type' was not declared. Should it be static? > > ... due to a missing header file. > > Cc: <stable@vger.kernel.org> > Cc: Orson Zhai <orsonzhai@gmail.com> > Cc: Baolin Wang <baolin.wang7@gmail.com> > Cc: Chunyan Zhang <zhang.lyra@gmail.com> > Signed-off-by: Lee Jones <lee.jones@linaro.org> Thanks. Reviewed-by: Baolin Wang <baolin.wang7@gmail.com> > --- > drivers/mfd/sprd-sc27xx-spi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mfd/sprd-sc27xx-spi.c b/drivers/mfd/sprd-sc27xx-spi.c > index 33336cde47243..c305e941e435c 100644 > --- a/drivers/mfd/sprd-sc27xx-spi.c > +++ b/drivers/mfd/sprd-sc27xx-spi.c > @@ -7,6 +7,7 @@ > #include <linux/kernel.h> > #include <linux/module.h> > #include <linux/mfd/core.h> > +#include <linux/mfd/sc27xx-pmic.h> > #include <linux/of_device.h> > #include <linux/regmap.h> > #include <linux/spi/spi.h> > -- > 2.25.1 >
diff --git a/drivers/mfd/sprd-sc27xx-spi.c b/drivers/mfd/sprd-sc27xx-spi.c index 33336cde47243..c305e941e435c 100644 --- a/drivers/mfd/sprd-sc27xx-spi.c +++ b/drivers/mfd/sprd-sc27xx-spi.c @@ -7,6 +7,7 @@ #include <linux/kernel.h> #include <linux/module.h> #include <linux/mfd/core.h> +#include <linux/mfd/sc27xx-pmic.h> #include <linux/of_device.h> #include <linux/regmap.h> #include <linux/spi/spi.h>
Sparse reports: drivers/mfd/sprd-sc27xx-spi.c:59:23: warning: symbol 'sprd_pmic_detect_charger_type' was not declared. Should it be static? ... due to a missing header file. Cc: <stable@vger.kernel.org> Cc: Orson Zhai <orsonzhai@gmail.com> Cc: Baolin Wang <baolin.wang7@gmail.com> Cc: Chunyan Zhang <zhang.lyra@gmail.com> Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/mfd/sprd-sc27xx-spi.c | 1 + 1 file changed, 1 insertion(+)