From patchwork Thu Jun 25 16:36:13 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11625753 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8F50A92A for ; Thu, 25 Jun 2020 16:40:03 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6529A20775 for ; Thu, 25 Jun 2020 16:40:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bT+qc02Y"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Clvr0gA4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6529A20775 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KcEb4cXOSISXp2rG4n09eDIbk+qiWl/1EoRjypI73kE=; b=bT+qc02Yizn+rkfujMHSwoZP/ mpV6YsANqaumeICZLpjsEnlx0zuP6ML7vAB2GUSEbmUZbFCnTEtZWind1QUZQ2ZBAXSUhLV+hvsIM 5Wzf5qQ8L/uxyqM4jnwdBIKyBFqf9hYfL2SKWQM22jxugmb2ZYtfVrVUwZfxLjI8hQo53Mg+phvmb jd0bWuMn5ZD4hA60z+gF3qgQS2zBnpRKllLbRVy/G41orVzpM/FU5KMhZu8Gg1E484LU3+Hhiz4+7 Uur88wZ8ZOGri3MSgW1mbxLhral09VOMsYhkz2VDlE+5+RFgEnBmFVL/ciPHC/2xzvsEjwl3pUGgr e8Tn/TDhg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joUt3-0006ou-JA; Thu, 25 Jun 2020 16:38:05 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1joUra-00069H-WF for linux-arm-kernel@lists.infradead.org; Thu, 25 Jun 2020 16:36:39 +0000 Received: by mail-wr1-x441.google.com with SMTP id f7so3525150wrw.1 for ; Thu, 25 Jun 2020 09:36:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=p8b+PVloZKecBIPRr/OI23SwGO/e4hTRF+SmOkygulE=; b=Clvr0gA4nLJBZGW6W/+HM9VWedZywRI9gj5x8nbcChWuKDVxsOPcRqm7opsvillYev VnVcVawCHAs8atU6mQP1AWBBYIqUyZ4pcdT06OcEnaS3BK+Yd043lFERn83GnlFAq+RJ Hwp75B6pHUL1Jm7ON5CEN+o+kne7pIVGhQ7rZlXaRVc0Wmwlfe71YmqKo9tV3gdB+mq4 get8f7O5pMdch0xN3a8XCzwfJcHqdNnuyMGX24kEXxzEb33aLnQFyOlBI/RJBCKMjCPN m/yWapgMU5DHtKSQwOYafBEfjASBncKU/oB1ppJqV37Zf+eSN24EdsC22njJm+696N0y 7BHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=p8b+PVloZKecBIPRr/OI23SwGO/e4hTRF+SmOkygulE=; b=bGvAb/GF2xzxG6ClWLMBVnR+do3ZIq7+dPuj5FkE+fDPcHZomkjEfTc+GzvK/FycBm 5ORRMXOofoZEoXl7yJTuiDyEk/Va/Adm8lRyXTLbVT+uzlIl4BH6g1Fs1XwjyN1HSgg2 ALlYUelMcsktYuTkmF3GwnWrF07uTeNmI7GCgKZY7fznmdJSVsszdSPrgG30kdYGYWEf +8AURioj9Ok/gimSI4j44epwY75L+Yk0bBz7OzGnYqjSuApMAxDre5zMUyrC43X5kEOh l5V/NJXBrqMOQUUD2UlGnWVt5Rgc9r9cFOPRjvYF6c4KMkGNyEYiSSBCH63/NI0rtDMX jPcg== X-Gm-Message-State: AOAM530KSLSfRvzJ5FxA1XR9+BodGopl+Y0oWHPapNQGkh8vFVMQMRay 0XdLJuWB5wg3Kh3rK/jpzZmchg== X-Google-Smtp-Source: ABdhPJyr1ofOi7hZPmKskeIrOB05REDu3cC6GxuHEK6qzVDcUnQbMElvkDMUwm1aSNxpOCPQ6f7Jig== X-Received: by 2002:adf:8067:: with SMTP id 94mr35980537wrk.427.1593102993280; Thu, 25 Jun 2020 09:36:33 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id a15sm36729089wrh.54.2020.06.25.09.36.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 09:36:32 -0700 (PDT) From: Lee Jones To: lgirdwood@gmail.com, broonie@kernel.org Subject: [PATCH 09/10] regulator: da9063-regulator: Fix .suspend 'initialized field overwritten' warnings Date: Thu, 25 Jun 2020 17:36:13 +0100 Message-Id: <20200625163614.4001403-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200625163614.4001403-1-lee.jones@linaro.org> References: <20200625163614.4001403-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:441 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Looks as though 9f75ce666199 ("regulator: da9063: fix suspend") failed to clean-up all of the existing .suspend variable initialisations. This has led to some 'initilized field overwritten' issues now present in W=1 builds. This patch squashes the following build warnings: In file included from drivers/regulator/da9063-regulator.c:17: include/linux/regmap.h:1124:37: warning: initialized field overwritten [-Woverride-init] 1124 | #define REG_FIELD(_reg, _lsb, _msb) { | ^ drivers/regulator/da9063-regulator.c:27:2: note: in expansion of macro ‘REG_FIELD’ 27 | REG_FIELD(_reg, __builtin_ffs((int)_mask) - 1, | ^~~~~~~~~ drivers/regulator/da9063-regulator.c:515:14: note: in expansion of macro ‘BFIELD’ 515 | .suspend = BFIELD(DA9063_REG_LDO9_CONT, DA9063_VLDO9_SEL), | ^~~~~~ include/linux/regmap.h:1124:37: note: (near initialization for ‘da9063_regulator_info[11].suspend’) 1124 | #define REG_FIELD(_reg, _lsb, _msb) { | ^ drivers/regulator/da9063-regulator.c:27:2: note: in expansion of macro ‘REG_FIELD’ 27 | REG_FIELD(_reg, __builtin_ffs((int)_mask) - 1, | ^~~~~~~~~ drivers/regulator/da9063-regulator.c:515:14: note: in expansion of macro ‘BFIELD’ 515 | .suspend = BFIELD(DA9063_REG_LDO9_CONT, DA9063_VLDO9_SEL), | ^~~~~~ Signed-off-by: Lee Jones --- drivers/regulator/da9063-regulator.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/regulator/da9063-regulator.c b/drivers/regulator/da9063-regulator.c index e1d6c8f6d40bb..fe65b5acaf280 100644 --- a/drivers/regulator/da9063-regulator.c +++ b/drivers/regulator/da9063-regulator.c @@ -512,7 +512,6 @@ static const struct da9063_regulator_info da9063_regulator_info[] = { }, { DA9063_LDO(DA9063, LDO9, 950, 50, 3600), - .suspend = BFIELD(DA9063_REG_LDO9_CONT, DA9063_VLDO9_SEL), }, { DA9063_LDO(DA9063, LDO11, 900, 50, 3600),