From patchwork Thu Jun 25 19:17:07 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11626999 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3647E92A for ; Fri, 26 Jun 2020 09:55:30 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E97AA2053B for ; Fri, 26 Jun 2020 09:55:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oh9N0tTf"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="U2NxEfmv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E97AA2053B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=q4niIU/lk28j9EL/joCiRcELI45f8riD+3jwFpWYDxo=; b=oh9N0tTfXLeUoAaRAUSZPuDo6 62v7U7mkQbdpqqsOGAymQd7jwHAcudehLwgwOr2wpYZYd6bJrGgk/9dNoIJWSX/8ee9IcEnK5Pze0 c8vjfPFgqEWdMjTtTmPjf9DCIhICwLnK5ESqPPzuwqj6gopM1ne7Mn5ZODeVUSETH+8MczZqwgl+W klaSfl1m4Pc7bf+830C1YFegyC7LB5gEx9d9LhHFhHkubEusepAvVrxF6W4JIit+6+22An31X1T3f biIFPAMKhowY8Ig+amRyrwQgzTkMybldZb5trN/wJefbaCdbKy/iA9NJRho/8tHGs8Tpd6oAsDAdR PPpKWeqZg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jol2k-00040c-0x; Fri, 26 Jun 2020 09:53:10 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jokeK-0000ub-Oo for linux-arm-kernel@lists.infradead.org; Fri, 26 Jun 2020 09:28:26 +0000 Received: by mail-wm1-x344.google.com with SMTP id a6so8470605wmm.0 for ; Fri, 26 Jun 2020 02:27:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xLynNpCT3aHwFMp9X5o+Fu0+7LET71ajpqSGjxj/VKI=; b=U2NxEfmvuzlHjSdqFrB1DTCE1IiLf6GxQI/mZCkymUUYetLIbpidegjuARBEpicPGQ SNxET/9290AhKWxrDFozhx518+EeIO9ctBFjEGTs0jSKZHie79lqbOw1iiDKLQt9EDFu 2omYoJoG6p1TeXQGaNtlqqfywIKA8zuqPz4U2b+r2sZepAMRdm+UJIo0GXnI51eZHAIu bCHRewtKelLzEBBhvIVEIpHkVOaefYVPAtfUlejG++R38YV1oPzV7lR0oCC1ky1+UojM hFgAO5zK9mFjdlUC5B4YcC9QscMdPkFoxvorPIA9jnvRG9Ig6T8bTpbV5FtaXundYkEL 7uag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xLynNpCT3aHwFMp9X5o+Fu0+7LET71ajpqSGjxj/VKI=; b=QVjafeg6c+cKb6srsECYAcHdKjteXS6d8QBGjR6Rw25JWwAxoWXXQnn+OpG6DNFnRQ gTtNv0opNbF1E/QBbzFqmve73/13+BJd/nT35O+vyk+g7QUInb0G2xCGPRqqLfe5bJ/9 i1p5EcdimJj4HWUMusiTDCe9WkXminVxyabLySokGy3mjF3Eb8LbLaj/BGVHA2tGLmWD PdsK/jYcfudoyCNoV7Zpywq0TOjrvMHe9B8KsAO3KlJsqiZdhB0P0xK8A/O6wdqIg2PQ xNHqi3HqjRf5+v4CyXlwgWT1+mvaThC2ju1cZ6+g3ywssLKUUrRHjlEklENXBfuyQHql f1jg== X-Gm-Message-State: AOAM533gjmHLgIaYtUylSwuFXpfSGHKJFuBMMMSf0AxtZjzWuqjdbB3g pJs1nLjVY/vnEkwaSkmftCl98a+E4nCFbA== X-Google-Smtp-Source: ABdhPJzqCiWgHDKk7Wbw62YYaS6BBq8yV0ZPPzWnBmFbpkw3OTjfzMibwAVS5PPLDhCF7SnZwq49vw== X-Received: by 2002:a1c:96ce:: with SMTP id y197mr5307426wmd.55.1593112644657; Thu, 25 Jun 2020 12:17:24 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id p13sm22693983wrn.0.2020.06.25.12.17.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 12:17:23 -0700 (PDT) From: Lee Jones To: lgirdwood@gmail.com, broonie@kernel.org Subject: [RESEND 09/10] regulator: da9063-regulator: Fix .suspend 'initialized field overwritten' warnings Date: Thu, 25 Jun 2020 20:17:07 +0100 Message-Id: <20200625191708.4014533-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200625191708.4014533-1-lee.jones@linaro.org> References: <20200625191708.4014533-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:344 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Krystian Garbaciak , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Support Opensource Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Looks as though 99f75ce666199 ("regulator: da9063: fix suspend") failed to clean-up all of the existing .suspend variable initialisations. This has led to some 'initilized field overwritten' issues now present in W=1 builds. This patch squashes the following build warnings: In file included from drivers/regulator/da9063-regulator.c:17: include/linux/regmap.h:1124:37: warning: initialized field overwritten [-Woverride-init] 1124 | #define REG_FIELD(_reg, _lsb, _msb) { | ^ drivers/regulator/da9063-regulator.c:27:2: note: in expansion of macro ‘REG_FIELD’ 27 | REG_FIELD(_reg, __builtin_ffs((int)_mask) - 1, | ^~~~~~~~~ drivers/regulator/da9063-regulator.c:515:14: note: in expansion of macro ‘BFIELD’ 515 | .suspend = BFIELD(DA9063_REG_LDO9_CONT, DA9063_VLDO9_SEL), | ^~~~~~ include/linux/regmap.h:1124:37: note: (near initialization for ‘da9063_regulator_info[11].suspend’) 1124 | #define REG_FIELD(_reg, _lsb, _msb) { | ^ drivers/regulator/da9063-regulator.c:27:2: note: in expansion of macro ‘REG_FIELD’ 27 | REG_FIELD(_reg, __builtin_ffs((int)_mask) - 1, | ^~~~~~~~~ drivers/regulator/da9063-regulator.c:515:14: note: in expansion of macro ‘BFIELD’ 515 | .suspend = BFIELD(DA9063_REG_LDO9_CONT, DA9063_VLDO9_SEL), | ^~~~~~ Cc: Krystian Garbaciak Cc: Support Opensource Signed-off-by: Lee Jones --- drivers/regulator/da9063-regulator.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/regulator/da9063-regulator.c b/drivers/regulator/da9063-regulator.c index e1d6c8f6d40bb..fe65b5acaf280 100644 --- a/drivers/regulator/da9063-regulator.c +++ b/drivers/regulator/da9063-regulator.c @@ -512,7 +512,6 @@ static const struct da9063_regulator_info da9063_regulator_info[] = { }, { DA9063_LDO(DA9063, LDO9, 950, 50, 3600), - .suspend = BFIELD(DA9063_REG_LDO9_CONT, DA9063_VLDO9_SEL), }, { DA9063_LDO(DA9063, LDO11, 900, 50, 3600),