From patchwork Thu Jun 25 21:43:11 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandre Belloni X-Patchwork-Id: 11627591 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 230BF913 for ; Fri, 26 Jun 2020 13:09:57 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EFC462081A for ; Fri, 26 Jun 2020 13:09:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PPdK1mIS"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="tUwO7zWC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EFC462081A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=H3UxUMq8Dz3jacfedk3AU9ihnjJjqk/z25qFH4VxDmY=; b=PPdK1mISBieUF0WMw0s1iWFgr WomvklY0Rw1kyF8hgKYU+88lQy76l2veOi5VV6WzWyIa7+e9EXq6cEH2HqoQuI9qTR4SguXDa5zsq 0tgln18etqspZACbGFMuwxhLrdX+AkdZ7cp8zBzszpJQ6yDJORTOI210j787a2nHDDKG20Q4YoaNA BDQ2u/K0PJgPhuJc9PZsMCdrkyMJZQ4Wova87votRYOmRvWh8HxZ2jZhIx5sCI0TA3GTQ9fD9IxSZ idjXDgDfemRr10RTE+ZAkkLNsBEuEHuzFPj2vhNtghyepTxrP9grXKNX8EkvPTWWjUxSkipSHg1vZ 2uAItvySQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joo5A-0003nd-Kq; Fri, 26 Jun 2020 13:07:53 +0000 Received: from casper.infradead.org ([90.155.50.34]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jolMa-0000YK-8n for linux-arm-kernel@merlin.infradead.org; Fri, 26 Jun 2020 10:13:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=OInbPXnBEWJq/wj7HkX05d/p7q4R3q8EvNVT7UZ/pHg=; b=tUwO7zWCyklEB8zLbTgtuCdby6 hTbgFj1PmrwGYYFV9l85E9qRmVUSAM87fmzkC4UEJHRIKTLwqJ0eXl0snT2Vqbi4hLc4J8hlshisW l5Mr+GnC2rcNbAlBuOWBbOgb21LmAj4a9xClKxScsPCK+9WyQxkm9VDDSnmAGg/u0azyZY2z1fYk0 vWG0qM/F2BjwfLDWtLPJkyWb2xehf3YYSgG5T2Gz4BBe923msZJ09wE845eLX01DQ0yWRZl49uUyL mkRX1/vwa3JYpIgtbtS2jyi9pb8GirwG0HMpr0YYodFaUpcMZ4v+T8DcSZAcXi5rk5upV5JidDfiG b1H7b0Aw==; Received: from relay7-d.mail.gandi.net ([217.70.183.200]) by casper.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1joZev-0000bz-S3 for linux-arm-kernel@lists.infradead.org; Thu, 25 Jun 2020 21:43:54 +0000 X-Originating-IP: 86.202.110.81 Received: from localhost (lfbn-lyo-1-15-81.w86-202.abo.wanadoo.fr [86.202.110.81]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 0009720006; Thu, 25 Jun 2020 21:43:27 +0000 (UTC) From: Alexandre Belloni To: Daniel Lezcano Subject: [PATCH v5 8/9] clocksource/drivers/timer-atmel-tcb: allow selecting first divider Date: Thu, 25 Jun 2020 23:43:11 +0200 Message-Id: <20200625214312.1382063-9-alexandre.belloni@bootlin.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200625214312.1382063-1-alexandre.belloni@bootlin.com> References: <20200625214312.1382063-1-alexandre.belloni@bootlin.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200625_224350_305848_C1311579 X-CRM114-Status: GOOD ( 11.48 ) X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.4.4 on casper.infradead.org summary: Content analysis details: (-2.6 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [217.70.183.200 listed in wl.mailspike.net] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [217.70.183.200 listed in list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kamel.bouhara@bootlin.com, Alexandre Belloni , Sebastian Andrzej Siewior , linux-kernel@vger.kernel.org, Thomas Gleixner , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org The divider selection algorithm never allowed to get index 0. It was also continuing to look for dividers, trying to find the slow clock selection. This is not necessary anymore. Signed-off-by: Alexandre Belloni --- drivers/clocksource/timer-atmel-tcb.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/clocksource/timer-atmel-tcb.c b/drivers/clocksource/timer-atmel-tcb.c index 8fcd4d74c54b..ccb77b9cb489 100644 --- a/drivers/clocksource/timer-atmel-tcb.c +++ b/drivers/clocksource/timer-atmel-tcb.c @@ -432,10 +432,8 @@ static int __init tcb_clksrc_init(struct device_node *node) tmp = rate / divisor; pr_debug("TC: %u / %-3u [%d] --> %u\n", rate, divisor, i, tmp); - if (best_divisor_idx > 0) { - if (tmp < 5 * 1000 * 1000) - continue; - } + if ((best_divisor_idx >= 0) && (tmp < 5 * 1000 * 1000)) + break; divided_rate = tmp; best_divisor_idx = i; }