From patchwork Mon Jun 29 14:04:33 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11631001 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id AE19992A for ; Mon, 29 Jun 2020 14:08:13 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8593E23D99 for ; Mon, 29 Jun 2020 14:08:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qEkRoy1p"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="a6lY1hwR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8593E23D99 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hJG/GrEf5GflKF9q2ls22g8DgyEpifs04AjKtQLIhs0=; b=qEkRoy1pFI15umNuh4H/iphvh 6PweD5aGwE7b+uFb7Ao/V4Q5sOD7ZcT/I5XBnD4M7LL/rnfKo1qf7KDvVVtM7B+IMVBBC7cFtQU5D Vn4rwG1q/amoeBDePlwdKtecYgCBVrEnp+KUMwReW3IdY9xFGZJI8gEJIngj7r6V/4wtCkDLD199f F/0jrxMVH/wq9y5ZutjbKHuQ+UernUtr2gAZWV/63bS06KZDbKazyt3ncJaSmdQI7VX/SGYr/ft/e 23Wg2k+RZpyNe0zJ6hNXBc3+u+/ADaPuQDdSFH8Cg8UW155XcPYbQKnm9O6YiWp5jOaPSHUf472Ev /YXuXr3yw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpuQG-0004go-7R; Mon, 29 Jun 2020 14:06:12 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpuP6-0004FU-Hl for linux-arm-kernel@lists.infradead.org; Mon, 29 Jun 2020 14:05:02 +0000 Received: by mail-wm1-x344.google.com with SMTP id f139so16235729wmf.5 for ; Mon, 29 Jun 2020 07:05:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KG862h2vmccOR30Zy+dEvVE74O1dfXe3tQ9ea9Wl0kU=; b=a6lY1hwRQfrrWwQ+wHSUIGy11GsRdeUlhhyJ0ZzZ4czs3V0mgD5NY7lzixVzuUWzlL akdh+Uv6PTnpAKv4iWUHoYDESL7HfZjPqk9/WM7W3w6T2yrZmrwO9FRiBuIBV0deyNo+ zfStV9k4eSj/vx0x15mO3/VJWdg+hl3nt0cQX3K1bu+ZJurQBip0CMxhGHy0VIb6MP9b oxFY1I/GLar0bZxP0OGjfUvxGvX0VFDkl2k6Qd2SztjENj+Vo76dCcgV5R005s+8cfrh a0jr0UdpYMJ5rWgozkUzZeZLAUBB1FWNf3xP+ebdGw/sy4Es8VLllhYU0opQNaHghjNf y1LA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KG862h2vmccOR30Zy+dEvVE74O1dfXe3tQ9ea9Wl0kU=; b=i2IybNspe3OSABFeVV6P0dNabWz+5Evu3tEDcy2l7Jrin9D5wrVHJ7MV+HqJIdy1oT 4Txtmy2fvciKT9ut5uLVQQrx1s/fnk27WTaQrHJyJ4VmXJMLe1pcV7DwWCdOjE6DZwOG S90G2v7wupL33DcFxBf84ym3t5HKJu9FQkhsaMvRFc/SpDi6mQVz1eRUH8e7G+Mk0ijN MGe9QwsnRhs8RCoMTp8WmeJaF6WtmDnGBLTEZ3QH8qJayE6DrpEZe42fjLlKSkt58j2V 9KIi2UvqMQ+FN50cmFjnuZjcnBfEwNEu9H8aaj3nka0kT19ZnUL7wbk5tMzc7TOf6top gp6g== X-Gm-Message-State: AOAM530gRLDKVrvHMkhcDfruJSZNXMPyUFAVkGgmnotOTxa27ttfSNzu baIMG5RUUH3eNi899XWG+PTc6g== X-Google-Smtp-Source: ABdhPJz/fRbJ6fyCO1SuMHt5E5sUIRbeH3s/cAZ07coPEBwFUMgIQRAVseQRxEZ6RHFD+GJq655Rlg== X-Received: by 2002:a05:600c:414f:: with SMTP id h15mr5965306wmm.82.1593439499585; Mon, 29 Jun 2020 07:04:59 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id p14sm15394928wrj.14.2020.06.29.07.04.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2020 07:04:58 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 11/20] misc: enclosure: Fix some kerneldoc anomalies Date: Mon, 29 Jun 2020 15:04:33 +0100 Message-Id: <20200629140442.1043957-12-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200629140442.1043957-1-lee.jones@linaro.org> References: <20200629140442.1043957-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:344 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: James Bottomley , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Firstly some missing function argument documentation, then some whch are present, but are incorrectly named. Fixes the following W=1 kernel build warnings: drivers/misc/enclosure.c:115: warning: Function parameter or member 'name' not described in 'enclosure_register' drivers/misc/enclosure.c:115: warning: Function parameter or member 'cb' not described in 'enclosure_register' drivers/misc/enclosure.c:283: warning: Function parameter or member 'number' not described in 'enclosure_component_alloc' drivers/misc/enclosure.c:283: warning: Excess function parameter 'num' description in 'enclosure_component_alloc' drivers/misc/enclosure.c:363: warning: Function parameter or member 'component' not described in 'enclosure_add_device' drivers/misc/enclosure.c:363: warning: Excess function parameter 'num' description in 'enclosure_add_device' drivers/misc/enclosure.c:398: warning: Function parameter or member 'dev' not described in 'enclosure_remove_device' drivers/misc/enclosure.c:398: warning: Excess function parameter 'num' description in 'enclosure_remove_device' Cc: James Bottomley Signed-off-by: Lee Jones --- drivers/misc/enclosure.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/misc/enclosure.c b/drivers/misc/enclosure.c index 3c2d405bc79b9..e8eba52750b34 100644 --- a/drivers/misc/enclosure.c +++ b/drivers/misc/enclosure.c @@ -103,7 +103,9 @@ EXPORT_SYMBOL_GPL(enclosure_for_each_device); * enclosure_register - register device as an enclosure * * @dev: device containing the enclosure + * @name: chosen device name * @components: number of components in the enclosure + * @cb: platform call-backs * * This sets up the device for being an enclosure. Note that @dev does * not have to be a dedicated enclosure device. It may be some other type @@ -266,7 +268,7 @@ static const struct attribute_group *enclosure_component_groups[]; /** * enclosure_component_alloc - prepare a new enclosure component * @edev: the enclosure to add the component - * @num: the device number + * @number: the device number * @type: the type of component being added * @name: an optional name to appear in sysfs (leave NULL if none) * @@ -347,7 +349,7 @@ EXPORT_SYMBOL_GPL(enclosure_component_register); /** * enclosure_add_device - add a device as being part of an enclosure * @edev: the enclosure device being added to. - * @num: the number of the component + * @component: the number of the component * @dev: the device being added * * Declares a real device to reside in slot (or identifier) @num of an