From patchwork Mon Jun 29 14:04:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11631011 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 02EE892A for ; Mon, 29 Jun 2020 14:09:04 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CFC2B23D9B for ; Mon, 29 Jun 2020 14:09:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="iTGZOuOb"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="UerGcuAl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CFC2B23D9B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7wUs4r0YSRqb5eaat3R52cN/7Y3ATwdFFDg5TUcJSk8=; b=iTGZOuObKhWVuK+opLs9oeRDY 1snU5Dxx1p+76LOHIoDvlCekfkFTJoqJ8J6FVSR3DO8aAKSSBRuMxlG4t6l8ISYt+CuEbgeLR02Pa qIDaAiNFeyGzlzJz1eNdq3kMxIIeIMQUt13VzTXS1YXwZAb46RKNm9jaMOTIj+6EuxKTI+1u7ZxJX 07fyLmHCVrumjg8AjtLmMScNQ7xZbEqtVD8/BCyhQPtciUGNaN0WPSaqgdJdlmiGcp1fU9NQyFP5W whDVNwQvNMpgV8AAqooA+xSu4Y+qRrWMD5EbUY5V+tLo46Yk6atRt5BAA5ghY+BsqHuVWgFOar2Xq cwdivI8kw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpuQx-00057p-Mp; Mon, 29 Jun 2020 14:06:55 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpuPC-0004HO-QM for linux-arm-kernel@lists.infradead.org; Mon, 29 Jun 2020 14:05:08 +0000 Received: by mail-wr1-x444.google.com with SMTP id g18so16717165wrm.2 for ; Mon, 29 Jun 2020 07:05:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=t94gU7LdZ9jhuE6Fuy5QcBW6wxTpYHr3wMA3J0Azebg=; b=UerGcuAlj7Z9MLnen9oULz1ZCNnOGBCp6prj5iOmxWAPp79uH10ApRql/esij74qU1 TWwBUWUwXKybD7mLCIFuxnDkchZH4v0l7AhLDtvi1LP5qGhTW5sQI1CWSfJzFZ2r0vbq iNCHT11TSH8gowVpzmfcRa9Ybi5BKsZNrAdCaLmXiEmJdHZQ/WB4GD2FFJw0jldyNHWe 1OOZfR50UhVxtQc3KBBvl3eGL4DEhf4K/Wvr3X/HV9mV+Jt0MY2ytHYcvMJwARnRZ6kJ Ug4lNp8IbJIuT+yzwH5HioKnq78YX5xRE4ZSMXGPflUPfa9qFJlKYMJqu8veJZDVafd/ ORJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=t94gU7LdZ9jhuE6Fuy5QcBW6wxTpYHr3wMA3J0Azebg=; b=J2w9X+9JIxykxFLIn13D8O1TQgdl/Gvc5vVefTa5nPb82mtzqz94CtoKmoC2GxyWlu a85wfvOXIZx8xJBmUlO2nb/mlcs/0+WYNTfnlQHeNj5sSlIFbIxqE58qb45X2crbZaCq BY4V3jA/JSPh3V0KpsXX1dZUub787r/qwsCEtHuttRw3S2hF6wEIMPEUmT88vz/g8j2W QdUQtNMgiwDL9wSdiRmZo0h8pFNoYA7ilHCfWQRasJ2J9b8891O4fCxVsr0NnFVxlrwT xLAgIZ2cP+Q955iongt5yczg++IHbPpjL4Kvk0AOReGq3WTazUAK1ZXWTPuTX2uPLm0F sjYw== X-Gm-Message-State: AOAM532c7irGcQa7RIGkF6UCxsffBljtjfLoOjFVugLqovEe7QTnpTQy Q8Bm6FwEQErKG2xI6jS9ENUm9Q== X-Google-Smtp-Source: ABdhPJwmw6HtLwtc/BWKL7jvIFL/StauXcjQlFWHZqdNshQG+W/DhIyNUji82FIRqL0MnKMNZWFvkg== X-Received: by 2002:a5d:6846:: with SMTP id o6mr17265668wrw.370.1593439505791; Mon, 29 Jun 2020 07:05:05 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id p14sm15394928wrj.14.2020.06.29.07.05.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2020 07:05:05 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 16/20] misc: genwqe: card_base: Remove set but unused variable 'rc' Date: Mon, 29 Jun 2020 15:04:38 +0100 Message-Id: <20200629140442.1043957-17-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200629140442.1043957-1-lee.jones@linaro.org> References: <20200629140442.1043957-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:444 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Joerg-Stephan Vogt , Michael Ruettger , Frank Haverkamp , linux-kernel@vger.kernel.org, Michael Jung , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Variable 'rc' hasn't been checked since the driver's inception in 2013. If it hasn't caused any issues since then, it's unlikely to in the future. Let's take it out for now. Fixes the following W=1 kernel build warning(s): drivers/misc/genwqe/card_base.c: In function ‘genwqe_health_check_stop’: /home/lee/projects/linux/kernel/drivers/misc/genwqe/card_base.c:1046:6: warning: variable ‘rc’ set but not used [-Wunused-but-set-variable] 1046 | int rc; | ^~ Cc: Michael Jung Cc: Michael Ruettger Cc: Frank Haverkamp Cc: Joerg-Stephan Vogt Signed-off-by: Lee Jones Signed-off-by: Frank Haverkamp Acked-by: Frank Haverkamp --- drivers/misc/genwqe/card_base.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/misc/genwqe/card_base.c b/drivers/misc/genwqe/card_base.c index 1dc6c7c5cbce9..bceebf49de2d5 100644 --- a/drivers/misc/genwqe/card_base.c +++ b/drivers/misc/genwqe/card_base.c @@ -1043,12 +1043,10 @@ static int genwqe_health_thread_running(struct genwqe_dev *cd) static int genwqe_health_check_stop(struct genwqe_dev *cd) { - int rc; - if (!genwqe_health_thread_running(cd)) return -EIO; - rc = kthread_stop(cd->health_thread); + kthread_stop(cd->health_thread); cd->health_thread = NULL; return 0; }