| Message ID | 20200629140442.1043957-8-lee.jones@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Fix a bunch more W=1 warnings in Misc | expand |
On Mon, Jun 29, 2020 at 5:04 PM Lee Jones <lee.jones@linaro.org> wrote: > > 'dma_mask' is not passed directly into hl_pci_set_dma_mask() as > an argument. Instead, it is pulled from struct hl_device *hdev. > > Fixed the following W=1 warning: > > drivers/misc/habanalabs/pci.c:328: warning: Excess function parameter 'dma_mask' description in 'hl_pci_set_dma_mask > > Cc: Oded Gabbay <oded.gabbay@gmail.com> > Cc: Tomer Tayar <ttayar@habana.ai> > Signed-off-by: Lee Jones <lee.jones@linaro.org> > --- > drivers/misc/habanalabs/pci.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/misc/habanalabs/pci.c b/drivers/misc/habanalabs/pci.c > index 24073e8eb8df9..61a8bb07262cf 100644 > --- a/drivers/misc/habanalabs/pci.c > +++ b/drivers/misc/habanalabs/pci.c > @@ -317,7 +317,6 @@ int hl_pci_init_iatu(struct hl_device *hdev, u64 sram_base_address, > /** > * hl_pci_set_dma_mask() - Set DMA masks for the device. > * @hdev: Pointer to hl_device structure. > - * @dma_mask: number of bits for the requested dma mask. > * > * This function sets the DMA masks (regular and consistent) for a specified > * value. If it doesn't succeed, it tries to set it to a fall-back value > -- > 2.25.1 > This patch is: Reviewed-by: Oded Gabbay <oded.gabbay@gmail.com>
diff --git a/drivers/misc/habanalabs/pci.c b/drivers/misc/habanalabs/pci.c index 24073e8eb8df9..61a8bb07262cf 100644 --- a/drivers/misc/habanalabs/pci.c +++ b/drivers/misc/habanalabs/pci.c @@ -317,7 +317,6 @@ int hl_pci_init_iatu(struct hl_device *hdev, u64 sram_base_address, /** * hl_pci_set_dma_mask() - Set DMA masks for the device. * @hdev: Pointer to hl_device structure. - * @dma_mask: number of bits for the requested dma mask. * * This function sets the DMA masks (regular and consistent) for a specified * value. If it doesn't succeed, it tries to set it to a fall-back value
'dma_mask' is not passed directly into hl_pci_set_dma_mask() as an argument. Instead, it is pulled from struct hl_device *hdev. Fixed the following W=1 warning: drivers/misc/habanalabs/pci.c:328: warning: Excess function parameter 'dma_mask' description in 'hl_pci_set_dma_mask Cc: Oded Gabbay <oded.gabbay@gmail.com> Cc: Tomer Tayar <ttayar@habana.ai> Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/misc/habanalabs/pci.c | 1 - 1 file changed, 1 deletion(-)