From patchwork Mon Jun 29 14:04:30 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11630995 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id DDEFF92A for ; Mon, 29 Jun 2020 14:07:51 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9771A23D98 for ; Mon, 29 Jun 2020 14:07:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="A+FQH0+g"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yR7EVA/J" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9771A23D98 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GBlGkdP9C2bw2vtoFgizCKZEKbC4pJTdQKaQqVU+qvo=; b=A+FQH0+g0rYsBRrNnRE7NJV8L 1OvfWFAKfp94tW2NzjBw5JOZ1DV3/SQi5QbKLEWWw4LrFHUX9O/yvkVYRhCiKn0i5HdXLqdX7mtII J83wePneC9llIMcAPURdn94aosNG2ZPQ3Ko2F4l7OByYm03zr+8lZxVt6dzoP8hg5XsDOPKEhUDot qDw0P8uSB9ljwjh7he8Nv3jOmH6sEgV8hw5Xm9UBZTGHK1nmCzAemIe95tF8PwXdSKNc3tTWESDpa UNECueSVorVZEpPAt7LODeYAXu82/jMxFgieADu5+Mg4kKy/7FDY7nwRNqeflGWol9eK7/iKj+yx7 MM6+frc+Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpuQ0-0004ZB-Si; Mon, 29 Jun 2020 14:05:56 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpuP2-0004EC-J4 for linux-arm-kernel@lists.infradead.org; Mon, 29 Jun 2020 14:04:57 +0000 Received: by mail-wr1-x441.google.com with SMTP id f7so13686167wrw.1 for ; Mon, 29 Jun 2020 07:04:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1S50qko1q+z74H3H0J6W5HtpHbtK1gQwgwBXn9Rlvzc=; b=yR7EVA/JfMBOI9U5dnD0dsDVA/IHZqoG8OX+LKynRnDtfmxafybx4Z1ZVUsa0221gw xWauzNcM5+cKRdOuF6YTMKPahxAdgN3yCtQ2Uowy2mLLdVxBF0BHoY3LFCD+i00XyFrc PkkbwMlKAoH7XAYVQW3PZUvDJdSGvHGDQaUTjVJSTqDj48v/pB2GyvTgRn39wWvEtgZ3 UfIywRtxHwUjIlNYJ8MwtNNzp+LIKvWmUnesoPvAkV8vDuM3NaVZPWOM4bAVYxOfrwaQ Y8/dgvQKIAtTIPTBVuNfuPVJlfZn65WKu1hoX4o20Zi8VRS2aouROf1cs84TMYqlaoM2 95Zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1S50qko1q+z74H3H0J6W5HtpHbtK1gQwgwBXn9Rlvzc=; b=GDU2l62ZIvsgI/1WxEBFIxD5kd7nxNQ6jMAtqdPlnRCTS1BcoQU4WsXcbhJt3k8T4c TM4crNHLSgmKlG+ZubbAb5hGqZVWyHrP9DozL7lGGP/4+IcOCzPiTfSS+k//W6OSQ4Fc 1MR0mDIBm6MktWB0JE6xHlC1//+RqZ6rqUwZrAoDs/5MAt3ttV3IB3eBtmroWp0icyaR b6k/dID47GgbEJPfczufgs3zelFHtuJVnogr/E3nmbxMyK26M9MKEleA9kGnKL2yRN4E xsyuCL7rm9mFeflVCwgN2jHCHTasRD+77vEiFYZFJ0dA+dhR0nI8EVl60zJwxMyYByh4 NcNA== X-Gm-Message-State: AOAM533C+GVSUgWAO1AKmyt7ecDmRh/nztzNcuIWuzr4hESH5takrrTa sZjMClH+D1NXoTMt7TXNPFlLxg== X-Google-Smtp-Source: ABdhPJw7u+pR3PUUjovhGP29vg+5MVuG3YO6weDsgP3XkESH2uz5kK5iz1fARHNMR2qAFPReAFxLOQ== X-Received: by 2002:adf:e901:: with SMTP id f1mr17201511wrm.80.1593439495667; Mon, 29 Jun 2020 07:04:55 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id p14sm15394928wrj.14.2020.06.29.07.04.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2020 07:04:55 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 08/20] misc: habanalabs: goya: goya_coresight: Remove set but unused variable 'val' Date: Mon, 29 Jun 2020 15:04:30 +0100 Message-Id: <20200629140442.1043957-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200629140442.1043957-1-lee.jones@linaro.org> References: <20200629140442.1043957-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:441 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Oded Gabbay , Tomer Tayar , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org No attempt to check the return value of RREG32() has been made since the call was introduced a year ago. Fixes W=1 kernel build warning: drivers/misc/habanalabs/goya/goya_coresight.c: In function ‘goya_debug_coresight’: drivers/misc/habanalabs/goya/goya_coresight.c:643:6: warning: variable ‘val’ set but not used [-Wunused-but-set-variable] 643 | u32 val; | ^~~ Cc: Oded Gabbay Cc: Tomer Tayar Signed-off-by: Lee Jones Reviewed-by: Oded Gabbay --- drivers/misc/habanalabs/goya/goya_coresight.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/misc/habanalabs/goya/goya_coresight.c b/drivers/misc/habanalabs/goya/goya_coresight.c index 1258724ea5106..aa51fc71f0a1f 100644 --- a/drivers/misc/habanalabs/goya/goya_coresight.c +++ b/drivers/misc/habanalabs/goya/goya_coresight.c @@ -640,7 +640,6 @@ static int goya_config_spmu(struct hl_device *hdev, int goya_debug_coresight(struct hl_device *hdev, void *data) { struct hl_debug_params *params = data; - u32 val; int rc = 0; switch (params->op) { @@ -672,7 +671,7 @@ int goya_debug_coresight(struct hl_device *hdev, void *data) } /* Perform read from the device to flush all configuration */ - val = RREG32(mmPCIE_DBI_DEVICE_ID_VENDOR_ID_REG); + RREG32(mmPCIE_DBI_DEVICE_ID_VENDOR_ID_REG); return rc; }