| Message ID | 20200629195727.9717-1-rikard.falkeborn@gmail.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 82c8d38699009697f3136f5347d0903befdce810 |
| Headers | show |
| Series | phy: allwinner: phy-sun6i-mipi-dphy: Constify structs | expand |
On Mon, Jun 29, 2020 at 09:57:27PM +0200, Rikard Falkeborn wrote: > sun6i_dphy_ops and sun6i_dphy_regmap_config are not modified so make them > const structs to allow the compiler to put them in read-only memory. > > Before: > text data bss dec hex filename > 4407 1944 64 6415 190f drivers/phy/allwinner/phy-sun6i-mipi-dphy.o > > After: > text data bss dec hex filename > 4835 1496 64 6395 18fb drivers/phy/allwinner/phy-sun6i-mipi-dphy.o > > Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com> Acked-by: Maxime Ripard <mripard@kernel.org> Thanks! Maxime
On 29-06-20, 21:57, Rikard Falkeborn wrote: > sun6i_dphy_ops and sun6i_dphy_regmap_config are not modified so make them > const structs to allow the compiler to put them in read-only memory. > > Before: > text data bss dec hex filename > 4407 1944 64 6415 190f drivers/phy/allwinner/phy-sun6i-mipi-dphy.o > > After: > text data bss dec hex filename > 4835 1496 64 6395 18fb drivers/phy/allwinner/phy-sun6i-mipi-dphy.o Applied, thanks
diff --git a/drivers/phy/allwinner/phy-sun6i-mipi-dphy.c b/drivers/phy/allwinner/phy-sun6i-mipi-dphy.c index 79c8af5c7c1d..1fa761ba6cbb 100644 --- a/drivers/phy/allwinner/phy-sun6i-mipi-dphy.c +++ b/drivers/phy/allwinner/phy-sun6i-mipi-dphy.c @@ -233,7 +233,7 @@ static int sun6i_dphy_exit(struct phy *phy) } -static struct phy_ops sun6i_dphy_ops = { +static const struct phy_ops sun6i_dphy_ops = { .configure = sun6i_dphy_configure, .power_on = sun6i_dphy_power_on, .power_off = sun6i_dphy_power_off, @@ -241,7 +241,7 @@ static struct phy_ops sun6i_dphy_ops = { .exit = sun6i_dphy_exit, }; -static struct regmap_config sun6i_dphy_regmap_config = { +static const struct regmap_config sun6i_dphy_regmap_config = { .reg_bits = 32, .val_bits = 32, .reg_stride = 4,
sun6i_dphy_ops and sun6i_dphy_regmap_config are not modified so make them const structs to allow the compiler to put them in read-only memory. Before: text data bss dec hex filename 4407 1944 64 6415 190f drivers/phy/allwinner/phy-sun6i-mipi-dphy.o After: text data bss dec hex filename 4835 1496 64 6395 18fb drivers/phy/allwinner/phy-sun6i-mipi-dphy.o Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com> --- drivers/phy/allwinner/phy-sun6i-mipi-dphy.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)