| Message ID | 20200630111047.1.I05d781ac794389337a4adc2f6402f673117e2937@changeid (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | regulator: mt6397: Implement of_map_mode regulator_desc function | expand |
On Tue, Jun 30, 2020 at 11:10:51AM +1000, Anand K Mistry wrote: > Without a of_map_mode implementation, the regulator-allowed-modes > devicetree field is skipped, and attempting to change the regulator mode > results in an error: > [ 1.439165] vpca15: mode operation not allowed The modes aren't documented in the binding document, any new device tree property needs to be added to the binding document. > +static unsigned int mt6397_map_mode(unsigned int mode) > +{ > + return mode == MT6397_BUCK_MODE_AUTO ? > + REGULATOR_MODE_NORMAL : REGULATOR_MODE_FAST; > +} > + Please write normal conditional statements to improve legibility, the ternery operator has uses but they're pretty specialist.
diff --git a/drivers/regulator/mt6397-regulator.c b/drivers/regulator/mt6397-regulator.c index 269c2a6028e8..5c60b52addf1 100644 --- a/drivers/regulator/mt6397-regulator.c +++ b/drivers/regulator/mt6397-regulator.c @@ -55,6 +55,7 @@ struct mt6397_regulator_info { .vsel_mask = vosel_mask, \ .enable_reg = enreg, \ .enable_mask = BIT(0), \ + .of_map_mode = mt6397_map_mode, \ }, \ .qi = BIT(13), \ .vselon_reg = voselon, \ @@ -146,6 +147,12 @@ static const unsigned int ldo_volt_table7[] = { 1300000, 1500000, 1800000, 2000000, 2500000, 2800000, 3000000, 3300000, }; +static unsigned int mt6397_map_mode(unsigned int mode) +{ + return mode == MT6397_BUCK_MODE_AUTO ? + REGULATOR_MODE_NORMAL : REGULATOR_MODE_FAST; +} + static int mt6397_regulator_set_mode(struct regulator_dev *rdev, unsigned int mode) {
Without a of_map_mode implementation, the regulator-allowed-modes devicetree field is skipped, and attempting to change the regulator mode results in an error: [ 1.439165] vpca15: mode operation not allowed Signed-off-by: Anand K Mistry <amistry@google.com> --- drivers/regulator/mt6397-regulator.c | 7 +++++++ 1 file changed, 7 insertions(+)