From patchwork Tue Jun 30 13:50:49 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11634041 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C6783912 for ; Tue, 30 Jun 2020 13:54:35 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9F12B20722 for ; Tue, 30 Jun 2020 13:54:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SGEschZX"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wlZk4sCJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9F12B20722 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HXxjVwzHUHZ0m4gq41h8eg9vcJ/y1yzxPiO2NmpvYJY=; b=SGEschZXPKwIM2IT8rqsqU7kR 5wvL+EzkatwouhoRqAHkKy/JdDiyqKfp2YCWym5OmW6YJY8kuuIcW9f0ABAsFKFSF7DBfGwi+/str uutoYnrIbq7XdKeIx3+1gL5/Dms82fPsJhC8Xf5PuAgGT1XJlFnJRXeOVc+WFsrmNgnFAPU8O+ByU uhidIoQk8BJg0FKH7vN6XpKPiZaApDBS2umHg435yVDvu+sfC5g90j+wbhuhNK2Q4UioBz8opWNUd 0GOqaf4YU6criKsYvIcP222TrGUfe2V5emDUUIlnIo0uOC5ZzhL9TW2TeL2VFbS1KBHWPq4q625LB cXEUPzX+A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGgb-0001cJ-ME; Tue, 30 Jun 2020 13:52:33 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGfU-0001Cx-Ox for linux-arm-kernel@lists.infradead.org; Tue, 30 Jun 2020 13:51:27 +0000 Received: by mail-wm1-x343.google.com with SMTP id a6so16013272wmm.0 for ; Tue, 30 Jun 2020 06:51:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lmSBURMhXlbXc5orPK26lnn3GrcbTsJzrTiKQM0CKuw=; b=wlZk4sCJ9LabE6MjBgDWfj+RAHJ7nlNR6gXF7qoifDB9OBorUV/WhRsFDUzsxdGC3k I+QATjMUHS6m99ukRPLizQEXD5V1Nd92XYCHMOAJ9mU+z6xf/ukS72a8n/il6//Ez6Ru DYrtSOwh4GkJBzr7ZcRIxMtyVSJqMuJ+wOZp6UVPd9rYzqnP3GOaSG829kAhJr3ZzxOX UvVnsVNZBiV6xsMa17D2OqtFmf/HMhxQVT/55iPrm7Ik4SZbMq5aTE6oyT8/gUW9F0av hnTOVhppnnQK7ZX27CXpmW5FWHS1RcJtiGxDSUZa64vF8C8mDDfFIcbmOMh7k955X53O hn6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lmSBURMhXlbXc5orPK26lnn3GrcbTsJzrTiKQM0CKuw=; b=sLvMZ32QErk9ou+KbPiiMsHGs9pYx1lb/sxJpeFz23xCeqokXUuxmMi4MMtC1ceiVV s+jHECVRC8xpmxgTSjaAvpl+cqQcKsA8W6t2gwZmHlzkPjrPpyruCCL712KkepF9AHfx SVGqIiJgmXYBPjQy28KZlsi6CJWJx27a976OY7KaUhUumJSVt3+IbiVjecTKF9UoA8Iy 5E+HQTsyaCjP/hjOcqGEyIKoU1HCDVu7R53Sqo87mc9p66WrA3F1OoStnO2qeKP13yud BFUMM5dJOJGcXptkzV2O1CKJIM3dkFqdMs85p3LezPYlo53QsByqu1uHJtD6mU4ETAB6 qNXA== X-Gm-Message-State: AOAM530sGdzp9VujTWwSCYSJtEYKmGwY4fizoGW1ljZmQyWgacfJzb13 m1fxDccpeinY+euY+Yncg+ps8w== X-Google-Smtp-Source: ABdhPJw756eqLhggdvniBrPLPyxPwbKeDc28oktY7T6iJ36sLKgK7neqmV89L3KWmAqnXuhPUzSPOA== X-Received: by 2002:a05:600c:21a:: with SMTP id 26mr17724220wmi.148.1593525083614; Tue, 30 Jun 2020 06:51:23 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id t4sm3876746wmf.4.2020.06.30.06.51.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:51:23 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 09/30] misc: mic: host: mic_x100: Move declaration of mic_x100_intr_init[] into c-file Date: Tue, 30 Jun 2020 14:50:49 +0100 Message-Id: <20200630135110.2236389-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630135110.2236389-1-lee.jones@linaro.org> References: <20200630135110.2236389-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:343 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ashutosh Dixit , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sudeep Dutt Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org mic_x100_intr_init[] is only ever used in mic_x100.c, so instead of listing to the compiler complain about unused static arrays simply move it into the c-file for direct consumption. This way it can stay 'static'. Fixes the following W=1 kernel build warning: In file included from drivers/misc/mic/host/mic_main.c:17: drivers/misc/mic/host/mic_x100.h:70:18: warning: ‘mic_x100_intr_init’ defined but not used [-Wunused-const-variable=] 70 | static const u16 mic_x100_intr_init[] = { | ^~~~~~~~~~~~~~~~~~ Cc: Sudeep Dutt Cc: Ashutosh Dixit Signed-off-by: Lee Jones --- drivers/misc/mic/host/mic_x100.c | 9 +++++++++ drivers/misc/mic/host/mic_x100.h | 9 --------- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/misc/mic/host/mic_x100.c b/drivers/misc/mic/host/mic_x100.c index d18cda9669121..843ce13750158 100644 --- a/drivers/misc/mic/host/mic_x100.c +++ b/drivers/misc/mic/host/mic_x100.c @@ -17,6 +17,15 @@ #include "mic_x100.h" #include "mic_smpt.h" +static const u16 mic_x100_intr_init[] = { + MIC_X100_DOORBELL_IDX_START, + MIC_X100_DMA_IDX_START, + MIC_X100_ERR_IDX_START, + MIC_X100_NUM_DOORBELL, + MIC_X100_NUM_DMA, + MIC_X100_NUM_ERR, +}; + /** * mic_x100_write_spad - write to the scratchpad register * @mdev: pointer to mic_device instance diff --git a/drivers/misc/mic/host/mic_x100.h b/drivers/misc/mic/host/mic_x100.h index 1f727a6f609c7..aebcaed6fa728 100644 --- a/drivers/misc/mic/host/mic_x100.h +++ b/drivers/misc/mic/host/mic_x100.h @@ -67,15 +67,6 @@ #define MIC_X100_FW_SIZE 5 #define MIC_X100_POSTCODE 0x242c -static const u16 mic_x100_intr_init[] = { - MIC_X100_DOORBELL_IDX_START, - MIC_X100_DMA_IDX_START, - MIC_X100_ERR_IDX_START, - MIC_X100_NUM_DOORBELL, - MIC_X100_NUM_DMA, - MIC_X100_NUM_ERR, -}; - /* Host->Card(bootstrap) Interrupt Vector */ #define MIC_X100_BSP_INTERRUPT_VECTOR 229