Message ID | 20200630135110.2236389-11-lee.jones@linaro.org (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <SRS0=CTHU=AL=lists.infradead.org=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@kernel.org> Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id BFE47912 for <patchwork-linux-arm@patchwork.kernel.org>; Tue, 30 Jun 2020 13:54:49 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 994B42074F for <patchwork-linux-arm@patchwork.kernel.org>; Tue, 30 Jun 2020 13:54:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EljwqrGh"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VkzyBtZb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 994B42074F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JOidiDZ+fPHfCIwM0clJF+GUACk8ExqtmENxjri/DuQ=; b=EljwqrGhz7+XXccbxa5Xhi2zl OLDTmetw33yljkuQ0D1wXzssfEm2Uq79vmnoMlpXZCGEuaKc/Pu5tD0jo1rasYHjp8izAO0dIB1Eq 1yImaw/ms/XfjttLi0MqF8NEEgdRkdFvISV365YWiVIMdp4Anve86COXPHYvsGvijMc8ouoNdYKuK n/iEFXUopDqz36wVFkf5eMQI/yRi4WGeZsTZJIZkq1TQZ08/eAAag/D6wiYNODj1OfpwhSA8kquMy MylLU9xhSWzWPGtWXPptjr5cNTrUoeAS02ZfFelKjLW9fMsVX5yA3vXDpPbEI5de7EH7IFAov94R7 r5AjX/AcQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGh7-0001sw-Fs; Tue, 30 Jun 2020 13:53:05 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGfV-0001Db-VH for linux-arm-kernel@lists.infradead.org; Tue, 30 Jun 2020 13:51:29 +0000 Received: by mail-wm1-x344.google.com with SMTP id f139so19674437wmf.5 for <linux-arm-kernel@lists.infradead.org>; Tue, 30 Jun 2020 06:51:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ekub7s2tFsF3z7X9QKVOCDCBJvabEEOsb/caCUw91kQ=; b=VkzyBtZbCjJJvhPGehZwLMGCthflX3/XiLaEsXmprAcJVpo80+gSoG8rwFsE+weyh4 ktuEsHJwHeeliHVIBqZbZHfxKTIhxooQjcRWF/IRKDYzwE0+BxanVd9NYSfhyIWiG53s tCxie/X8WcL0U9Vj/0ZNtTRsbOsvDazA5kboXlz+kHELQbXY/ZUAToaYVXd5H8spQ0Ou rwE4U1QYKcOnU7H3cbJIWJX1fKQ2wKeHi3V0r0eQQ4rkLM4VTLOYwWKNhDeT+4tOUam6 RIuizvWzQw2rQii5W+le77E6a2DZZCX6R8CQv+5LcI3fDCgBy3EW/p2Aahnk/Ui+KABm 1nyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ekub7s2tFsF3z7X9QKVOCDCBJvabEEOsb/caCUw91kQ=; b=qQmPcCgOsEYjFrabwfp2NwqfQNPmoLIYGVOLEIX6snuoeErucRCJ9xlv9a/l3SFSK1 CiGqYYqPgGK952+MozcQlwY6TmphKG5u++aSl6d/ST7/NrpePvTvIuK14mjKney1WuHz F5FKkwT8U/PAOCGj6e5xq5REdxpME7QGsNE4eX1TKIy4u5iqty9D5xiuVpY65nAbp1gc fea8Aqrd+S6e0ukv/HLc4FTWYsMhJ7nBV2dQl1t2BuChPZ7S4CdOGcXhTFmnsfL15bOw aa4KycZQcOfsVTy7Nf1iytvMWRhlQgd5i2Et+qbtd30TUFRLmfW3L4z7y5mEbv4QzBHt yrnQ== X-Gm-Message-State: AOAM530k4KQHesnutLdzvBUK5ShZRAlB8W2pmWm60e83EfgM2MAtJKUR PHjfUy8geqFKG4HvZ9TFLWGk2A== X-Google-Smtp-Source: ABdhPJzXnmpgLmFJj/trdGQhzlz4Fmuvb3Xl3DNNCpx4ncsMeB/kuKfjKKh6mqpcjRvSFV0zFJrmIA== X-Received: by 2002:a1c:1b90:: with SMTP id b138mr21474519wmb.21.1593525084780; Tue, 30 Jun 2020 06:51:24 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id t4sm3876746wmf.4.2020.06.30.06.51.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:51:24 -0700 (PDT) From: Lee Jones <lee.jones@linaro.org> To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 10/30] misc: ibmasm: dot_command: Demote function headers from kerneldoc Date: Tue, 30 Jun 2020 14:50:50 +0100 Message-Id: <20200630135110.2236389-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630135110.2236389-1-lee.jones@linaro.org> References: <20200630135110.2236389-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:344 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: <linux-arm-kernel.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/> List-Post: <mailto:linux-arm-kernel@lists.infradead.org> List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe> Cc: Lee Jones <lee.jones@linaro.org>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, =?utf-8?q?Max_Asb=C3=B6ck?= <amax@us.ibm.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org> Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org |
Series |
Last batch of patches to clean up Misc
|
expand
|
diff --git a/drivers/misc/ibmasm/dot_command.c b/drivers/misc/ibmasm/dot_command.c index 70273a4cb3527..df389bd4c9df7 100644 --- a/drivers/misc/ibmasm/dot_command.c +++ b/drivers/misc/ibmasm/dot_command.c @@ -10,7 +10,7 @@ #include "ibmasm.h" #include "dot_command.h" -/** +/* * Dispatch an incoming message to the specific handler for the message. * Called from interrupt context. */ @@ -48,7 +48,7 @@ void ibmasm_receive_message(struct service_processor *sp, void *message, int mes #define INIT_BUFFER_SIZE 32 -/** +/* * send the 4.3.5.10 dot command (driver VPD) to the service processor */ int ibmasm_send_driver_vpd(struct service_processor *sp) @@ -99,7 +99,7 @@ struct os_state_command { unsigned char data; }; -/** +/* * send the 4.3.6 dot command (os state) to the service processor * During driver init this function is called with os state "up". * This causes the service processor to start sending heartbeats the
The correct format is not used and no attempt has been made to document the function arguments. Makes sense to just demote the header back down to a simple comment. Fixes the following W=1 warnings: drivers/misc/ibmasm/dot_command.c:18: warning: Function parameter or member 'sp' not described in 'ibmasm_receive_message' drivers/misc/ibmasm/dot_command.c:18: warning: Function parameter or member 'message' not described in 'ibmasm_receive_message' drivers/misc/ibmasm/dot_command.c:18: warning: Function parameter or member 'message_size' not described in 'ibmasm_receive_message' drivers/misc/ibmasm/dot_command.c:55: warning: Function parameter or member 'sp' not described in 'ibmasm_send_driver_vpd' drivers/misc/ibmasm/dot_command.c:111: warning: Function parameter or member 'sp' not described in 'ibmasm_send_os_state' drivers/misc/ibmasm/dot_command.c:111: warning: Function parameter or member 'os_state' not described in 'ibmasm_send_os_state' Cc: "Max Asböck" <amax@us.ibm.com> Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/misc/ibmasm/dot_command.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)