From patchwork Tue Jun 30 13:50:51 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11634043 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3D80113B6 for ; Tue, 30 Jun 2020 13:54:46 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CD01D20722 for ; Tue, 30 Jun 2020 13:54:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="s851MbFi"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="RmUE4xRR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD01D20722 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5z6do9MSuaTXCcnicpXAAkYPtvwQ1sOlvTLCjTftM+A=; b=s851MbFi/lMSM6xwqnRnZRfUS s++LikihzKCu8XN4CMEfaL6hE/jqiOrkBETBZBaC5fEc//jjv2FAF8ENmit8JFiM8bFzK9NdBY9xX iZGYoh8J17eRkRnOFxf6LSEPahE+HCAHAMwkBO2nEJ2jSsvi3CjBB2itkadXhnjiqsZOSE59P865f k54W40e67QhxJoPmfsrzZANYaoIskVP8XKsMNA3FwGvlc04GF516YsD1GWpB9yLMybcS1/R2V+hFa H1J43JJEVk/DtWM3v6Yqje+IYyFQFlLraP0DfiAPeBu2Lut0EfkROsv6zsOA1EyLhBr+XrQzoafVk 36eWwQo8A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGh2-0001nZ-D8; Tue, 30 Jun 2020 13:53:00 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGfX-0001E3-2x for linux-arm-kernel@lists.infradead.org; Tue, 30 Jun 2020 13:51:29 +0000 Received: by mail-wr1-x442.google.com with SMTP id h5so20266584wrc.7 for ; Tue, 30 Jun 2020 06:51:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RJCjtk9nocbEbC4CT5qyevqfhFFyrky+2iu8F1RJDRM=; b=RmUE4xRRiwVsmYoHLqv4r8cSKHDYrBB658nvefHkaSclGp0eS91gB+SAjnzDGVUbpE kdr/4pBlbcXLjisWngtOtitsAZFIpCmfZaYhQEdP1rkjRpxU1wj1JnQcqawvmOp08ZIe JHNA4T0IV8DLKk3SXIU+0TtuyX/ExSs0VvHDP3FNG/f1VfGCOBoHEpDTTbZesPaUe08R I6jtzOgeQr+LSTwrI4W7JVNOsHCBXa/498wBwMdpZvkemTceOt7S8bL9ELpmUO1oE3Wu 0sm6241qSpfPTCe+1wBtH8+48VHMraGuS2IYB7cLSaF/SXRnX51aU0xsaTZBcfgRIRxI VeWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RJCjtk9nocbEbC4CT5qyevqfhFFyrky+2iu8F1RJDRM=; b=OTwCqyH6e47iP2tCiysNu5RTcRmV8Sf3nu4wSV4DE38V8pmam4ytPgz9Rpr30X8HL4 G/Z1sYOtw2QsH9girW7bZgIs7D7YNpCWW9TnTNo59PdomVhoqQ1h6O0JNbkIE4pRbmiA ebFoRngmnzZGbvAuL/rkJEGO+g095pcf8Xd/4iMqCFJ7YumRrSCLJPP8Yakh3w+EkqXk kSelEKXKwF8R9Rb/bcVlmtysqkl+hIZ+3Y+1xDI0HhWAolZRwaD4WRRdeTx4b7ucEQVn rnV5YmlcRaABcPVzLbVqaWrpgazdQTR2S1IcKyVzFoS9hmRRkuDHTNIRa3SoCK/luhou gV4w== X-Gm-Message-State: AOAM533bj27aiZIUbrALS1yFm1fqK9Aly370PqyAEMPh1ZZ6hJQQVK4m zCM8Vu4vPe1WEA9WGMLFd/FZqA== X-Google-Smtp-Source: ABdhPJx2kkPJCP6s7Z7K+iQmwN4Qs9Wxn6yYUEBx+rYFR+LhJUUCrVnVwUsObMJQldJQDD2uO1u9wg== X-Received: by 2002:a5d:60d0:: with SMTP id x16mr22596798wrt.5.1593525085786; Tue, 30 Jun 2020 06:51:25 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id t4sm3876746wmf.4.2020.06.30.06.51.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:51:25 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 11/30] misc: mic: host: mic_intr: Properly document function arguments Date: Tue, 30 Jun 2020 14:50:51 +0100 Message-Id: <20200630135110.2236389-12-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630135110.2236389-1-lee.jones@linaro.org> References: <20200630135110.2236389-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:442 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ashutosh Dixit , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sudeep Dutt Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org mic_interrupt() and mic_setup_msix() have incomplete documentation. Fixes the following W=1 kernel build warnings: drivers/misc/mic/host/mic_intr.c:42: warning: Function parameter or member 'irq' not described in 'mic_interrupt' drivers/misc/mic/host/mic_intr.c:42: warning: Function parameter or member 'dev' not described in 'mic_interrupt' drivers/misc/mic/host/mic_intr.c:188: warning: Function parameter or member 'pdev' not described in 'mic_setup_msix' Cc: Sudeep Dutt Cc: Ashutosh Dixit Signed-off-by: Lee Jones --- drivers/misc/mic/host/mic_intr.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/misc/mic/host/mic_intr.c b/drivers/misc/mic/host/mic_intr.c index 433d35dc17216..85b3221b5d407 100644 --- a/drivers/misc/mic/host/mic_intr.c +++ b/drivers/misc/mic/host/mic_intr.c @@ -37,6 +37,8 @@ static irqreturn_t mic_thread_fn(int irq, void *dev) /** * mic_interrupt - Generic interrupt handler for * MSI and INTx based interrupts. + * @irq: interrupt to handle (unused) + * @dev: pointer to the mic_device instance */ static irqreturn_t mic_interrupt(int irq, void *dev) { @@ -180,7 +182,7 @@ static u8 mic_unregister_intr_callback(struct mic_device *mdev, u32 idx) * mic_setup_msix - Initializes MSIx interrupts. * * @mdev: pointer to mic_device instance - * + * @pdev: PCI device structure * * RETURNS: An appropriate -ERRNO error value on error, or zero for success. */