From patchwork Tue Jun 30 13:50:53 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11634049 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CB6F7912 for ; Tue, 30 Jun 2020 13:55:07 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9DED620722 for ; Tue, 30 Jun 2020 13:55:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="roPz0NLy"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="l0ql2sn5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9DED620722 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XD0gN6GC/ihPaF8uoXKd+LSzx8x6uygOO7vn7ejs/aU=; b=roPz0NLyGjd+FqEEdvkXINw+9 1icJogigVUQpdSsrxyEnj/VSvFYd1Goku6xgxt3ce/zmS5uyw4YD5pMC6a57xqChiY0ekUUYWJM0D hEvUAMekx/2cW88of7FCBbpjAS1XiPt25lCQex0vI9HisUZzraj0kNdW+oFko9Kh6jVyuu0MCpvO9 8zocLAxIj5/PQjdkchE5aonblY2OYDE4f5CrPmpbCBMnRrntSAfmfItWcgGyMdMNQWpoc/LVXwzYG 2dvO/aomNNP/H3YqLsfsEm1kPr1aA61rbLAXs47/J72pBZTyf4wHpRs4mS0W2giTKnZDqHQ1o3qAv RQdRrcvmg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGhI-00022J-Mb; Tue, 30 Jun 2020 13:53:16 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGfZ-0001EW-CY for linux-arm-kernel@lists.infradead.org; Tue, 30 Jun 2020 13:51:30 +0000 Received: by mail-wr1-x441.google.com with SMTP id k6so20291528wrn.3 for ; Tue, 30 Jun 2020 06:51:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3Rr7wa1veduLhh9ZAr39E4g8k4FtFNV6OceNUbS0RKk=; b=l0ql2sn5FiL9hzSkQ+yI7cAzJkka4RsC7ibUvZkRg88BN0zPoJVj2CCmPhRVJEhMTZ ZvqLmbJcCy3t1cMqYZjp5vBNBLBLZAL6f+qmWr/k4xb5m2BwaOqi3jrX9vQ8JIBumN60 Sj/oB1X6FT9XUFRqZGk3DUe003hWauUxsyLPQqaAx+R3E8GWf28kU5e8iOq2QuiUeNu1 N35lUJPUUNmq+fYpMdZsUEhZ1SJUgI8i3+FL3Xit6O96cnfeTh9+/o4CNMxkpSGfcKs6 xexXuKA6fhyFqlmlsLD+5QaIs7CrHlxjcrLfgIQMJrafOsQ5vIAzkkEtDcRDyNXHpyT8 w4cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3Rr7wa1veduLhh9ZAr39E4g8k4FtFNV6OceNUbS0RKk=; b=DW+jN3s4hVHSbW7Abu45yakMFKtV+jwpNXvoPRmHI3Lv6Eck72UnDU+ZMvxyYPodWf xG710EWgEQJm85KKOZDtUIKuQN3VvP4+Sqj7tVOEGViT8HpkaK6577/hKkiU2QOYGEbU q+lxC+prvWiVO7UPgOaElGAtolZbioeT8OTn+ncjlQRzhCMvF+5iexyE3plEMnvGQuIq TNA1KYH1D9fI58+fspHEviqfC002ijylEJ85suJlDQkTyRsIOW3BXL1z6OyXb9LAY29d nNdZR02t5BpIGogkfDDznvStqGVKpc+dwHoSGYzM3OiFoD71i9qo5pizYZDsYJI+zg4g O/iA== X-Gm-Message-State: AOAM532u8NDrz61pGjBCQfCfSbRH84sH4Hw9pzwchNd614S3vks05p0R 1VkJmVlCjfJQgLtMuV+eSSVEMQ== X-Google-Smtp-Source: ABdhPJx7RZSCG6MhccQsVv6Y1Q3D48aKEAlqzGQWs/ITBqKeYmpx867Pcfq0L5FYO9K0o9jZk5hI7Q== X-Received: by 2002:a5d:40cb:: with SMTP id b11mr22580348wrq.263.1593525088326; Tue, 30 Jun 2020 06:51:28 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id t4sm3876746wmf.4.2020.06.30.06.51.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:51:27 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 13/30] misc: mic: card: mic_debugfs: Demote function headers from kerneldoc Date: Tue, 30 Jun 2020 14:50:53 +0100 Message-Id: <20200630135110.2236389-14-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630135110.2236389-1-lee.jones@linaro.org> References: <20200630135110.2236389-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:441 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ashutosh Dixit , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sudeep Dutt Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org The correct format is not used and no attempt has been made to document the function arguments. Makes sense to just demote the headers back down to simple comments. Fixes the following W=1 warnings: drivers/misc/mic/card/mic_debugfs.c:31: warning: Function parameter or member 's' not described in 'mic_intr_show' drivers/misc/mic/card/mic_debugfs.c:31: warning: Function parameter or member 'unused' not described in 'mic_intr_show' drivers/misc/mic/card/mic_debugfs.c:53: warning: Function parameter or member 'mdrv' not described in 'mic_create_card_debug_dir' drivers/misc/mic/card/mic_debugfs.c:67: warning: Function parameter or member 'mdrv' not described in 'mic_delete_card_debug_dir' Cc: Sudeep Dutt Cc: Ashutosh Dixit Signed-off-by: Lee Jones --- drivers/misc/mic/card/mic_debugfs.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/misc/mic/card/mic_debugfs.c b/drivers/misc/mic/card/mic_debugfs.c index b58608829b180..4c326e8f4d993 100644 --- a/drivers/misc/mic/card/mic_debugfs.c +++ b/drivers/misc/mic/card/mic_debugfs.c @@ -24,7 +24,7 @@ /* Debugfs parent dir */ static struct dentry *mic_dbg; -/** +/* * mic_intr_show - Send interrupts to host. */ static int mic_intr_show(struct seq_file *s, void *unused) @@ -46,7 +46,7 @@ static int mic_intr_show(struct seq_file *s, void *unused) DEFINE_SHOW_ATTRIBUTE(mic_intr); -/** +/* * mic_create_card_debug_dir - Initialize MIC debugfs entries. */ void __init mic_create_card_debug_dir(struct mic_driver *mdrv) @@ -60,7 +60,7 @@ void __init mic_create_card_debug_dir(struct mic_driver *mdrv) &mic_intr_fops); } -/** +/* * mic_delete_card_debug_dir - Uninitialize MIC debugfs entries. */ void mic_delete_card_debug_dir(struct mic_driver *mdrv) @@ -68,7 +68,7 @@ void mic_delete_card_debug_dir(struct mic_driver *mdrv) debugfs_remove_recursive(mdrv->dbg_dir); } -/** +/* * mic_init_card_debugfs - Initialize global debugfs entry. */ void __init mic_init_card_debugfs(void) @@ -76,7 +76,7 @@ void __init mic_init_card_debugfs(void) mic_dbg = debugfs_create_dir(KBUILD_MODNAME, NULL); } -/** +/* * mic_exit_card_debugfs - Uninitialize global debugfs entry */ void mic_exit_card_debugfs(void)