Message ID | 20200630135110.2236389-15-lee.jones@linaro.org (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <SRS0=CTHU=AL=lists.infradead.org=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@kernel.org> Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 33DC9912 for <patchwork-linux-arm@patchwork.kernel.org>; Tue, 30 Jun 2020 13:55:24 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0D05520722 for <patchwork-linux-arm@patchwork.kernel.org>; Tue, 30 Jun 2020 13:55:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="2PlJSPs8"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qDMd25o0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0D05520722 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=CGlOV7ed3LLs1MpiSMY4ph4n1PGymUA0hoVNtEHdCVc=; b=2PlJSPs8oen9emXuh1s0lhfy2 IG2hhwNltfHfYZIQR0qpC8WjU/uT9woKcbagqcxoDTvjRPFiAvciIukcVq45rs2i0UJdnKfh94KbW KsOoqozLGHYqDH6pLgjTrxFdavV9UQA8zZubWbMqH+qd1dY60bPNdng/Rrr12vySqlO5B4evgX0Av bXob/cj5g8SUIKhV4DMH6unC/pakCMM6xWawB+2xN+gBWSnRukrtAGBObTQJjU1gcWhPPWOZdGz3f hdfACUjJ5z3qXCb6ASyzButrVZ7y4E2GLIBVNluPbvwBtBFXPPKR4sRobhXb01tKSKyPX4gCyf57R 7D7b6V3Rg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGha-0002E8-La; Tue, 30 Jun 2020 13:53:34 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGfa-0001Ex-L4 for linux-arm-kernel@lists.infradead.org; Tue, 30 Jun 2020 13:51:32 +0000 Received: by mail-wr1-x444.google.com with SMTP id s10so20236309wrw.12 for <linux-arm-kernel@lists.infradead.org>; Tue, 30 Jun 2020 06:51:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qqN6XxuBV4Jc4c7/xcuhasc+YhoMkS+syDgxfhyrVnI=; b=qDMd25o04PnMrI7s5/XLbUKoJJaCs5QElcqGQC8Ps8VWTX5SlIPD7ntW4ahpr3/mv+ xsRPeqJb51zpw6iUma6WOquB3Z3GX+eD1Drx+fID9HNPEiGiXt9ATD2SiirAeqDpXYTW V+WDzYlfBStA7UnKW8JXWUzQwlxdkaqvONzpzQpz52QlwpfeCF051bjArWwerpLIN2hP vQdq92UzPHPJYLL58KgKipIQdJXZ2Y1Ytz9Cz3nZzY9Rsmg61xI1urRdKyCcipKQ1Zjk DLeNOcZVV9uFyOWckmjAQSaELmCkOH9gUPYhfNqw92wm1SRXgj5Xr74P/FyBj+mPsET+ y8pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qqN6XxuBV4Jc4c7/xcuhasc+YhoMkS+syDgxfhyrVnI=; b=SwyaTcJ+sB9MAoyIfbRY7sXlhc8HyOWyxbMBp8b/dkdZJ6bUjGtzhvIe4QMhklTttC 8UQPw2Ozo1jf+Y1cspgZr/zjBD5dsMMzpVfjExieRLydbhTMeUJx8RZTBN0rvLc33CNc ly7f00Cy3VMEcQeW1620GGf6wbuLdzkPHClG0VX5pHFk6buONzx7pSLtMqaladUDNxM9 Jk7DjmOLpDFTqG9KZg9QPC7J57X8Tp4uaJvJk0/Yb2rCjC7PQ4PVGtz9CzTyiufUBCvy F7nbu2eUatFWY5q0nR2U6fl5ATCzD3qKopvzZkY8ZAP9qgn1DPk0Md2Buv9/Qs2PxWhk 3HGA== X-Gm-Message-State: AOAM533BwEhTljXDrEX7QwyVt/CuKtZeQxWqX16gbLN0E7wC8dxiUPFs oBIAWarpuOveHorrnllJsKIHJmbHYlA= X-Google-Smtp-Source: ABdhPJxBCPH1g9KzdqS9IQ654MY2nJGCfEf2EBKfgxw48PUsFnr727YH5gZI9bH2YoaczlXd24j1uQ== X-Received: by 2002:adf:db4d:: with SMTP id f13mr21659776wrj.336.1593525089539; Tue, 30 Jun 2020 06:51:29 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id t4sm3876746wmf.4.2020.06.30.06.51.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:51:28 -0700 (PDT) From: Lee Jones <lee.jones@linaro.org> To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 14/30] misc: mic: host: mic_debugfs: Demote function headers from kerneldoc Date: Tue, 30 Jun 2020 14:50:54 +0100 Message-Id: <20200630135110.2236389-15-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630135110.2236389-1-lee.jones@linaro.org> References: <20200630135110.2236389-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:444 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: <linux-arm-kernel.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/> List-Post: <mailto:linux-arm-kernel@lists.infradead.org> List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe> Cc: Ashutosh Dixit <ashutosh.dixit@intel.com>, Lee Jones <lee.jones@linaro.org>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sudeep Dutt <sudeep.dutt@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org> Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org |
Series |
Last batch of patches to clean up Misc
|
expand
|
diff --git a/drivers/misc/mic/host/mic_debugfs.c b/drivers/misc/mic/host/mic_debugfs.c index ab0db7a2ac8c2..ffda740e20d56 100644 --- a/drivers/misc/mic/host/mic_debugfs.c +++ b/drivers/misc/mic/host/mic_debugfs.c @@ -101,7 +101,7 @@ static int mic_msi_irq_info_show(struct seq_file *s, void *pos) DEFINE_SHOW_ATTRIBUTE(mic_msi_irq_info); -/** +/* * mic_create_debug_dir - Initialize MIC debugfs entries. */ void mic_create_debug_dir(struct mic_device *mdev) @@ -124,7 +124,7 @@ void mic_create_debug_dir(struct mic_device *mdev) &mic_msi_irq_info_fops); } -/** +/* * mic_delete_debug_dir - Uninitialize MIC debugfs entries. */ void mic_delete_debug_dir(struct mic_device *mdev) @@ -132,7 +132,7 @@ void mic_delete_debug_dir(struct mic_device *mdev) debugfs_remove_recursive(mdev->dbg_dir); } -/** +/* * mic_init_debugfs - Initialize global debugfs entry. */ void __init mic_init_debugfs(void) @@ -140,7 +140,7 @@ void __init mic_init_debugfs(void) mic_dbg = debugfs_create_dir(KBUILD_MODNAME, NULL); } -/** +/* * mic_exit_debugfs - Uninitialize global debugfs entry */ void mic_exit_debugfs(void)
The correct format is not used and no attempt has been made to document the function arguments. Makes sense to just demote the headers back down to simple comments. Fixes the following W=1 warnings: drivers/misc/mic/host/mic_debugfs.c:108: warning: Function parameter or member 'mdev' not described in 'mic_create_debug_dir' drivers/misc/mic/host/mic_debugfs.c:131: warning: Function parameter or member 'mdev' not described in 'mic_delete_debug_dir' Cc: Sudeep Dutt <sudeep.dutt@intel.com> Cc: Ashutosh Dixit <ashutosh.dixit@intel.com> Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/misc/mic/host/mic_debugfs.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)