From patchwork Tue Jun 30 13:50:56 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11634057 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id AE9CA912 for ; Tue, 30 Jun 2020 13:55:49 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8827D20780 for ; Tue, 30 Jun 2020 13:55:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="IRGOYV2i"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="YTFr/Jhv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8827D20780 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=CzssIczj2aWPEA9XPPHGdVV0+TN8TeXcGxZjyExO2YU=; b=IRGOYV2iE5w7TjAZPmp35cUDu bb1I2us7W1n4VZvO0tY0YzxPgsYs3b3wtZlu8dgKGH3tg+0x9g7mlm9GHgT1OJCLl3oSFvlgPfWzk Vuxf6bITXaPHV2zvhwaNed4YIJAoRIQLIjTFG3VzYHu0KYFosPR6iBmHtvldwPMp48N2QFIislGpx Bi5kQiqPqmgGB6cB+hOHRWrYOwSpNihyxU3W/fZrDx7FxpS2Qv1FAj3Ig9UHNakKwlXI0yn1oN9Mv Ga1Bjy2jCqqUSn/PCEUNnwA4ojgpIoV9DzLswo2OlyVI9/tRmQ4IkVFP2ZbbKHvxBo+fYlFGP3D8U FzpFiv0ag==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGhu-0002TV-J8; Tue, 30 Jun 2020 13:53:54 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGfc-0001FU-Cf for linux-arm-kernel@lists.infradead.org; Tue, 30 Jun 2020 13:51:34 +0000 Received: by mail-wr1-x444.google.com with SMTP id r12so20215886wrj.13 for ; Tue, 30 Jun 2020 06:51:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Wk9/DzLGRf8KDCzfvt/GOgByrJsxT/fIOxcZPlWq/CY=; b=YTFr/Jhv0IxMRjGJfO5vfcAWzDDEhJZD1S9kEdXHCGlHd/6sUL1vsEErzCACCcBSFZ u9zv/VeGKVgLS7CL/GgMyWr+1k2OoHi3Qi/KMvnIfmHQY11q3i/qb/Ya2PfwKSxM0MvQ 7MET2nVm3HQiCnM1TKCWe4be8nmhxtDblN53F96eJHD4KUFAszWEBwfOFiBDyFH83Rpm BwbKrOCzmPjfD0ZcjdF8HnYbO5GQWMBJVexLMX+zq3SrVUPZPEIXRjFVQW/Djc8XleSB kVaBGlxwFPf+nsWc+In+cyqgu62pjiTY2num8107Z0kEYZ4UGRhZEnG3z4xKrocL0IpZ xhlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Wk9/DzLGRf8KDCzfvt/GOgByrJsxT/fIOxcZPlWq/CY=; b=ErQ1qBiejakfW1tOetoVNKYKNHsHcJxQMfo9rOWOAhmjO1DZjAG1KhJY6Ewepo0vvJ 3GnBf5Szc13W1zsvTXdpvqjfVgHjuGjJ+LeEaHlKa1XjHjrwbB1xkOTMhr8X4CPBsO6b MqfnUXHt6C5a954WbDYBasicyg7/sJRLCZMfZ9bpM9FMdEaO5I/tVftvUNvO2E/6JbLz uZFnvSrsyyDYEpxKnp5WUqfoUHVevvxxrQnV0Z+ikALkGx92751c6LJWJGTD4H86SX4L pVolcMGXW71d+coaBylSwX+wv3xrJiRDVfe3MTxJS6cZISpxeSOrDCqfKhUAlNXuU+Wb VaRg== X-Gm-Message-State: AOAM533IzKJj7WaW3wKmhirF2hAhT8dSNEM0FsNO3WIqLVYKmNlWM7hQ ge3nMpYEe6eyDisa5kRPd4jUbsqmvAE= X-Google-Smtp-Source: ABdhPJy+tsRYfnowp6Jy74IXc5vBXoUVMYXIcAJJ6qCYOHFM4FMkD6FU1i2uxa+KqN5jXoQvqqo3FQ== X-Received: by 2002:a05:6000:128c:: with SMTP id f12mr22618875wrx.67.1593525091335; Tue, 30 Jun 2020 06:51:31 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id t4sm3876746wmf.4.2020.06.30.06.51.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:51:30 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 16/30] misc: mic: scif: scif_ports: Fix copy 'n' paste error Date: Tue, 30 Jun 2020 14:50:56 +0100 Message-Id: <20200630135110.2236389-17-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630135110.2236389-1-lee.jones@linaro.org> References: <20200630135110.2236389-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:444 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org __scif_get_port() has never taken 'port' as an argument since its inception back in 2015. Probably document the proper arguments expected 'start' and 'end'. Fixes the following W=1 kernel build warnings: drivers/misc/mic/scif/scif_ports.c:36: warning: Function parameter or member 'start' not described in '__scif_get_port drivers/misc/mic/scif/scif_ports.c:36: warning: Function parameter or member 'end' not described in '__scif_get_port' drivers/misc/mic/scif/scif_ports.c:36: warning: Excess function parameter 'port' description in '__scif_get_port' Signed-off-by: Lee Jones --- drivers/misc/mic/scif/scif_ports.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/misc/mic/scif/scif_ports.c b/drivers/misc/mic/scif/scif_ports.c index 547a71285069a..4bdb5ef9a1399 100644 --- a/drivers/misc/mic/scif/scif_ports.c +++ b/drivers/misc/mic/scif/scif_ports.c @@ -14,11 +14,11 @@ struct idr scif_ports; -/* +/** * struct scif_port - SCIF port information * - * @ref_cnt - Reference count since there can be multiple endpoints - * created via scif_accept(..) simultaneously using a port. + * @ref_cnt: Reference count since there can be multiple endpoints + * created via scif_accept(..) simultaneously using a port. */ struct scif_port { int ref_cnt; @@ -27,7 +27,8 @@ struct scif_port { /** * __scif_get_port - Reserve a specified port # for SCIF and add it * to the global list. - * @port : port # to be reserved. + * @start: lowest port # to be reserved (inclusive). + * @end: highest port # to be reserved (exclusive). * * @return : Allocated SCIF port #, or -ENOSPC if port unavailable. * On memory allocation failure, returns -ENOMEM.