From patchwork Tue Jun 30 13:50:57 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11634059 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 303D1912 for ; Tue, 30 Jun 2020 13:56:08 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 087C120774 for ; Tue, 30 Jun 2020 13:56:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mosSv/dI"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BuGM2xep" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 087C120774 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dS+nQX+JvB0enYXuzLKIQPpHBoc8lPt9iYeCFK+CQIE=; b=mosSv/dIccfZsP1utMY2fVyQ0 4585E+xkuobEgtRO193Wyhk0VDZEzxfdlNR4xCBxgD865wHzUMvqLhNISoEyrEscWwYEE6qN6AoQL YyIazfZH9sAxT3dnjnuLfevewyftJg477KoIABB3P7s/3TdZTb4eTpbuW2S/Updmr1CEYt5249BYD MJRgAU+WK/Jom268oP4HfBLtCH+kI6pvHYI3CZ06b3N9FdK8ZTyA3Fp5MyBTkFa5tc5jtq6tzbVnD 2JFmKkFDWg+45VYk3DjnTEw0tdjjRx+LlZbU9Ldvh/lZ1HR4mb2iUDaCoYEYdgUd69EL8F8M7x0AZ Pc/p6zlCw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGi8-0002eN-24; Tue, 30 Jun 2020 13:54:08 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGfd-0001Fl-KA for linux-arm-kernel@lists.infradead.org; Tue, 30 Jun 2020 13:51:35 +0000 Received: by mail-wr1-x441.google.com with SMTP id b6so20246570wrs.11 for ; Tue, 30 Jun 2020 06:51:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GHtif/VrKAdzD8tANDBuK+rW4l81OqvLbxPsir5m1XU=; b=BuGM2xep6RhwyJLaKYzA1LY0lnzmDeGISBQyDgjvCCdB4uSlbOdhNjGAIySKO9kXcw EH5QjQGaJnt54u7lAG8VzxejktsK+98Wo5238OHW0RywWUP5rBq2uyhK/qSQHmIwsBg2 jrEMTHQ5+VsIcWGiCUsmbojJN34+WqZ9qjPytbo4FwL2egqnP/No/6NFT6lmqv0+yiwS Qpv4gaucJzpQNMNKa/p+tsrpe8i84+0GV1LqzrHqVpfwVDLzCjesyVU7P8PECRQpmdM3 UkLtQ42eRaVhx+y7ydAuqsU/5zQa3TrZiLpMyY3/0iiOwVnw8XocpSuHG5POF1wpRtJ2 rxtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GHtif/VrKAdzD8tANDBuK+rW4l81OqvLbxPsir5m1XU=; b=n3RN7trm5EKjSWnOtamvSMNsMnXkpo83d6Ldlkvh2YdoXwf9lbBN5BJJgTbhB/yOJB cREADq8Btbr8OLTxxf7pLQL2nDGFURhOBYxu33f3iIF26K6lI7qDgv5dh2QzTJhzxDaP uumwIde+Qla07ZRDR8JXsMWNvHpW6Eq9/Qo1SBgUIb5c524R/CNZl7JgjJ1u39eAvv7v R8hRUiM5SIi36QyuI4fHvEZlzX624GK8ikH6JfWvPftgZlbXdgnQtPYy/Xc0c8RT98cB xu3D50RGpr2rjNlagy3v6jS0aboSNvVFzmmlX/rcw1EiOX2F2YtHEB25Iz1mlDjR4Q+9 K/tw== X-Gm-Message-State: AOAM533/NdIz3nzTseXVhq/zm3UjhVjBL4IvVhu9O2bkU2Y7SXWwwUm7 uefc0CSTIq2Lrll/HBMQUg28YQ== X-Google-Smtp-Source: ABdhPJwW+1Hk4BGrbmmXevBy2713hmUjyPmxt1lmCevbhbcXJYipCFBTuWS3WioQoS/mcYj09qQiXw== X-Received: by 2002:a5d:56d0:: with SMTP id m16mr21150324wrw.194.1593525092319; Tue, 30 Jun 2020 06:51:32 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id t4sm3876746wmf.4.2020.06.30.06.51.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:51:31 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 17/30] misc: mic: cosm: cosm_debugfs: Demote function headers from kerneldoc Date: Tue, 30 Jun 2020 14:50:57 +0100 Message-Id: <20200630135110.2236389-18-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630135110.2236389-1-lee.jones@linaro.org> References: <20200630135110.2236389-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:441 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org The correct format is not used and no attempt has been made to document the function arguments. Makes sense to just demote the header back down to a simple comment. Fixes the following W=1 warnings: drivers/misc/mic/cosm/cosm_debugfs.c:25: warning: Function parameter or member 's' not described in 'log_buf_show' drivers/misc/mic/cosm/cosm_debugfs.c:25: warning: Function parameter or member 'unused' not described in 'log_buf_show' drivers/misc/mic/cosm/cosm_debugfs.c:78: warning: Function parameter or member 's' not described in 'force_reset_show' drivers/misc/mic/cosm/cosm_debugfs.c:78: warning: Function parameter or member 'pos' not described in 'force_reset_show' Signed-off-by: Lee Jones --- drivers/misc/mic/cosm/cosm_debugfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/misc/mic/cosm/cosm_debugfs.c b/drivers/misc/mic/cosm/cosm_debugfs.c index 68a731fd86dee..cb55653cf1f92 100644 --- a/drivers/misc/mic/cosm/cosm_debugfs.c +++ b/drivers/misc/mic/cosm/cosm_debugfs.c @@ -15,7 +15,7 @@ /* Debugfs parent dir */ static struct dentry *cosm_dbg; -/** +/* * log_buf_show - Display MIC kernel log buffer * * log_buf addr/len is read from System.map by user space @@ -68,7 +68,7 @@ static int log_buf_show(struct seq_file *s, void *unused) DEFINE_SHOW_ATTRIBUTE(log_buf); -/** +/* * force_reset_show - Force MIC reset * * Invokes the force_reset COSM bus op instead of the standard reset