From patchwork Tue Jun 30 13:50:59 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11634061 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 07F6414B7 for ; Tue, 30 Jun 2020 13:56:30 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D141920774 for ; Tue, 30 Jun 2020 13:56:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="g9ELlurW"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ze4B74SN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D141920774 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KUrWZuxAAeyrMhYvAvFepvE7h1NvkQ+FPDuyn3ltDic=; b=g9ELlurWVHszSUcnj0ewolBmG c5zkm5xSFKGrPEwhuaKAtAH18f8L5CBvmGh6qt1hASUA354CbxQllybakKa/RZcH1WDrGqudGmgHk AHYUoIe8etjVHY3ehNNetym1rrrp6oMp5TwD4oiJahzkSykyzc7ewDMffzuC8eipG5M3H1e2ql6yO LPvQrgMzujl55Vx+ypS+zzPx7/r4ypSErjaE4yZ9zBxSbvjki0IP1XwX2bF1zQJybOYbjedeeDGbb rBlhMrc8mQgPnr07eKlOc74OypHRRuPYjcnMja+2lcwnpsu2qHhk9VnDv+Z8eEuA5dOl2a/JFV+6Z 5KQoZ2GkQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGiY-00030z-Tk; Tue, 30 Jun 2020 13:54:34 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGff-0001GK-Km for linux-arm-kernel@lists.infradead.org; Tue, 30 Jun 2020 13:51:37 +0000 Received: by mail-wm1-x342.google.com with SMTP id w3so7223694wmi.4 for ; Tue, 30 Jun 2020 06:51:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DZzcRr+il6B7Wb5szs9514Q011nYXDt2b1eWYEXToMg=; b=ze4B74SNFERaaTVJaC+Vyy9gFPkffpaYoHDqnKPXapQkMmFkERaQqn16iIHhsHRn+G yJu7CcRD2h2URZMaPCPR4lxNq6wl9EhGCCPQoqSHF+jo60WsQChbaXzZvumAd4yR4FXN CZ9cix2D3iP96P1e3KDEkwHSBE+39b9H6hxax52ooGJh0ZYOc+OzfcGV7nuplasxTM5S IYiud7p8VTP9R9nV8ujiG6tWdWaRWs911QiZycDK6vvTcZb2/w7GAxUU7ZXRHILGxfTQ HrgIagryeAIhS/lDTaOIwM89w4a1G+c8uWzTWOv2Fpvayb4MasWtClkqd4jQ9qgWy//G sNcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DZzcRr+il6B7Wb5szs9514Q011nYXDt2b1eWYEXToMg=; b=lHfJ1DEuPsHVsPdHRmB/irMcE7bFRN87eKh9YxGb84FD/4HPhhD27k54xJQJkdomFj qscVfWJ4o7wgJNuuPYzLFXPcDIaPS2M7T1Vs+a7q6Qp2EGRrpjQgCZgyY0rpTsacQ0E6 vhngVDJg1X5CWW6AVtYnmk3ct57RcFaj+Nka5f6aLvtJY3Cpxcp+CxPaSjvPZ79+TeeB juC1COYUcS0jvWPBzgJA0KCJvWMwQkz7PGNJPwda8dCQUhHTJVH3D/739dBhbKjfaUbW mXDL7BIO7/gCIYaA6d2FML+om5+wvTbZc78vhKUCw11EmNXFxYrqCuLe/MRgl79disyJ Z/uQ== X-Gm-Message-State: AOAM530yXWGVy7ohls5VROwO3oGJ3x6IXjst1eXpw3AQPAJcLp6NzWjM ya4fmpk2S6wAiy7cVo2sW6n/rg== X-Google-Smtp-Source: ABdhPJxyqQHdVZGRJovPYRIq+ziAdoNs4/aOWvvPnANoKN6II3dppM9ZNMFHnOC3zBh8CS1Nwt2Upw== X-Received: by 2002:a1c:e209:: with SMTP id z9mr21892593wmg.153.1593525094264; Tue, 30 Jun 2020 06:51:34 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id t4sm3876746wmf.4.2020.06.30.06.51.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:51:33 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 19/30] misc: mic: scif: scif_api: Demote scif_accept() function header Date: Tue, 30 Jun 2020 14:50:59 +0100 Message-Id: <20200630135110.2236389-20-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630135110.2236389-1-lee.jones@linaro.org> References: <20200630135110.2236389-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:342 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org The correct format is not used and no attempt has been made to document the function arguments. Makes sense to just demote the header back down to a simple comment. Fixes the following W=1 warnings: drivers/misc/mic/scif/scif_api.c:739: warning: Function parameter or member 'epd' not described in 'scif_accept' drivers/misc/mic/scif/scif_api.c:739: warning: Function parameter or member 'peer' not described in 'scif_accept' drivers/misc/mic/scif/scif_api.c:739: warning: Function parameter or member 'newepd' not described in 'scif_accept' drivers/misc/mic/scif/scif_api.c:739: warning: Function parameter or member 'flags' not described in 'scif_accept' Signed-off-by: Lee Jones --- drivers/misc/mic/scif/scif_api.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/mic/scif/scif_api.c b/drivers/misc/mic/scif/scif_api.c index d7faffdd87e92..9cc6b2a6cf229 100644 --- a/drivers/misc/mic/scif/scif_api.c +++ b/drivers/misc/mic/scif/scif_api.c @@ -713,7 +713,7 @@ int scif_connect(scif_epd_t epd, struct scif_port_id *dst) } EXPORT_SYMBOL_GPL(scif_connect); -/** +/* * scif_accept() - Accept a connection request from the remote node * * The function accepts a connection request from the remote node. Successful