From patchwork Tue Jun 30 13:51:00 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11634065 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8A4EB912 for ; Tue, 30 Jun 2020 13:57:37 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2C72E20780 for ; Tue, 30 Jun 2020 13:57:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nQUT4smf"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="NyAGhIIq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2C72E20780 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FmxgZASy1xmssmKQqti3SO7sRdMdC4f6QQC9Fo0lT3k=; b=nQUT4smfz34CRetk2t/1MDpIl v+BgwnTLysWqrY6rAANgZU8BOg47YWkJBwMOxZMJphulYqHp46XFEp42tW/UORvxaHeZRVnhBgDHI wjkadsafoW1XbQZo33nvpPYzNkSSUF4mfk0+Z+fc0HK5E2/EmpcHBVYmTV4CqbuNrPvjh6fGNyQg1 leXiDHcnBjL/lF9Cm28Esr1R0Bas/4JVzaHWH8H7G3SK4kWvCedw7WckBHOjNk5U94U+/QGAQ1sUr q8mN30z7HN0T45JK60/mW71PyR/SOj642WUfD8ATHNpCJw3Rl0w+5r2RbYYtiNOIqAc2vDgdZIRaw jfdQVpbqQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGiq-0003Bm-UD; Tue, 30 Jun 2020 13:54:53 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGfg-0001Ga-AF for linux-arm-kernel@lists.infradead.org; Tue, 30 Jun 2020 13:51:38 +0000 Received: by mail-wm1-x342.google.com with SMTP id a6so16013560wmm.0 for ; Tue, 30 Jun 2020 06:51:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=y0hPzbcINWUoj1nY9cM2w0ma0wuqc7/tUG8vEbWtQrA=; b=NyAGhIIq7tcUSetuycocG2Az7Rg27v0X3CZksZSP3YxgxoL2mqxpSTNv2VQRW+hw24 I2FpCK17236jluMXVrlB/I/SQORS/Oy3FQt/a3J5d/LQg4whDZBdx1uBcFP/IcCd+bY+ 2Oj03YvKxENikAh+NNcGwqNrA5szR+ChUeWCvRZcOf6HADFgwewaWFba+Yi8IcRQQlfZ kWyJ/0Gsl+UgCA02fH0QESE7xvtuIZtaW58qxxurPSnQUIQ9TAqf8KwZ6tqNh+AYLQ0S Dfcr4Ci3M1KGdXcdgBDuKtB7jCXXcE0oUft7kdyQrI62CGQkmT8s9zmi1u9BpeTzcWao kxPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=y0hPzbcINWUoj1nY9cM2w0ma0wuqc7/tUG8vEbWtQrA=; b=Qbjk34d7jsuxkYmq1dz9Qwj7mnjrPqT0nrgtdSWodroDsCoNL3Ouj4YUGgNwcvHuAZ Rc4pbLWD1nolR24O3nmgbDO07Fl+9e68OhkpzHHrbdexTOD3V6SufAJuWQXxUXuIVRBD rddWR2I//77m91lNqHQ/YowKIfzJutH2YKkkfeDigWfmVpfumQmr4Twi2QUEXbKT7z17 6I23QH1FLVQL5+wCfD6bH2K1QKVZyDtuzkmo7SOV3N7VFJ5k24oJ2IotNd13uRPuvncy T2227gBLWzfslbfxuXLZ0459iiyh7WND27RHks0dVlPAOYmrQNa2FVtBOvOTlxaDODbE baJA== X-Gm-Message-State: AOAM533te53PR5gcaJ8gXn/+PhZe7yfaHlY8RKPSW1m8QM2mXBKpj3O0 w/qq+rD5RCpJTjHoSb+489bqLA== X-Google-Smtp-Source: ABdhPJxWWWQuwmxxv7qT6mU94toirjTBOKwjxi7sdSOqWkv+QHH/hAXbCM5wLN+DsnyGnN5Bs7fqXw== X-Received: by 2002:a05:600c:c1:: with SMTP id u1mr22176559wmm.48.1593525095077; Tue, 30 Jun 2020 06:51:35 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id t4sm3876746wmf.4.2020.06.30.06.51.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:51:34 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 20/30] misc: mic: scif: scif_epd: Describe missing 'scifdev' argument(s) Date: Tue, 30 Jun 2020 14:51:00 +0100 Message-Id: <20200630135110.2236389-21-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630135110.2236389-1-lee.jones@linaro.org> References: <20200630135110.2236389-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:342 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org For some reason (copy 'n' paste error?) the passed in pointers to 'struct scif_dev scifdev' weren't described throughout the source file. Change that. Fixes the following W=1 kernel build warning(s): drivers/misc/mic/scif/scif_epd.c:120: warning: Function parameter or member 'scifdev' not described in 'scif_cnctreq' drivers/misc/mic/scif/scif_epd.c:166: warning: Function parameter or member 'scifdev' not described in 'scif_cnctgnt' drivers/misc/mic/scif/scif_epd.c:191: warning: Function parameter or member 'scifdev' not described in 'scif_cnctgnt_ack' drivers/misc/mic/scif/scif_epd.c:213: warning: Function parameter or member 'scifdev' not described in 'scif_cnctgnt_nack' drivers/misc/mic/scif/scif_epd.c:230: warning: Function parameter or member 'scifdev' not described in 'scif_cnctrej' drivers/misc/mic/scif/scif_epd.c:255: warning: Function parameter or member 'scifdev' not described in 'scif_discnct' drivers/misc/mic/scif/scif_epd.c:309: warning: Function parameter or member 'scifdev' not described in 'scif_discnt_ack' drivers/misc/mic/scif/scif_epd.c:325: warning: Function parameter or member 'scifdev' not described in 'scif_clientsend' drivers/misc/mic/scif/scif_epd.c:341: warning: Function parameter or member 'scifdev' not described in 'scif_clientrcvd' Signed-off-by: Lee Jones --- drivers/misc/mic/scif/scif_epd.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/misc/mic/scif/scif_epd.c b/drivers/misc/mic/scif/scif_epd.c index 590baca9dc7bf..426687f6696b5 100644 --- a/drivers/misc/mic/scif/scif_epd.c +++ b/drivers/misc/mic/scif/scif_epd.c @@ -104,6 +104,7 @@ void scif_cleanup_zombie_epd(void) /** * scif_cnctreq() - Respond to SCIF_CNCT_REQ interrupt message + * @scifdev: SCIF device * @msg: Interrupt message * * This message is initiated by the remote node to request a connection @@ -155,6 +156,7 @@ void scif_cnctreq(struct scif_dev *scifdev, struct scifmsg *msg) /** * scif_cnctgnt() - Respond to SCIF_CNCT_GNT interrupt message + * @scifdev: SCIF device * @msg: Interrupt message * * An accept() on the remote node has occurred and sent this message @@ -181,6 +183,7 @@ void scif_cnctgnt(struct scif_dev *scifdev, struct scifmsg *msg) /** * scif_cnctgnt_ack() - Respond to SCIF_CNCT_GNTACK interrupt message + * @scifdev: SCIF device * @msg: Interrupt message * * The remote connection request has finished mapping the local memory. @@ -203,6 +206,7 @@ void scif_cnctgnt_ack(struct scif_dev *scifdev, struct scifmsg *msg) /** * scif_cnctgnt_nack() - Respond to SCIF_CNCT_GNTNACK interrupt message + * @scifdev: SCIF device * @msg: Interrupt message * * The remote connection request failed to map the local memory it was sent. @@ -221,6 +225,7 @@ void scif_cnctgnt_nack(struct scif_dev *scifdev, struct scifmsg *msg) /** * scif_cnctrej() - Respond to SCIF_CNCT_REJ interrupt message + * @scifdev: SCIF device * @msg: Interrupt message * * The remote end has rejected the connection request. Set the end @@ -240,6 +245,7 @@ void scif_cnctrej(struct scif_dev *scifdev, struct scifmsg *msg) /** * scif_discnct() - Respond to SCIF_DISCNCT interrupt message + * @scifdev: SCIF device * @msg: Interrupt message * * The remote node has indicated close() has been called on its end @@ -301,6 +307,7 @@ void scif_discnct(struct scif_dev *scifdev, struct scifmsg *msg) /** * scif_discnct_ack() - Respond to SCIF_DISCNT_ACK interrupt message + * @scifdev: SCIF device * @msg: Interrupt message * * Remote side has indicated it has not more references to local resources @@ -317,6 +324,7 @@ void scif_discnt_ack(struct scif_dev *scifdev, struct scifmsg *msg) /** * scif_clientsend() - Respond to SCIF_CLIENT_SEND interrupt message + * @scifdev: SCIF device * @msg: Interrupt message * * Remote side is confirming send or receive interrupt handling is complete. @@ -333,6 +341,7 @@ void scif_clientsend(struct scif_dev *scifdev, struct scifmsg *msg) /** * scif_clientrcvd() - Respond to SCIF_CLIENT_RCVD interrupt message + * @scifdev: SCIF device * @msg: Interrupt message * * Remote side is confirming send or receive interrupt handling is complete.