From patchwork Tue Jun 30 13:51:03 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11634071 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0A9B413B6 for ; Tue, 30 Jun 2020 13:58:32 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8531A20774 for ; Tue, 30 Jun 2020 13:58:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bWeNd/+O"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DBX0I1Xo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8531A20774 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HulKgVcdi0v+EbWVKH1Dr+xagcMyVOneEplgL/FZu2k=; b=bWeNd/+O0pY40biD7n+GRClSM RbkeDzCkcwRpLQ1hpKkdUTXGYgSatE8eymZtNn3c7RPE9ws6k0LW/EHaOGecw8Kq6mG3tffViu8yC LiGOMJIgPiUUclBxI44IAas1jS4V4jgdL2KRO0dwCR6/b7N+5iOojSHayKzpeMKpF9z5hlpw2waUY ajWcLhXiIJJ8zPnExkeiN/P8TUcJa97EMH4CqxPdm0LsYPNCVPdJZnUUQX3Kd/MGZAfZ29++fX6XC rldZ/6O0sTtpzqGOazATG4gGu6TzW4+FjNNEDfPjDiEp+RsEPUuWwQX8bPwGxfsc59SIl/znOlalH WHQ1Zu/mQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGjq-0003vp-AQ; Tue, 30 Jun 2020 13:55:54 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGfj-0001Hb-Tx for linux-arm-kernel@lists.infradead.org; Tue, 30 Jun 2020 13:51:41 +0000 Received: by mail-wm1-x343.google.com with SMTP id j18so18900423wmi.3 for ; Tue, 30 Jun 2020 06:51:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=yU99x7wrPL/01EJwaTy/8jjc+2wcUgkGTNBMFf55IvQ=; b=DBX0I1Xoz1RB0rHsREV4F1DBHNvh6YXcIk5gJTQM+hrPpe/ulAYPEBf3SY/1fdFdwQ iTLLW0oG7YnIeQaEnVmgmsJxPq85bgnw02059tpG1WH/kSFOUkX9FEy+MxGDMeN8NuNZ TJcEhQPSsDI3Dm8CYkl12pqFw0v9tlzqY1n/QV0VEBd2omHuCM4utDdThU+PIvkGKd7a ynrV+MLQC0MeV/7OtudGaup3/p3XVgsYmofHRBHLFBgC0T9HvJI+yNsd+Ztk3Hcg/6dQ eMDPtojOGYIvAeDvoMdE/+U/0BjMDImQcGQUOYi/C4KFtRvT9ZhWC5UwQGYgPoBJtmLD 1y3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=yU99x7wrPL/01EJwaTy/8jjc+2wcUgkGTNBMFf55IvQ=; b=J0SwZ3i5qE9az/EYX9gMxyUCHDht552acnYs9LyXDAWogScyfDwGVTMdQCaNdRowQw mgAzEvlQI4IZA8vcUXO7sq+RKa7V/Fdw9V6DXFxu0jDbVOS/ZLYj2FKdJ0FDLeSr6H36 BiPUevS3CJ/SKIEi8c+snZUhbxeYXgvSDLEraGy+V17XbasVByqGzBH5FJI1/NmzjCaf BSdESf88tz13YGE+gVtTY8E2ifvCN97U44gM0Sf+8LK0G82zeyr2Ofiw/Snev5WKvn1X YH7zb6njwqgKWNfP1lJ4YZT0C8kM9oUXoWfB1hYmcJAJfxd4eDChU7W7NKoVl8g59Fad vWZg== X-Gm-Message-State: AOAM53216wVQ/UdqV0KuJ9P31weufcL6iYgRKODGgQNGCXgfnIqbzQio ynUZy2Hd0mSwhXTC3nobHOtLng== X-Google-Smtp-Source: ABdhPJxxX6DLAxnAOLXJaTGQjMHo/F+wmeM2ttmW7ZKu2Qki+qguyXmwlzw33EFjUo8ZheSVrZSmCg== X-Received: by 2002:a7b:c5c7:: with SMTP id n7mr21826376wmk.77.1593525098319; Tue, 30 Jun 2020 06:51:38 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id t4sm3876746wmf.4.2020.06.30.06.51.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:51:37 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 23/30] misc: mic: scif: scif_dma: Fix a couple of kerneldoc issues Date: Tue, 30 Jun 2020 14:51:03 +0100 Message-Id: <20200630135110.2236389-24-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630135110.2236389-1-lee.jones@linaro.org> References: <20200630135110.2236389-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:343 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ashutosh Dixit , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sudeep Dutt Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Firstly demote scif_rma_destroy_tcw()'s header to a standard comment as no attempt has been made to document any of the function arguments. Secondly, provide missing description for 'prot' for scif_register_temp(). Fixes the following W=1 kernel build warnings: drivers/misc/mic/scif/scif_dma.c:110: warning: Function parameter or member 'mmn' not described in '__scif_rma_destroy_tcw' drivers/misc/mic/scif/scif_dma.c:110: warning: Function parameter or member 'start' not described in '__scif_rma_destroy_tcw' drivers/misc/mic/scif/scif_dma.c:110: warning: Function parameter or member 'len' not described in '__scif_rma_destroy_tcw' drivers/misc/mic/scif/scif_dma.c:344: warning: Function parameter or member 'prot' not described in 'scif_register_temp' Cc: Sudeep Dutt Cc: Ashutosh Dixit Signed-off-by: Lee Jones --- drivers/misc/mic/scif/scif_dma.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/misc/mic/scif/scif_dma.c b/drivers/misc/mic/scif/scif_dma.c index c7c873409184c..401b98e5ad79a 100644 --- a/drivers/misc/mic/scif/scif_dma.c +++ b/drivers/misc/mic/scif/scif_dma.c @@ -99,7 +99,7 @@ int scif_reserve_dma_chan(struct scif_endpt *ep) } #ifdef CONFIG_MMU_NOTIFIER -/** +/* * scif_rma_destroy_tcw: * * This routine destroys temporary cached windows @@ -332,6 +332,7 @@ static bool scif_rma_tc_can_cache(struct scif_endpt *ep, size_t cur_bytes) * @epd: End Point Descriptor. * @addr: virtual address to/from which to copy * @len: length of range to copy + * @prot: read/write protection * @out_offset: computed offset returned by reference. * @out_window: allocated registered window returned by reference. *