From patchwork Tue Jun 30 13:50:42 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11634029 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 90A7B912 for ; Tue, 30 Jun 2020 13:53:19 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6836620702 for ; Tue, 30 Jun 2020 13:53:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jkQfBYbc"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wYqNqpj4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6836620702 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/oHCN5avlFi6duo0Z5zoYFiI5LvnKmdBF/iH9yIIx5c=; b=jkQfBYbcjXyjxfubpa3tZjWB4 P9xfwjjnm3kfkd2cXd/QKficZKRr3i3ipL/vDDuDNX3FdWJx93mJ/EFWO0RkTG2GNtZs7yikB2eIM aT966ZEwsSlS95vmwWSJHfBmMhukOgmthojZWUp3i0LeyY4FuVYfpBxEmtLSQcQdiguFxocHmkVt2 QPlu3fLVN2r+2vH6o3x+xA4zJNZ5RDk44B8dlf36bXqZOdPawLClNMVdTXv7yXgvJy8dJ0MoL1gd8 HscYXvL8bOs4w6GdSeZjiya+CcxB4frJ1U+4BOgNYlSj00pILt4Pt2IhXG6j4XkGTc9/TdckQecOf 8w2IF4x9Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGfU-0001Ca-66; Tue, 30 Jun 2020 13:51:24 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGfM-0001B6-S4 for linux-arm-kernel@lists.infradead.org; Tue, 30 Jun 2020 13:51:17 +0000 Received: by mail-wm1-x342.google.com with SMTP id q15so18894576wmj.2 for ; Tue, 30 Jun 2020 06:51:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0JG9yfk7UsIlwDFN/XvWcoL4qtnzwNOpXg0C3Lo2gcU=; b=wYqNqpj46PQI5CQBcWLOeLqbE5yU0YKgbwQldUAM+2YLSOl0alIcjDAjWxXqItSLVF EjicKVJJSbpZ66Us/9K8NPC+lXTwZGycJQZ6n/WkAgH2KMP2mA0qgo11H8zKcSrJ7ra9 DEolk/J/4SdiODEWHl7mVjseYCplZJ7zPDnNUN0b+L6ZVGNz/NI50ZUYe9c/Lf+9Yknt syutilb7MUGTIeMxwtRle9iILSYmYLB2zUoCALw3NNmn0KcrBKoa5V6LegPNh+IWGY3X 0E/Scjq+fB9Ks/pJeviVQ9EFQ49uwRt0MF172acvJ6l+K3bNG4rMzS2aB0l1cIwn9qlb DBEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0JG9yfk7UsIlwDFN/XvWcoL4qtnzwNOpXg0C3Lo2gcU=; b=n5POH3Or+fUYtL6EQf+3gvz3ulHXEjUU8G4bgzqgufc1z4e12+fib038UMJ9wQ16D0 AwiyUluW2dIgMvHny2mfBB9MPymENvL3p9o8BMjNX5foWTj4UmN8S5PE2/rGd2+4MJIw SKKD2tOZSGqPCIVjClN0Z1UVtp7DUD1SNz3SEqJwbrkR16D5Kbxo1cx7SPLBMrOuHisg 9ygssJlUEtocCwPUE5kZ79fmRAMBLLRCLsSAQKuLiNw5cMry1RVsWjPQkCTY0bacmynI BVKg6dzqyQXScQJjfec9/Z4FgrPEFzvgVaDeF6OPbhbGrQFBtY9F3rnBdTLaP3sa4+hU bkFg== X-Gm-Message-State: AOAM530oB8fXF+26IjLlYpV2twZSjolbVYAcpmAaHTfN9vNfHeoU/sz3 gC/nmKRQI2eBPzbYdXblKuvnKw== X-Google-Smtp-Source: ABdhPJzinaVgXzm1+p8rUkcxU0U4zHaoc0tKkatJO/uvJ76C784lzkLQEsHBmfuew/F+rEeqz/RK9Q== X-Received: by 2002:a7b:cd10:: with SMTP id f16mr22050588wmj.86.1593525075011; Tue, 30 Jun 2020 06:51:15 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id t4sm3876746wmf.4.2020.06.30.06.51.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:51:14 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 02/30] misc: genwqe: card_sysfs: Demote function/file headers from kerneldoc Date: Tue, 30 Jun 2020 14:50:42 +0100 Message-Id: <20200630135110.2236389-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630135110.2236389-1-lee.jones@linaro.org> References: <20200630135110.2236389-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:342 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Joerg-Stephan Vogt , Michael Ruettger , Frank Haverkamp , linux-kernel@vger.kernel.org, Michael Jung , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org There has been no attempt to provide documentation for these function's arguments, so align with the remainder of the file and just treat them as standards function headers. Fixes the following W=1 kernel build warnings: drivers/misc/genwqe/card_sysfs.c:32: warning: cannot understand function prototype: 'const char * const genwqe_types[] = ' drivers/misc/genwqe/card_sysfs.c:150: warning: Function parameter or member 'dev' not described in 'curr_bitstream_show' drivers/misc/genwqe/card_sysfs.c:150: warning: Function parameter or member 'attr' not described in 'curr_bitstream_show' drivers/misc/genwqe/card_sysfs.c:150: warning: Function parameter or member 'buf' not described in 'curr_bitstream_show' drivers/misc/genwqe/card_sysfs.c:166: warning: Function parameter or member 'dev' not described in 'next_bitstream_show' drivers/misc/genwqe/card_sysfs.c:166: warning: Function parameter or member 'attr' not described in 'next_bitstream_show' drivers/misc/genwqe/card_sysfs.c:166: warning: Function parameter or member 'buf' not described in 'next_bitstream_show' drivers/misc/genwqe/card_sysfs.c:271: warning: Function parameter or member 'kobj' not described in 'genwqe_is_visible' drivers/misc/genwqe/card_sysfs.c:271: warning: Function parameter or member 'attr' not described in 'genwqe_is_visible' drivers/misc/genwqe/card_sysfs.c:271: warning: Function parameter or member 'n' not described in 'genwqe_is_visible' Cc: Michael Jung Cc: Michael Ruettger Cc: Frank Haverkamp Cc: Joerg-Stephan Vogt Signed-off-by: Lee Jones --- drivers/misc/genwqe/card_sysfs.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/misc/genwqe/card_sysfs.c b/drivers/misc/genwqe/card_sysfs.c index 28a3fb1533f70..b2f115602523a 100644 --- a/drivers/misc/genwqe/card_sysfs.c +++ b/drivers/misc/genwqe/card_sysfs.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0-only -/** +/* * IBM Accelerator Family 'GenWQE' * * (C) Copyright IBM Corp. 2013 @@ -129,7 +129,7 @@ static ssize_t base_clock_show(struct device *dev, } static DEVICE_ATTR_RO(base_clock); -/** +/* * curr_bitstream_show() - Show the current bitstream id * * There is a bug in some old versions of the CPLD which selects the @@ -156,7 +156,7 @@ static ssize_t curr_bitstream_show(struct device *dev, } static DEVICE_ATTR_RO(curr_bitstream); -/** +/* * next_bitstream_show() - Show the next activated bitstream * * IO_SLC_CFGREG_SOFTRESET: This register can only be accessed by the PF. @@ -260,7 +260,7 @@ static struct attribute *genwqe_normal_attributes[] = { NULL, }; -/** +/* * genwqe_is_visible() - Determine if sysfs attribute should be visible or not * * VFs have restricted mmio capabilities, so not all sysfs entries