Message ID | 20200630135110.2236389-31-lee.jones@linaro.org (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <SRS0=CTHU=AL=lists.infradead.org=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@kernel.org> Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CCB71912 for <patchwork-linux-arm@patchwork.kernel.org>; Tue, 30 Jun 2020 14:03:47 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 72D02206BE for <patchwork-linux-arm@patchwork.kernel.org>; Tue, 30 Jun 2020 14:03:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FRQAgxDY"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="UCptlGP8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 72D02206BE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HeQCwKLlyP80GH56ioCUDqy6eUuOKffM1WiLoLk5UnU=; b=FRQAgxDY13dx1uJC6dzLOzxpZ CpLSTI4ZtA7jPiniWANkGGzpwx/MYdwUcasBvwTDtUrCIm0apDcoWtZzjLa7+koRVHYM78ukbpIEk x/OyzOGYIh5GhYqDVHvKf4fjruI6k8fekjLDXm9Gb+xOENMaL+nALxwfl8hnE9fQspJo7+rJKn9lR xXcLpzLh997Ajllt04i7xpcw7cuS9i7/yU1b8/yyVpTE13RFj5cEysYaMAC2geph1FgGWFUXKcFS2 Sg4kao3tyyuBADi1GPpaBf64eW8apftDJ9jKdhmTImJ25KtWY4RLuldsXZXiW7l4BjgORsuubS9EE mYjdVHN1w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGou-0006QL-GE; Tue, 30 Jun 2020 14:01:08 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGfr-0001KP-4A for linux-arm-kernel@lists.infradead.org; Tue, 30 Jun 2020 13:51:48 +0000 Received: by mail-wm1-x344.google.com with SMTP id j18so18900925wmi.3 for <linux-arm-kernel@lists.infradead.org>; Tue, 30 Jun 2020 06:51:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NnszQP2mk8a9Zq/MXSfFAa0Z6TG4Q6FByatEINovmEo=; b=UCptlGP89mz89UrYfXQefNW8+e4ZQEEx97tpWiKPBMfS4wNL0irneBp0jrTF9ByhBp r3sH1OSHEMiwFz/5r7EkY9kOTSEF5j3ZoqwRqWJb8vbVNW1skrkKsOZTP5gEp9oREz8g AbeUF9AZHhUcmH/ZNDNbXyX/tcNDJePdqaFSBzXZh+af/Hh0ljo857xNngaLb/5M6uvM FDyUkltnD8NJFywjYlMdE/rEgEs1gwt7Lotc5q/rX00mU0keywb2yCIfDaovLph8enxA OTfjHeNk1H1rosvo8UqtJ7TZT8tY+d+i9r5YkK3hUsAjwQZILkkV5knsYgiZKcO7geQh 9ulA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NnszQP2mk8a9Zq/MXSfFAa0Z6TG4Q6FByatEINovmEo=; b=Q78b1668oPtOdVSwsmcljSOqVp3Js/w0KeG1wWLIR88Vp9k24QgM13te2xhXEPB+gG AzdprNz0LcK6nsDcUAw362seTwqmgP4pScqQ3SVOW6JiTM/wcVqRK2t5wlsmj9VLs+yD 5BwN3GutzCLbtJ/p9Dv+YYFW4n3D+RLd6vpl1SZ88oKe/wbpVfETJkc6tZaAwIG+3Tgb Q8Lyhy2z42ORFpTt9kKZsW045o7JWmefiNNXboNCNB3kC7j9JJaO+QobcZmqKZWctX++ 1IxH6Uk/xb72+fvuPRA6MSAZCD9AD4zDoD3JGw402w0H7XXjcOfSFDBfQ+X1+AiSL0Sj yXBg== X-Gm-Message-State: AOAM531BYs80RV6yt4hj0HrQ/qomqJRxX/peSVdZVYvQlsQcQNQdUSfq vWU+BjTpJ7nxw6yOcq9a6tYMtg== X-Google-Smtp-Source: ABdhPJxAVcr7BMBgpDdFrMsgoyDTsXOxDXBRszKa7Wa69xRKWCYbNprLZlHUJCgW8CUodbxVKwRxlA== X-Received: by 2002:a1c:ed17:: with SMTP id l23mr21535111wmh.175.1593525106136; Tue, 30 Jun 2020 06:51:46 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id t4sm3876746wmf.4.2020.06.30.06.51.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:51:45 -0700 (PDT) From: Lee Jones <lee.jones@linaro.org> To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 30/30] misc: cxl: flash: Remove unused pointer Date: Tue, 30 Jun 2020 14:51:10 +0100 Message-Id: <20200630135110.2236389-31-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630135110.2236389-1-lee.jones@linaro.org> References: <20200630135110.2236389-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:344 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: <linux-arm-kernel.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/> List-Post: <mailto:linux-arm-kernel@lists.infradead.org> List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe> Cc: Andrew Donnellan <ajd@linux.ibm.com>, Lee Jones <lee.jones@linaro.org>, linux-kernel@vger.kernel.org, Frederic Barrat <fbarrat@linux.ibm.com>, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org> Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org |
Series |
Last batch of patches to clean up Misc
|
expand
|
diff --git a/drivers/misc/cxl/flash.c b/drivers/misc/cxl/flash.c index cb9cca35a2263..24e3dfcc91a74 100644 --- a/drivers/misc/cxl/flash.c +++ b/drivers/misc/cxl/flash.c @@ -175,7 +175,7 @@ static int update_devicetree(struct cxl *adapter, s32 scope) struct update_nodes_workarea *unwa; u32 action, node_count; int token, rc, i; - __be32 *data, drc_index, phandle; + __be32 *data, phandle; char *buf; token = rtas_token("ibm,update-nodes"); @@ -206,15 +206,12 @@ static int update_devicetree(struct cxl *adapter, s32 scope) switch (action) { case OPCODE_DELETE: + case OPCODE_ADD: /* nothing to do */ break; case OPCODE_UPDATE: update_node(phandle, scope); break; - case OPCODE_ADD: - /* nothing to do, just move pointer */ - drc_index = *data++; - break; } } }
The DRC index pointer us updated on an OPCODE_ADD, but never actually read. Remove the used pointer and shift up OPCODE_ADD to group with OPCODE_DELETE which also provides a noop. Fixes the following W=1 kernel build warning: drivers/misc/cxl/flash.c: In function ‘update_devicetree’: drivers/misc/cxl/flash.c:178:16: warning: variable ‘drc_index’ set but not used [-Wunused-but-set-variable] 178 | __be32 *data, drc_index, phandle; | ^~~~~~~~~ Cc: Frederic Barrat <fbarrat@linux.ibm.com> Cc: Andrew Donnellan <ajd@linux.ibm.com> Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/misc/cxl/flash.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)