diff mbox series

[04/30] misc: sgi-xp: xp_main: Staticify local functions xp_init() and xp_exit()

Message ID 20200630135110.2236389-5-lee.jones@linaro.org (mailing list archive)
State New, archived
Headers show
Series Last batch of patches to clean up Misc | expand

Commit Message

Lee Jones June 30, 2020, 1:50 p.m. UTC 
These functions are not exported and no external prototypes exist

Fixes W=1 kernel build warning(s):

 drivers/misc/sgi-xp/xp_main.c:227:1: warning: no previous prototype for ‘xp_init’ [-Wmissing-prototypes]
 227 | xp_init(void)
 | ^~~~~~~
 drivers/misc/sgi-xp/xp_main.c:250:1: warning: no previous prototype for ‘xp_exit’ [-Wmissing-prototypes]
 250 | xp_exit(void)
 | ^~~~~~~

Cc: Cliff Whickman <cpw@sgi.com>
Cc: Robin Holt <robinmholt@gmail.com>
Cc: Dean Nelson <dcn@sgi.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/misc/sgi-xp/xp_main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Robin Holt July 1, 2020, 5:09 p.m. UTC | #1 
On Tue, Jun 30, 2020 at 8:51 AM Lee Jones <lee.jones@linaro.org> wrote:
...
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Acked-By: Robin Holt <robinmholt@gmail.com>
diff mbox series

Patch

diff --git a/drivers/misc/sgi-xp/xp_main.c b/drivers/misc/sgi-xp/xp_main.c
index 5fd94d8360707..61b03fcefb134 100644
--- a/drivers/misc/sgi-xp/xp_main.c
+++ b/drivers/misc/sgi-xp/xp_main.c
@@ -223,7 +223,7 @@  xpc_disconnect(int ch_number)
 }
 EXPORT_SYMBOL_GPL(xpc_disconnect);
 
-int __init
+static int __init
 xp_init(void)
 {
 	enum xp_retval ret;
@@ -246,7 +246,7 @@  xp_init(void)
 
 module_init(xp_init);
 
-void __exit
+static void __exit
 xp_exit(void)
 {
 	if (is_uv())