From patchwork Tue Jun 30 13:50:46 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11634037 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5034613B6 for ; Tue, 30 Jun 2020 13:53:54 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 298962074F for ; Tue, 30 Jun 2020 13:53:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rd9ektQ6"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="XFCjAT0F" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 298962074F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=z3GVFz2onm1LdUOCxtuPG8rMUcUojGLOtbR/LGJ1FbY=; b=rd9ektQ6ntx/6J6c0/Iz+NSi4 9Q+pCD9SmQrXUBRzKcncRt1hYy0polTeXWvbo4LEcAXTNXXSnIK5krepWrxgKeyM3wZWVh6KRUT2v tatUi+3vEapsdPY3m5ze8pK/JzA59P3EFfeANMxjl9thtJaGEtKX5tD7qlfqNtqBROSLNBENfrz5c yfsZxhSi4+ZhoQ+OdCOupiD6pu5eWEt49aSrZU71VujyiSL2UR50NVo6iQ5Iyr/XcTNfWMxQYd/Xv ffB4ZFnksLCaBDRRhS53iPI2ONsqu1SJV/XZD7RojO37FDAcE9jEl0r9qLiQCdKhulSReojobmpDr dASNwwFWw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGg5-0001P1-Hz; Tue, 30 Jun 2020 13:52:01 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGfR-0001C8-BX for linux-arm-kernel@lists.infradead.org; Tue, 30 Jun 2020 13:51:22 +0000 Received: by mail-wr1-x441.google.com with SMTP id o11so20284008wrv.9 for ; Tue, 30 Jun 2020 06:51:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KJS/keN17J0QH5GuMuvB98PgdVtEKXtUDk7tuwa3qBk=; b=XFCjAT0Fm2Ktek2vUmuOq+8tn3ROAtbgpJk64jEsnz+2NgMKEmCjQVVJiJw26bM0Jp jU+fBCIwnQ6kZyreKOOLT9bP2ruK+Lv/HnpktY370ivsAanhrBUWmAPNLh0s8vnVerwO atcn4KvjOovczEXJuU9OrLI34JUVUq0ZZ3hoAd3yw77gPdqsSoLmX+hUivb8eEwk9oI+ mHsFEavVDJuvmzCMV7qeQ9C8td2nhnr8vG+MVxa7jOsrGmGKWTqoEqyia6KKpCHhpxPs oQbx8xurNvuThuNuImiFXtrfph9OG4buS8F9VlXr3Zianl+H0ZpJKydwEo0E/oKpTULn e5QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KJS/keN17J0QH5GuMuvB98PgdVtEKXtUDk7tuwa3qBk=; b=pUB598H/sA5Q1tT5gfLYIKcOQU8Ux9MfkyOqGwYlHDbmJrOzBe9gu/F67asy6EIuXX JaoURkYHyDG63AJFhKMSDFwEoQxhEQaRW7TgnOTq6/ZQ1mlZ2CB/0SFhAaaoc27M2cKe bHPbKBEVba/J8wYydBB0OXGdfRH7UqJizICPozD0k5XvHgOgfyPlo9vY2hQ5I6D9iOkp uB+s/sHPZ2drIQxnrKzDLTUCcVkHHbA6ot4Uv8Gnkam3Nxsq+8yE2NB1n4LtcEhDyzGw FLvl/pkejnXAM3nh7NLKtGXmci/TGOSlff8I2RZ7Zu0p7MYT1FN7pndkUf4aw1JXqrxW 4g7Q== X-Gm-Message-State: AOAM530POr3n28zZkAWr5bHPfSeEh0AhK1LAYO9ocdy2lqTkpayrDXku MeJ5I5lZdt3pXcUuvvkcu+Qadg== X-Google-Smtp-Source: ABdhPJy9deKfqIJP8pIRE38cgy1gIRpXGQWSZKp0s1rjHDZKFWj+i5L71stp9jmlT9v2RxSlGNzVYA== X-Received: by 2002:adf:c44d:: with SMTP id a13mr22553613wrg.205.1593525080501; Tue, 30 Jun 2020 06:51:20 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id t4sm3876746wmf.4.2020.06.30.06.51.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:51:19 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 06/30] misc: ibmasm: command: Demote function headers from kerneldoc Date: Tue, 30 Jun 2020 14:50:46 +0100 Message-Id: <20200630135110.2236389-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630135110.2236389-1-lee.jones@linaro.org> References: <20200630135110.2236389-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:441 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, =?utf-8?q?Max_Asb=C3=B6ck?= Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org The correct format is not used and no attempt has been made to document the function arguments. Makes sense to just demote the header back down to a simple comment. Fixes the following W=1 warnings: drivers/misc/ibmasm/command.c:106: warning: Function parameter or member 'sp' not described in 'ibmasm_exec_command' drivers/misc/ibmasm/command.c:106: warning: Function parameter or member 'cmd' not described in 'ibmasm_exec_command' drivers/misc/ibmasm/command.c:149: warning: Function parameter or member 'cmd' not described in 'ibmasm_wait_for_response' drivers/misc/ibmasm/command.c:149: warning: Function parameter or member 'timeout' not described in 'ibmasm_wait_for_response' drivers/misc/ibmasm/command.c:162: warning: Function parameter or member 'sp' not described in 'ibmasm_receive_command_response' drivers/misc/ibmasm/command.c:162: warning: Function parameter or member 'response' not described in 'ibmasm_receive_command_response' drivers/misc/ibmasm/command.c:162: warning: Function parameter or member 'size' not described in 'ibmasm_receive_command_response' Cc: "Max Asböck" Signed-off-by: Lee Jones --- drivers/misc/ibmasm/command.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/misc/ibmasm/command.c b/drivers/misc/ibmasm/command.c index 2863657fa2683..733dd30fbaccf 100644 --- a/drivers/misc/ibmasm/command.c +++ b/drivers/misc/ibmasm/command.c @@ -94,7 +94,7 @@ static inline void do_exec_command(struct service_processor *sp) } } -/** +/* * exec_command * send a command to a service processor * Commands are executed sequentially. One command (sp->current_command) @@ -140,7 +140,7 @@ static void exec_next_command(struct service_processor *sp) } } -/** +/* * Sleep until a command has failed or a response has been received * and the command status been updated by the interrupt handler. * (see receive_response). @@ -153,7 +153,7 @@ void ibmasm_wait_for_response(struct command *cmd, int timeout) timeout * HZ); } -/** +/* * receive_command_response * called by the interrupt handler when a dot command of type command_response * was received.