From patchwork Wed Jul 1 12:46:57 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11636267 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 75C65913 for ; Wed, 1 Jul 2020 12:50:56 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4E2AA20775 for ; Wed, 1 Jul 2020 12:50:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OdOvWivA"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Vmuk3iCY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E2AA20775 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cs/kn2qZZs+xjrIdqy95cbNe+H0lJsjfIHtF4P9rss8=; b=OdOvWivAvzqMj/p8LdPN7wolL W842j+F0qtxrBFBc2+yLtGpYwN1ndZ2zZlCfz9Jot0RmAorT+K20gIAOP6YrdoSkW8VfAC+b6rl0M wntq+sRkQPnp3Za7PUa2K0f8wzELYUy1pBH3DBNDX1OH7Bk+54QcNocCvY+XS6zeMkOxmC5eEOtRR FqcBJtfTB6qvoH9LRf9mnk0Lt66UXOrTom6TRPoRexPMfdUoU8KJob/b6LiiXBrf9LO/rCElyckyY sCx7v5LbPdthdySkQU9rVykcgZNgUcdPtwXcwSrjv/DhtKTz8fUnRL3D05YLvx2SSOjQ+dE/5fmeq ydTwxxR7A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqc9W-000583-Jw; Wed, 01 Jul 2020 12:47:50 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqc91-0004tM-FN for linux-arm-kernel@lists.infradead.org; Wed, 01 Jul 2020 12:47:20 +0000 Received: by mail-wm1-x342.google.com with SMTP id l2so21602705wmf.0 for ; Wed, 01 Jul 2020 05:47:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dBwifa0ZuoxuR9zanjCi/SQC3HxVrP+0TUYJWPy9rp0=; b=Vmuk3iCY78/WlEtcAdEexKWZcshcQ4CAc2QtQlIooAG1Sjzo7f922rZ5uu3Btw42mG pof4skzNtKjDAQ2V7hlvDc8qTUDRiAuUwOspjGY68c8ASAmQJZzYuw1DqpPM8TI+tbYk GA04r/sV9cy1DJ0+stgXKyLbOfzThikzkPVRIvV6m9L9IDgbCUeUCf5TPNOjaSYqNQDt /gJn0pdOlKPAceJRAr9sgb4pG0FQSmGa7l9+UIMmmI63BXVj+eiObd+MyXCYC2uFsXEb eSkxfH1EoY2oa1tfhAac2VmwXB4gICM7NLjLUlvi4MHodiQa5hiCYFQ+KVUpjcjAR7OV YM4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dBwifa0ZuoxuR9zanjCi/SQC3HxVrP+0TUYJWPy9rp0=; b=TPE7k/SPwkA41+v+F6SIqnUn9qlbts9i56LlNaZGEEoyM2GCcARnldAoCx/CEhH5lS YiChapInFCcSVYgU5TrnMIhVlTA1Wcbm04gT6Izp3lhjeZhMUisvLj3QCD7aklY8vuwF k6sQyUwm7k6KO4UU55K8QYZeprvUqAhghRqUUxNMK381erwE49IpYv+EllEIoS/JAzCO uOE7MqdZ9lPobqyHpAGSVO/VamJOmNhY2EbctiKUuwLzyFvUZI/9fGbwsC3Pe5Jsi6uX CFCyNXG2lpJlv6HdPIcu/FA3E5rYYvbD6qqOk2wtBfwM2uM7b9Jh1d4HZwGaY0oFU0em u3qA== X-Gm-Message-State: AOAM532oVTHg8EofzGofrjjrEOApyptWWYhTy0Jf2yfD7u2IZVvBw7nB 6xwzLka4hEGchwoqkw+de7rdzg== X-Google-Smtp-Source: ABdhPJyRlpTGWtkkPDEX2Kbq6J1uY8YesgkaBwFXFyeaq+IHUPNxOc1d79VYpEMGSjz+hU5Plde7oA== X-Received: by 2002:a1c:f301:: with SMTP id q1mr26418165wmq.110.1593607638527; Wed, 01 Jul 2020 05:47:18 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id o29sm7817862wra.5.2020.07.01.05.47.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2020 05:47:17 -0700 (PDT) From: Lee Jones To: ulf.hansson@linaro.org Subject: [PATCH 10/15] mmc: host: rtsx_usb_sdmmc: Remove set but unused variable 'err' Date: Wed, 1 Jul 2020 13:46:57 +0100 Message-Id: <20200701124702.908713-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200701124702.908713-1-lee.jones@linaro.org> References: <20200701124702.908713-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200701_084719_672776_59CB5415 X-CRM114-Status: GOOD ( 14.21 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:342 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Roger Tseng , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Seeing as sd_wait_data_idle() returns void and only a very specific read value is checked, there doesn't seem to be a good reason to check the return value of rtsx_pci_read_register(). So remove the assignment and definition of 'err'. Squashes the following W=1 kernel build warning: drivers/mmc/host/rtsx_usb_sdmmc.c: In function ‘sd_wait_data_idle’: drivers/mmc/host/rtsx_usb_sdmmc.c:657:6: warning: variable ‘err’ set but not used [-Wunused-but-set-variable] 657 | int err, i; | ^~~ Cc: Roger Tseng Signed-off-by: Lee Jones --- drivers/mmc/host/rtsx_usb_sdmmc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/host/rtsx_usb_sdmmc.c b/drivers/mmc/host/rtsx_usb_sdmmc.c index a7084c50ad65f..7225d9312af8c 100644 --- a/drivers/mmc/host/rtsx_usb_sdmmc.c +++ b/drivers/mmc/host/rtsx_usb_sdmmc.c @@ -654,12 +654,11 @@ static u8 sd_search_final_phase(struct rtsx_usb_sdmmc *host, u32 phase_map) static void sd_wait_data_idle(struct rtsx_usb_sdmmc *host) { - int err, i; + int i; u8 val = 0; for (i = 0; i < 100; i++) { - err = rtsx_usb_ep0_read_register(host->ucr, - SD_DATA_STATE, &val); + rtsx_usb_ep0_read_register(host->ucr, SD_DATA_STATE, &val); if (val & SD_DATA_IDLE) return;