From patchwork Wed Jul 1 12:46:48 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11636241 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 95D5B13B4 for ; Wed, 1 Jul 2020 12:49:17 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6EA7120702 for ; Wed, 1 Jul 2020 12:49:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Wq3L0VmN"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yk+r9H6l" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6EA7120702 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OcW1rDVfOumT1Sei/zdAy3iSek16OPPJN+1ihmizw4c=; b=Wq3L0VmNLvOkfG1xJcBT7Mtlq A0mzgb9gmFvEJHhn7nS2iObN+wAsxVzByR6m4JitByvlPHEHXKkODELMaxCUkRSpbS63/+4hybo8U ccUcBiqv02O7trtp0zivWp2uNStfKoEWwWXXkxtrJUfqXhNBK1Vfe+2yv7YjvFjxiYwhoMlXz/FM6 Fvodztil9Ci4jzdpNUfSClNtoXAZMkUEGnSfC8IbciFFfgG+Wb5xm4IW70HMICOWw3iO+bf8ZQOXu sJg8HYbb7AY/tTbxR4iER0aqmBv47CmXYXG14JEoH9l8Djzuvi4i0ExZaWhP/eG3/nSrNRDUoTsYR dZ5fbYTCA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqc8x-0004rc-OU; Wed, 01 Jul 2020 12:47:15 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqc8t-0004pA-0v for linux-arm-kernel@lists.infradead.org; Wed, 01 Jul 2020 12:47:12 +0000 Received: by mail-wm1-x343.google.com with SMTP id w3so10634606wmi.4 for ; Wed, 01 Jul 2020 05:47:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=x8xCKIw9Ld5Xa//V32cpz9QyqhlFaWmoKz6kDT+w1CQ=; b=yk+r9H6lX2Cc5i0dlDYZHeHh6IaafXhdA3+cx+ukukxwN0QSjnW3v7AJbxYJahc1rJ It9z0lJpzuNfcP/Ch9oXRsRIl0RTjxEwgK1d4Xrlul48VRVT2oRTZEMpcxQchBYCm4Hf 0hSQ5kknJI7Gvwga0UCeFY1HqgqXDCC3WO9BLFuinxIrTAniduRmJTwp79YNdRxttxsp lbNiJkrLQOfUSvm+Ogb6yMaDLjrp8D6Ycy+5+Va5hhDZ7wVSQS8LKtRXxnBYkXXx5Q62 zR8Wan38GVVfXHBnLw8enlCYUQGkcw2kVwfFXLl8d7WTBo9JwwfLavhTIdmUIsfz6ql3 DZYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=x8xCKIw9Ld5Xa//V32cpz9QyqhlFaWmoKz6kDT+w1CQ=; b=a2xtZARseodrdpPCbd3c5vr1G4URVQzESnldZAlPNY/C4ObpepfgEdBJOo3Egoep66 dW3/d6yCfRIlVc/BgNJMwcKiMubbb/Jzxi2BvL/rn20jIwz8CmIDs9rOQmi+epjdi1ZA 7dUF4hP3EBSUr141deSzLvecF+y+SH8OZz10B8FnMkX0P9eoJCZFqChb5NYa76KQhHD4 0dIu/q9eQvW2b8BUqMzHtHndYQ632gfVSqLvqMhfygSG9hG+Gbb+NhEVIjcU0xTK0ZR4 +tzmDajhvFCJDv0CzAq3Jddx6FwG9pMNJcrKf/u0kbRZPpYISP5GwD6AxC7XSmKE4mLj aPOA== X-Gm-Message-State: AOAM530iDIZMDEAT4zSgA8Zo78vAI9tlc8OFTF+o6rYzQb/BKzxR3QyV RUSTPQHFreiNC7Im0xjbiHWIkA== X-Google-Smtp-Source: ABdhPJxQ+Yg6i9TIajip46TH3pID9Y8RjLR+RANFA+2ocxzD+PQpg4Nb+WF2voDLYQGI8AIzZdylRg== X-Received: by 2002:a1c:7209:: with SMTP id n9mr26663783wmc.150.1593607628056; Wed, 01 Jul 2020 05:47:08 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id o29sm7817862wra.5.2020.07.01.05.47.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2020 05:47:07 -0700 (PDT) From: Lee Jones To: ulf.hansson@linaro.org Subject: [PATCH 01/15] mmc: core: quirks: Mark fixups as __maybe_unused Date: Wed, 1 Jul 2020 13:46:48 +0100 Message-Id: <20200701124702.908713-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200701124702.908713-1-lee.jones@linaro.org> References: <20200701124702.908713-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200701_084711_181023_3B3098DC X-CRM114-Status: GOOD ( 15.84 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:343 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrei Warkentin , Martin Mares , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Not all source files which include quirks.h make use of the all of the available fixup information. When this happens the compiler complains that some constant variables are defined by never used. We can fix this by telling the compiler that this intentional by simply marking them as __maybe_unused. Fixes the following W=1 kernel build warnings: In file included from drivers/mmc/core/sdio.c:22: drivers/mmc/core/quirks.h:105:31: warning: ‘mmc_ext_csd_fixups’ defined but not used [-Wunused-const-variable=] 105 | static const struct mmc_fixup mmc_ext_csd_fixups[] = { | ^~~~~~~~~~~~~~~~~~ drivers/mmc/core/quirks.h:17:31: warning: ‘mmc_blk_fixups’ defined but not used [-Wunused-const-variable=] 17 | static const struct mmc_fixup mmc_blk_fixups[] = { | ^~~~~~~~~~~~~~ In file included from drivers/mmc/core/mmc.c:25: drivers/mmc/core/quirks.h:123:31: warning: ‘sdio_fixup_methods’ defined but not used [-Wunused-const-variable=] 123 | static const struct mmc_fixup sdio_fixup_methods[] = { | ^~~~~~~~~~~~~~~~~~ drivers/mmc/core/quirks.h:17:31: warning: ‘mmc_blk_fixups’ defined but not used [-Wunused-const-variable=] 17 | static const struct mmc_fixup mmc_blk_fixups[] = { | ^~~~~~~~~~~~~~ Cc: Andrei Warkentin Cc: Martin Mares Signed-off-by: Lee Jones --- drivers/mmc/core/quirks.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/core/quirks.h b/drivers/mmc/core/quirks.h index 472fa2fdcf139..d68e6e513a4f4 100644 --- a/drivers/mmc/core/quirks.h +++ b/drivers/mmc/core/quirks.h @@ -14,7 +14,7 @@ #include "card.h" -static const struct mmc_fixup mmc_blk_fixups[] = { +static const struct mmc_fixup __maybe_unused mmc_blk_fixups[] = { #define INAND_CMD38_ARG_EXT_CSD 113 #define INAND_CMD38_ARG_ERASE 0x00 #define INAND_CMD38_ARG_TRIM 0x01 @@ -102,7 +102,7 @@ static const struct mmc_fixup mmc_blk_fixups[] = { END_FIXUP }; -static const struct mmc_fixup mmc_ext_csd_fixups[] = { +static const struct mmc_fixup __maybe_unused mmc_ext_csd_fixups[] = { /* * Certain Hynix eMMC 4.41 cards might get broken when HPI feature * is used so disable the HPI feature for such buggy cards. @@ -120,7 +120,7 @@ static const struct mmc_fixup mmc_ext_csd_fixups[] = { }; -static const struct mmc_fixup sdio_fixup_methods[] = { +static const struct mmc_fixup __maybe_unused sdio_fixup_methods[] = { SDIO_FIXUP(SDIO_VENDOR_ID_TI_WL1251, SDIO_DEVICE_ID_TI_WL1251, add_quirk, MMC_QUIRK_NONSTD_FUNC_IF),