From patchwork Wed Jul 1 12:46:51 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11636239 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3003513B4 for ; Wed, 1 Jul 2020 12:49:04 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 088C420702 for ; Wed, 1 Jul 2020 12:49:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qtwOAgkw"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="PjiRPFC2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 088C420702 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KUo4YrBskbQ6bulLoT03dBC5OBiWsD8tG3uNrJca2VY=; b=qtwOAgkwX5CPt6AL0aA/Hpju5 qEjfS8mKW54yayFoBN16Dae1ojZT53YloGlcemOTqlRvyNexZd7t9mk6CzqFbx3BWJk50qYU4VYCb HET96DVycQqHCohsZNStq1MDlU/KQJALnLxxva09ZkemNSUnxKwKBktVckHPZ2qkB27Rj9f2e54Cl oRjLg85W4k4R5YUJPtY+xq+7msaDHfoJYxL4Y7rDigr2+vdErdGIRzCoe23bUnkqLPiJjOmidlH4F cAFaD8aju+GVCrwbO7E/e7ZE1wfzP87S8uAzuZjn73JMCQuNV9Qmq41M2Ln+4rfeKrJcsXmoImMFh n6+QAFbGQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqc96-0004uy-9Y; Wed, 01 Jul 2020 12:47:24 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqc8u-0004qA-HQ for linux-arm-kernel@lists.infradead.org; Wed, 01 Jul 2020 12:47:13 +0000 Received: by mail-wr1-x442.google.com with SMTP id b6so23636824wrs.11 for ; Wed, 01 Jul 2020 05:47:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CbNGlX0G5Ov7FT75iCw50EDu+qwZ/8J7t3LRBNdlSbA=; b=PjiRPFC2+ne1JlGgsc0KpJefm6lvkyRsu+EM+8TXu7yFTsA+q9615YF7ZDoGByGVaA QzIJ0Ny5ocQIQXGLjETMjLTXZkb0S0RYf8k4sh/YGGanFkW1YH7EXKpJ4wCv3GyyvwNp XUZBH+7325vbu6YVK2DFMOYYKnRpozd4ENmvm8mBXAsd/18hWr5L+b/wmMtI/EfBHx0C WK4UMad91alCJ1Eu6G47jzTP96yrOF93Z7YUPcBkS49rzZ4sybvwiHpB8j/7ulafXijB SfEcPSCU1uRCLW8yJj6ouzi6dHUy3dXkwlrEUs3oeOmnnu2UgjKGe6FRs/JWurPC4fNo T4Rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CbNGlX0G5Ov7FT75iCw50EDu+qwZ/8J7t3LRBNdlSbA=; b=gxbJAe3pv6+ykG42irLXb0B3DtB4/gz1fo89VptwxLsFgL/a+FyLFjhF8E8xHk+MJv HY/cNCqFdeoZYXcmVOVdW70CBKNno3TGfj7kiT9TFPXbD/Bg7UcmkJhzl0QPZtUSHALq vOmfWzZ4+GBPlBsMAOnk56gmEi12njTBelotJzGJ54iO34uI0WQYVbOm/icXNCeVMKYO XSph4wr68u6JFH06a7ZSRgHl/bIHk3uzjH0T9h1j/cBKCNDDD45Yfue6FbIn6Y2Kzhhw Z8juzYuyknw1J4Ki4rowI4BHql+PspdiAFrEDTJLlEbMMvsz+dIAKzTPKyZtZ9MFJAMX oSkg== X-Gm-Message-State: AOAM5315VQA4GGGR1jfLxzNMJ/AzN9pW3bPEyM7qGA+WgEw6tw4FPa80 fAFHB0isx9XyXwdZzad2trbFjw== X-Google-Smtp-Source: ABdhPJyR/yX50DpfFq9R2u3R16L2+L4q61pYf7cMIGM739hqYmJOThTTybjRR20yzg25Z+WZLrDNYA== X-Received: by 2002:a5d:474f:: with SMTP id o15mr23624823wrs.306.1593607631728; Wed, 01 Jul 2020 05:47:11 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id o29sm7817862wra.5.2020.07.01.05.47.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2020 05:47:10 -0700 (PDT) From: Lee Jones To: ulf.hansson@linaro.org Subject: [PATCH 04/15] mmc: host: sdhci-s3c: Provide documentation for missing struct properties Date: Wed, 1 Jul 2020 13:46:51 +0100 Message-Id: <20200701124702.908713-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200701124702.908713-1-lee.jones@linaro.org> References: <20200701124702.908713-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200701_084712_638932_973E6263 X-CRM114-Status: GOOD ( 12.33 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:442 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, Adrian Hunter , Jaehoon Chung , Ben Dooks , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Describe properties; ext_cd_irq, clk_rates and no_divider (x2). Squashes the following W=1 kernel build warnings: drivers/mmc/host/sdhci-s3c.c:126: warning: Function parameter or member 'ext_cd_irq' not described in 'sdhci_s3c' drivers/mmc/host/sdhci-s3c.c:126: warning: Function parameter or member 'clk_rates' not described in 'sdhci_s3c' drivers/mmc/host/sdhci-s3c.c:126: warning: Function parameter or member 'no_divider' not described in 'sdhci_s3c' drivers/mmc/host/sdhci-s3c.c:139: warning: Function parameter or member 'no_divider' not described in 'sdhci_s3c_drv_data' Cc: Adrian Hunter Cc: Ben Dooks Cc: Jaehoon Chung Signed-off-by: Lee Jones Reviewed-by: Jaehoon Chung --- drivers/mmc/host/sdhci-s3c.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c index 64200c78e90dc..9194bb73e601b 100644 --- a/drivers/mmc/host/sdhci-s3c.c +++ b/drivers/mmc/host/sdhci-s3c.c @@ -107,8 +107,11 @@ * @ioarea: The resource created when we claimed the IO area. * @pdata: The platform data for this controller. * @cur_clk: The index of the current bus clock. + * @ext_cd_irq: External card detect interrupt. * @clk_io: The clock for the internal bus interface. + * @clk_rates: Clock frequencies. * @clk_bus: The clocks that are available for the SD/MMC bus clock. + * @no_divider: No or non-standard internal clock divider. */ struct sdhci_s3c { struct sdhci_host *host; @@ -128,6 +131,7 @@ struct sdhci_s3c { /** * struct sdhci_s3c_driver_data - S3C SDHCI platform specific driver data * @sdhci_quirks: sdhci host specific quirks. + * @no_divider: no or non-standard internal clock divider. * * Specifies platform specific configuration of sdhci controller. * Note: A structure for driver specific platform data is used for future