From patchwork Wed Jul 1 12:46:52 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11636251 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B378D913 for ; Wed, 1 Jul 2020 12:49:39 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8C47A20775 for ; Wed, 1 Jul 2020 12:49:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oxOjVjiH"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="NkxOWXIN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8C47A20775 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wHwDgr5IdYRoFisoX2d5L8kyTdj8riwtABlhFouNNaE=; b=oxOjVjiH/vPUzN051M3ZmYTn2 kVlnSm9YMxbLXmQWrcjzXbJKUDYh++8QoRRncgeTQLi1woosAewirBVWiVpC0mhnCExKDmRp4emTK eaexdKZ4CrN+K2XNcXj4GUF4Df24SawvN+ywhRxERtVTOtz5pfuVyUxWBEKiyLV7m7pWfKMkeDsDA WDzTIJBsb57+HBnPJkzUb5NCY27aP4wHmwSDQh5dWMwvwbqahqEjxUeeZIfVP1bLu+xgsAKXhCsDV Lvmuhzee53GA/Wv9dn+60PvSTYr991FQgRdy+90STbT0UfHZi61nBhqPcrxfvHR/r+BLVKUEsRO3J V5R9GxbqA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqc9A-0004xG-Hm; Wed, 01 Jul 2020 12:47:28 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqc8v-0004qm-Un for linux-arm-kernel@lists.infradead.org; Wed, 01 Jul 2020 12:47:15 +0000 Received: by mail-wm1-x342.google.com with SMTP id q15so22258185wmj.2 for ; Wed, 01 Jul 2020 05:47:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=sJPW3QXOhHs7zWGK9W13Qhww3wag5wL/K8qzQE+aHP4=; b=NkxOWXINSEGLHqpysGjU6l/aLOB9D1RBUt6a9Cv/cmC44LR032HJ/q+z+4snhCTNaW PdMMvGuAtO6Ujsk4aFY5+ggkapbI0y8vbr63jnUFJyXL86NW5J8CQGij61gyCDHXbUvz q0ZXV3do+vtPoNt8BgF/Jqn4PdF42fkgGAD0WiII26VZNos1Zz4ezvQGo2YuQ6UVBJDV LjbxniUTQMcgraMb0BQXgE7a+gMVTa48nOSq35qfFocyo8c0E6lg3HCVEfXt60C77tY6 reC6aeGYzXZElVG8Ik/hDOwn7VmhUGcSH3jWARgSvgWiATkKl6mXLwuzriMC6WwSkV18 Tz5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=sJPW3QXOhHs7zWGK9W13Qhww3wag5wL/K8qzQE+aHP4=; b=ZE+WoRnSFuv22HLs/5pS3f9Zq2OlsKutiVkD6fNbTFAFGjxbRT3evLJEDqmBK94vdR 8S4kvljMILq08QJQ4N83/RoYxP6+PUwSa0adL2Eu7pTYFnkHz3EvqfvYDaFVQuhVJV3H KPOICGLRs2eF5TF0Jrx0WHg8b0MqBobk2Tm+IoADGFq/BDM/X79I7fAj3u340L9tgPrn g/49ZFG0RUDwJW0f22KmKwifklGQ+GhLGozWbWf/dRDTKewHfNzRehmob9hjxnSFZa60 oADgso2xsYJ43X6yoH0hxOhYIA2WO1VJSPsJVG1xm0p9cLHx4ZDMuQ0bzfybguoC+nav 2ejg== X-Gm-Message-State: AOAM530dTRcgD2P1YZolg8ELuzhYk29wfNCPlMREwZAr8fLj8tlJq1KO WoXq/umm0BtQcjwZliyonMj3qw== X-Google-Smtp-Source: ABdhPJxnFAAMJptNueVPmlk8boLIXJmBHNOeNDTpH4SZs6YyRbzwAScqFRsTswPCfpzS6+CQ/Dp17w== X-Received: by 2002:a1c:6006:: with SMTP id u6mr26009722wmb.111.1593607632721; Wed, 01 Jul 2020 05:47:12 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id o29sm7817862wra.5.2020.07.01.05.47.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2020 05:47:12 -0700 (PDT) From: Lee Jones To: ulf.hansson@linaro.org Subject: [PATCH 05/15] mmc: host: mtk-sd: Demote msdc_recheck_sdio_irq() function header Date: Wed, 1 Jul 2020 13:46:52 +0100 Message-Id: <20200701124702.908713-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200701124702.908713-1-lee.jones@linaro.org> References: <20200701124702.908713-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200701_084714_062699_B8A5EB6B X-CRM114-Status: GOOD ( 15.72 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:342 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Matthias Brugger , Lee Jones , Chaotian Jing Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org No other function in the file is documented using kerneldoc and no effort to document the function arguments have been made. It's a bit of an oddity to say the least. Let's downgrade it from kerneldoc to a standard comment block instead. Fixes the following W=1 kernel build warning: drivers/mmc/host/mtk-sd.c:1030: warning: Function parameter or member 'host' not described in 'msdc_recheck_sdio_irq' Cc: Chaotian Jing Cc: Matthias Brugger Cc: linux-mediatek@lists.infradead.org Signed-off-by: Lee Jones Reviewed-by: Matthias Brugger --- drivers/mmc/host/mtk-sd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c index 39e7fc54c438f..49ac802ebbfeb 100644 --- a/drivers/mmc/host/mtk-sd.c +++ b/drivers/mmc/host/mtk-sd.c @@ -1018,13 +1018,12 @@ static int msdc_auto_cmd_done(struct msdc_host *host, int events, return cmd->error; } -/** +/* * msdc_recheck_sdio_irq - recheck whether the SDIO irq is lost * * Host controller may lost interrupt in some special case. * Add SDIO irq recheck mechanism to make sure all interrupts * can be processed immediately - * */ static void msdc_recheck_sdio_irq(struct msdc_host *host) {