From patchwork Wed Jul 1 12:46:53 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11636255 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3C801913 for ; Wed, 1 Jul 2020 12:49:47 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 13DFB20702 for ; Wed, 1 Jul 2020 12:49:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OzJ6k/Jh"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ya78GGdR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 13DFB20702 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BAyFDK+uQimM/ZZsQnDTKJJjPaAEeYncIiqSwY0GaBk=; b=OzJ6k/JhoFXFmPRE8+9dmhGEX 7ePijC9uayy5YpJD59bI832yUVYCB6946Cs+j7ZNB6Cz4mMP4SCSAzy4B5v93sMOQ2xic9okRw9Tl 2qZnMIQrxP4NFa4TNgUb9MZiXsvIxkIPcwd+Pyvj6ECLimFSEMgspGkrejKsUYULRlJUBd6kg8G2k H58xLQ4m/7eVm1BtNuB1c8sAKQLECAz1ivyL0UWcectH8eHO3u2sY8q8l5I7CUU+FXEALPve6QPkQ L0rwqSgKv7nOSPU/A1+IfzQ+hs8YlhIKHwIRHRJpkysz/AU17yyYVZ/hJ7bh/aJOqC/NKbXppb3+f FzshVCfJw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqc9J-00051a-RO; Wed, 01 Jul 2020 12:47:37 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqc8y-0004rU-22 for linux-arm-kernel@lists.infradead.org; Wed, 01 Jul 2020 12:47:17 +0000 Received: by mail-wr1-x443.google.com with SMTP id r12so23600394wrj.13 for ; Wed, 01 Jul 2020 05:47:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4HmkZgMMnNokIcxpC5qsgSTpETcgy+guvTGIOYd3vjA=; b=ya78GGdRIDBQGK8B84BfpjUHk69NCx0tP8mmoMldCAn5FHcrT/VhqMAXQF6V/OVicR FMY6bg9H1UVELQAZDu4fCvqgDKIKWO4S9wzT4m3AteUDzvlZOK4/MtjhiCd+KXmKMb1L F1TtQ/2H7zYbSMx2RxkB8Qz1Gr21YJj+SLdsFpOqYnZSQUbS93IXbdEXgX9sf6HweKB0 TNVjzis0NXV8fJMHzzSeFbiEixlXlbJBV2nY8NiHHWlwBss2KBdZAh0ig6sPaccKPpN9 +cviagir9w82XUTR6EHMNr+NxvILSikRpvq1WwLaBLKCHbd8OhUghVvGmfhwHjUneWS0 WzGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4HmkZgMMnNokIcxpC5qsgSTpETcgy+guvTGIOYd3vjA=; b=Bitxnyf56ZcjCgmKlTcp2L8stcloy191W/tycmsCwgP/EpcrEPpF14xPOx0oSw25WC fLWSd75p5znUqp1B0Dr/Mn1qXGIJNHJ//vupsNIfPUAXDEmUvO9nwRXStoYgxPFCR863 pkJBi+g0fk4dy/Gf7YZlD2mR8agwSllFn2gkCnSyK7xFUrDO4loXi4SuuXxWy/eSjLWT aGyMnwu2NvSv5lpXSl4rZzcNn4lnmr3/ElcAhHoi4iXLkQjAzNXbiOW3R2BFMY5y8bgr lF3Y9qYkUtcMzN/SZe1/rRxOslus3UNIx213a/SEiVZFAMu//ZkD65LQs+j+GRLLrZo2 SrUA== X-Gm-Message-State: AOAM532EI2x574AIi7SjAPioGnAhwoX4UCwUK2hi3wyHuOe1dApcownH uxQOgSoxm7jdZCnFg7KSSJekfQ== X-Google-Smtp-Source: ABdhPJx5sdyemoJCIEKPCxf8WbgcrVsCh6V9mQezCi/IiAds/ZoliLC+HT1ZY95I0UsHrI8WiYDixg== X-Received: by 2002:adf:ecce:: with SMTP id s14mr26836949wro.154.1593607633908; Wed, 01 Jul 2020 05:47:13 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id o29sm7817862wra.5.2020.07.01.05.47.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2020 05:47:13 -0700 (PDT) From: Lee Jones To: ulf.hansson@linaro.org Subject: [PATCH 06/15] mmc: host: atmel-mci: Provide 2 new and correct 1 existing property description Date: Wed, 1 Jul 2020 13:46:53 +0100 Message-Id: <20200701124702.908713-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200701124702.908713-1-lee.jones@linaro.org> References: <20200701124702.908713-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200701_084716_348012_C5F74D90 X-CRM114-Status: GOOD ( 15.00 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:443 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , linux-kernel@vger.kernel.org, Ludovic Desroches , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org 'sg_len' and 'dma_conf' are missing correct kerneldoc documentation and 'buf_phys_addr' was misspelled. Correcting these issues fixes the following W=1 kernel build issues: mmc/host/atmel-mci.c:352: warning: Function parameter or member 'sg_len' not described in 'atmel_mci' mmc/host/atmel-mci.c:352: warning: Function parameter or member 'buf_phys_addr' not described in 'atmel_mci' mmc/host/atmel-mci.c:352: warning: Function parameter or member 'dma_conf' not described in 'atmel_mci' Cc: Ludovic Desroches Cc: Nicolas Ferre Cc: Alexandre Belloni Signed-off-by: Lee Jones --- drivers/mmc/host/atmel-mci.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c index 5cb6926876981..300901415aa20 100644 --- a/drivers/mmc/host/atmel-mci.c +++ b/drivers/mmc/host/atmel-mci.c @@ -225,12 +225,13 @@ struct atmel_mci_dma { * @lock: Spinlock protecting the queue and associated data. * @regs: Pointer to MMIO registers. * @sg: Scatterlist entry currently being processed by PIO or PDC code. + * @sg_len: Size of the scatterlist * @pio_offset: Offset into the current scatterlist entry. * @buffer: Buffer used if we don't have the r/w proof capability. We * don't have the time to switch pdc buffers so we have to use only * one buffer for the full transaction. * @buf_size: size of the buffer. - * @phys_buf_addr: buffer address needed for pdc. + * @buf_phys_addr: buffer address needed for pdc. * @cur_slot: The slot which is currently using the controller. * @mrq: The request currently being processed on @cur_slot, * or NULL if the controller is idle. @@ -240,6 +241,7 @@ struct atmel_mci_dma { * @data_size: just data->blocks * data->blksz. * @dma: DMA client state. * @data_chan: DMA channel being used for the current data transfer. + * @dma_conf: Configuration for the DMA slave * @cmd_status: Snapshot of SR taken upon completion of the current * command. Only valid when EVENT_CMD_COMPLETE is pending. * @data_status: Snapshot of SR taken upon completion of the current