From patchwork Thu Jul 2 14:46:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11639177 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1A42D13B4 for ; Thu, 2 Jul 2020 14:50:45 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E69E520771 for ; Thu, 2 Jul 2020 14:50:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="aYz5jiTW"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="A7SXqjqr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E69E520771 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=sBl7NoCiblvntTI5flo/LpAwppC56cEl9/LvI9BEsnM=; b=aYz5jiTWzDhIfzzDuM/MMQcAa xtZQAjnnt3mw2ckVgTkkerojLHS+B3wpAm8FYYSJfpDHpS6ylnX64LdpB3DQxXmkEYwDbV61N0l7y +IwyN3QN5QheIP6PCM83ELUaaG+0PKHXq/+DdQQwoi8Iz/KLRr9bBtEmUwQUstcf/oBwPXjVZcqLH hDQ7uvk5zHDdo4QaB/HvdX/sBgAbpktgmZEgw5WggwmOKmfvVpE7jp9OW6OlhInQL1jzIzxyGGaak 7+9WTQVGagMaoh0FjeKXaI208EX3o2Or88lJUd1oA5osTZGMHTRkVaLgs/Q0i9OXlqqWbGIwgVYw5 D+vcoIQWg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jr0Vj-0006BF-U4; Thu, 02 Jul 2020 14:48:23 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jr0UA-0005Hd-Mn for linux-arm-kernel@lists.infradead.org; Thu, 02 Jul 2020 14:46:49 +0000 Received: by mail-wm1-x342.google.com with SMTP id w3so15822654wmi.4 for ; Thu, 02 Jul 2020 07:46:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=sONund+v6m72UXA2k3mTvsnzOlUrvp8LHJR6S/5dS2c=; b=A7SXqjqrCM16AVWVbtxBs+8Q7KGVv5itBId7jsXn1AHLh3Veja6uzD8SFiMxl2t4vW rRF59UeX210MC4awzP8qxatLAoLaTqe+g6NZB5Y9eStTCYo9NLjEoQKDNzzXMjoXbeok CiVBADgITsgHMUKr55N6uCwjVEVtVYDES7xmS/ui20fUJ1IbAEhYec63OQgoF1LafLc0 5SV9rFD21yf03RMLcybreux5P78eLRfpg6B+F6tQv7FYQOagpviBnjHwu0Pw0RRSZyfX jlsCnKv9/Ig3pejOEJF3CzbQdz/Ab06ku9zTCfDTG3urmvKVx1uSkSnq22manAl0mLN8 eTtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=sONund+v6m72UXA2k3mTvsnzOlUrvp8LHJR6S/5dS2c=; b=J+5GQRXFlghxDceJzjFMyF5B7S2WGMXMqrG9Vnv7rbKZln0oKOnOYMlF5NngTfdShy ARXukfB6bnxXeKro/NRhuyi2QkRncetC+u2B4rTDZkIlQKIxAZ2oAd12/NBceDjhebhR NSjlwy57lQp/ny93OevDGZByBrUcrswD6M2+dyZjjMrueHsaCpY1G4cpxV8+CK4ynZwl GkTOnzcMa13yoHPxQ9gVWxL7AKFqm346UtR3xFjJBDSraAicMNIpRaWoksRta8ifjzMa v4O8sbDWycRDvHzw9/295vaqmgkcxVejlEZfZlyOTgEoxTqCHQB/ob4kJNfkyxJdad2w Oo4g== X-Gm-Message-State: AOAM530WxQJJtfwlpGqX04S+qu4R49hEKqlxslGuAP9eAiX+Po5ljSiy iie50EULycKC6Sx/usuSbE3CDQ== X-Google-Smtp-Source: ABdhPJzRi4BPfjzXaW8qFukfmFtIxWbM/JfxYDBuDyf0+vYOnyYhbkx/MYyV1XQriU0Sd2wBnDG/MA== X-Received: by 2002:a1c:b4c2:: with SMTP id d185mr30552073wmf.57.1593701204872; Thu, 02 Jul 2020 07:46:44 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id g14sm7002737wrw.83.2020.07.02.07.46.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2020 07:46:43 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Subject: [PATCH 10/30] usb: dwc2: gadget: Remove assigned but never used 'maxsize' Date: Thu, 2 Jul 2020 15:46:05 +0100 Message-Id: <20200702144625.2533530-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200702144625.2533530-1-lee.jones@linaro.org> References: <20200702144625.2533530-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200702_104647_969725_B34A391D X-CRM114-Status: GOOD ( 12.93 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:342 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Ben Dooks , Minas Harutyunyan , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org The value of 'maxsize' has not been checked since commit 729cac693eecf ("usb: dwc2: Change ISOC DDMA flow") back in 2018, so remove the set but unused variable, which fixes the following W=1 kernel build warning: drivers/usb/dwc2/gadget.c: In function ‘dwc2_gadget_fill_isoc_desc’: drivers/usb/dwc2/gadget.c:885:6: warning: variable ‘maxsize’ set but not used [-Wunused-but-set-variable] 885 | u32 maxsize = 0; | ^~~~~~~ Cc: Minas Harutyunyan Cc: Ben Dooks Signed-off-by: Lee Jones --- drivers/usb/dwc2/gadget.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c index 14c422ee6a069..116e6175c7a48 100644 --- a/drivers/usb/dwc2/gadget.c +++ b/drivers/usb/dwc2/gadget.c @@ -880,11 +880,10 @@ static int dwc2_gadget_fill_isoc_desc(struct dwc2_hsotg_ep *hs_ep, struct dwc2_dma_desc *desc; struct dwc2_hsotg *hsotg = hs_ep->parent; u32 index; - u32 maxsize = 0; u32 mask = 0; u8 pid = 0; - maxsize = dwc2_gadget_get_desc_params(hs_ep, &mask); + dwc2_gadget_get_desc_params(hs_ep, &mask); index = hs_ep->next_desc; desc = &hs_ep->desc_list[index];