diff mbox series

[06/14] drivers/firmware/sdei: Drop redundant error message in sdei_probe()

Message ID 20200706054732.99387-7-gshan@redhat.com (mailing list archive)
State New, archived
Headers show
Series Refactor SDEI client driver | expand

Commit Message

Gavin Shan July 6, 2020, 5:47 a.m. UTC 
This drops the redundant error message in sdei_probe() because the
situation can be indicated by the error number from next error
message.

The function scoped variables are reorder according to their
importance by the way.

Signed-off-by: Gavin Shan <gshan@redhat.com>
---
 drivers/firmware/arm_sdei.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
diff mbox series

Patch

diff --git a/drivers/firmware/arm_sdei.c b/drivers/firmware/arm_sdei.c
index ca0e3f5eb907..28bc712ba71d 100644
--- a/drivers/firmware/arm_sdei.c
+++ b/drivers/firmware/arm_sdei.c
@@ -935,17 +935,15 @@  int sdei_unregister_ghes(struct ghes *ghes)
 
 static int sdei_probe(struct platform_device *pdev)
 {
-	int err;
-	u64 ver = 0;
 	int conduit;
+	u64 ver = 0;
+	int err;
 
 	conduit = acpi_psci_use_hvc() ? SMCCC_CONDUIT_HVC : SMCCC_CONDUIT_SMC;
 	sdei_firmware_call = acpi_psci_use_hvc() ?
 			     &sdei_smccc_hvc : &sdei_smccc_smc;
 
 	err = sdei_api_get_version(&ver);
-	if (err == -EOPNOTSUPP)
-		pr_err("advertised but not implemented in platform firmware\n");
 	if (err) {
 		pr_err("Failed to get SDEI version: %d\n", err);
 		sdei_mark_interface_broken();