From patchwork Tue Jul 7 10:16:26 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11648177 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B0D4314B7 for ; Tue, 7 Jul 2020 10:21:02 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5CC0120702 for ; Tue, 7 Jul 2020 10:21:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="HB00UO4i"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="QsQNaqhx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5CC0120702 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=M29alqmAnyfbEk3lH11ZJ/9CXz86BbW3Jd5Yj97pLpk=; b=HB00UO4idmnE3DIJNIGo5znUR uCKvj9Yt6U9YspCU2HRui+yAsrR/Ncu7KPuwibsnbjgIMuOmjYMWTzrZYc2UDm8e4SsJJA1xXZrJO nLXElogd+sIoD8jYN50HHQgfJdip0mrGxYZp+1mmd7Z0U3q2TFjLsrLE0jNcPIukayI4Jc3InzUd1 abGtM+9BUPPVoG+hwAnPqqV5R9uHGldWj5irLx4xJwImY0Y5WcfQqT3XTeGRHMnGzCp9MGvYdoLXE dBN8JJUJ0CcQ6gdoYRVyqKoLUudF3zovCQrzNbIidKJKFcWyM7Mpr0kJ75d3eVU3XgNbOk9oESibE PjaHEsDJg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jskgj-00054r-FR; Tue, 07 Jul 2020 10:18:57 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jskeu-0004AH-CO for linux-arm-kernel@lists.infradead.org; Tue, 07 Jul 2020 10:17:05 +0000 Received: by mail-wm1-x343.google.com with SMTP id f139so45916047wmf.5 for ; Tue, 07 Jul 2020 03:17:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+qKCC8gwbOOqZ6yEPkGSkmGeka7mYOZ7iXEWMftP650=; b=QsQNaqhxkVtL41tk1/qoGhyCm7rVJ4vpnlgVliFcwROlzr/daTSEoku3cq8UN82fQX IFbaFWVeeLZZcbS0019ujgPja2Nu5gkt/1krAFAUnVatnIx3B91JzL5kGlJDfics0Pav uL9Yr8HgEPEpP24WORMxYPT+RLeq0riRndWjJeO/uU4y0oO+r4jt9Ig0R0Pk8DMQcv7z rp4u8MT93nqSXy9KYnhrdA+GBJiH2sAaOi/Dy/QKPlv0PunseCYqkvxjRt83mLjFcW6Z alULEaJtZv8pRcmMemxrm7hMHD0NKnLzelBD/xb4HTuKiZ/wncZ/jnlVrwAmV3VlLCjX FiKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+qKCC8gwbOOqZ6yEPkGSkmGeka7mYOZ7iXEWMftP650=; b=ZU+VM7uw36RHIj51OcwJUdSKGTs8HpDydn5qHGlHihQgHQ2AK/CGQwCGPCyRkkxOxM 0RTfwqa0WQ7I1leSYa0tuh6HbGL1oOs4GPXUS4JiLuab1Tq3e/vKM5LfShlxQCMNwqqu SFmPHjesX5KcF5TNwcltYRPm/1IIEDCNvJHSk7D3xDB98vUK2/wzHYFpRRssHbjHhgNw WcMTq9zEqeeERjon5unNCoSjtZSyrIZyB2Nxhl0ERji2jKnAW7Xl3RWdIFBHa7SmPQig JqmPqW2CpsnqqNkKop7OyxuREO7yo8hcOlgb5oMc1fh6Jq3hUf8MWmoe8CGjmTJJ8MxW 2Xwg== X-Gm-Message-State: AOAM532TLOlRkRG8xUSPU1nJksaREmXbNuhWMddkOaKLFgZxn4Q4E0KX wDrP2k08BSJhUUOlxGT96qN1hg== X-Google-Smtp-Source: ABdhPJx1ZbuUA9wWKqxxF1IHrewdkfGEfSuRE8l+gQGgDf17uueoN0ReeFhO3RmeiPsig4/tbI5/XQ== X-Received: by 2002:a1c:e143:: with SMTP id y64mr3375157wmg.90.1594117023297; Tue, 07 Jul 2020 03:17:03 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id z8sm469409wmg.39.2020.07.07.03.17.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 03:17:02 -0700 (PDT) From: Lee Jones To: broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com Subject: [PATCH 12/28] ASoC: codecs: ak4458: Remove set but never checked variable 'ret' Date: Tue, 7 Jul 2020 11:16:26 +0100 Message-Id: <20200707101642.1747944-13-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200707101642.1747944-1-lee.jones@linaro.org> References: <20200707101642.1747944-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200707_061704_489935_6FA77CF6 X-CRM114-Status: GOOD ( 12.18 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:343 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, Kuninori Morimoto , linux-kernel@vger.kernel.org, Junichi Wakasugi , Mihai Serban , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Looks as though the result of snd_soc_update_bits() has never been checked. Fixes the following W=1 kernel build warning(s): sound/soc/codecs/ak4458.c: In function ‘ak4458_set_dai_mute’: sound/soc/codecs/ak4458.c:408:16: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] Cc: Kuninori Morimoto Cc: Junichi Wakasugi Cc: Mihai Serban Signed-off-by: Lee Jones --- sound/soc/codecs/ak4458.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/soc/codecs/ak4458.c b/sound/soc/codecs/ak4458.c index f180cb5dfe4f1..39ae089dcd1d8 100644 --- a/sound/soc/codecs/ak4458.c +++ b/sound/soc/codecs/ak4458.c @@ -405,7 +405,7 @@ static int ak4458_set_dai_mute(struct snd_soc_dai *dai, int mute) { struct snd_soc_component *component = dai->component; struct ak4458_priv *ak4458 = snd_soc_component_get_drvdata(component); - int nfs, ndt, ret, reg; + int nfs, ndt, reg; int ats; nfs = ak4458->fs; @@ -416,14 +416,14 @@ static int ak4458_set_dai_mute(struct snd_soc_dai *dai, int mute) ndt = att_speed[ats] / (nfs / 1000); if (mute) { - ret = snd_soc_component_update_bits(component, AK4458_01_CONTROL2, 0x01, 1); + snd_soc_component_update_bits(component, AK4458_01_CONTROL2, 0x01, 1); mdelay(ndt); if (ak4458->mute_gpiod) gpiod_set_value_cansleep(ak4458->mute_gpiod, 1); } else { if (ak4458->mute_gpiod) gpiod_set_value_cansleep(ak4458->mute_gpiod, 0); - ret = snd_soc_component_update_bits(component, AK4458_01_CONTROL2, 0x01, 0); + snd_soc_component_update_bits(component, AK4458_01_CONTROL2, 0x01, 0); mdelay(ndt); }