diff mbox series

arm64: Add missing sentinel to erratum_1463225

Message ID 20200709051345.14544-1-f.fainelli@gmail.com (mailing list archive)
State Mainlined
Commit 09c717c92b52df54918e12cbfe6a4658233fda69
Headers show
Series arm64: Add missing sentinel to erratum_1463225 | expand

Commit Message

Florian Fainelli July 9, 2020, 5:13 a.m. UTC
When the erratum_1463225 array was introduced a sentinel at the end was
missing thus causing a KASAN: global-out-of-bounds in
is_affected_midr_range_list on arm64 error.

Link: https://lore.kernel.org/linux-arm-kernel/CA+G9fYs3EavpU89-rTQfqQ9GgxAMgMAk7jiiVrfP0yxj5s+Q6g@mail.gmail.com/
Fixes: a9e821b89daa ("arm64: Add KRYO4XX gold CPU cores to erratum list 1463225 and 1418040")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
 arch/arm64/kernel/cpu_errata.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Sai Prakash Ranjan July 9, 2020, 5:21 a.m. UTC | #1
Hi Florian,

On 2020-07-09 10:43, Florian Fainelli wrote:
> When the erratum_1463225 array was introduced a sentinel at the end was
> missing thus causing a KASAN: global-out-of-bounds in
> is_affected_midr_range_list on arm64 error.
> 
> Link:
> https://lore.kernel.org/linux-arm-kernel/CA+G9fYs3EavpU89-rTQfqQ9GgxAMgMAk7jiiVrfP0yxj5s+Q6g@mail.gmail.com/
> Fixes: a9e821b89daa ("arm64: Add KRYO4XX gold CPU cores to erratum
> list 1463225 and 1418040")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
>  arch/arm64/kernel/cpu_errata.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/kernel/cpu_errata.c 
> b/arch/arm64/kernel/cpu_errata.c
> index 8e302dc093d0..79728bfb5351 100644
> --- a/arch/arm64/kernel/cpu_errata.c
> +++ b/arch/arm64/kernel/cpu_errata.c
> @@ -782,6 +782,7 @@ static const struct midr_range erratum_1463225[] = 
> {
>  	MIDR_RANGE(MIDR_CORTEX_A76, 0, 0, 3, 1),
>  	/* Kryo4xx Gold (rcpe to rfpf) => (r0p0 to r3p1) */
>  	MIDR_RANGE(MIDR_QCOM_KRYO_4XX_GOLD, 0xc, 0xe, 0xf, 0xf),
> +	{},
>  };
>  #endif

My bad missing this, thanks for the fix.

Reviewed-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
Will Deacon July 9, 2020, 9:54 a.m. UTC | #2
On Wed, 8 Jul 2020 22:13:40 -0700, Florian Fainelli wrote:
> When the erratum_1463225 array was introduced a sentinel at the end was
> missing thus causing a KASAN: global-out-of-bounds in
> is_affected_midr_range_list on arm64 error.

Applied to arm64 (for-next/fixes), thanks!

[1/1] arm64: Add missing sentinel to erratum_1463225
      https://git.kernel.org/arm64/c/09c717c92b52

Cheers,
diff mbox series

Patch

diff --git a/arch/arm64/kernel/cpu_errata.c b/arch/arm64/kernel/cpu_errata.c
index 8e302dc093d0..79728bfb5351 100644
--- a/arch/arm64/kernel/cpu_errata.c
+++ b/arch/arm64/kernel/cpu_errata.c
@@ -782,6 +782,7 @@  static const struct midr_range erratum_1463225[] = {
 	MIDR_RANGE(MIDR_CORTEX_A76, 0, 0, 3, 1),
 	/* Kryo4xx Gold (rcpe to rfpf) => (r0p0 to r3p1) */
 	MIDR_RANGE(MIDR_QCOM_KRYO_4XX_GOLD, 0xc, 0xe, 0xf, 0xf),
+	{},
 };
 #endif