| Message ID | 20200709105902.23165-3-peter.chen@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/4] doc: dt-binding: ci-hdrc-usb2: add property for imx picophy | expand |
On Thu, Jul 09, 2020 at 06:59:01PM +0800, Peter Chen wrote: > With these two parameters tuning, it can pass USB eye diagram at evk board. > > Reviewed-by: Jun Li <jun.li@nxp.com> > Signed-off-by: Peter Chen <peter.chen@nxp.com> It's not so consistent, but idiomatically we prefix arm i.MX platform/dts patches like 'ARM: ...', but 'arm64: ...' for arm64 ones. Also with 'imx8mm-evk' in prefix, it's good enough to know this is fsl/imx patch, so I suggest prefix like: 'arm64: dts: imx8mm-evk: ...' Shawn > --- > arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts > index 0f1d7f8aeac4..c432b628e1ed 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts > @@ -324,6 +324,8 @@ > srp-disable; > adp-disable; > usb-role-switch; > + picophy,pre-emp-curr-control = <3>; > + picophy,dc-vol-level-adjust = <7>; > status = "okay"; > > port { > -- > 2.17.1 >
> > Reviewed-by: Jun Li <jun.li@nxp.com> > > Signed-off-by: Peter Chen <peter.chen@nxp.com> > > It's not so consistent, but idiomatically we prefix arm i.MX platform/dts patches like > 'ARM: ...', but 'arm64: ...' for arm64 ones. > Also with 'imx8mm-evk' in prefix, it's good enough to know this is fsl/imx patch, so I > suggest prefix like: > > 'arm64: dts: imx8mm-evk: ...' > Thanks, will change. Peter
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts index 0f1d7f8aeac4..c432b628e1ed 100644 --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts @@ -324,6 +324,8 @@ srp-disable; adp-disable; usb-role-switch; + picophy,pre-emp-curr-control = <3>; + picophy,dc-vol-level-adjust = <7>; status = "okay"; port {