From patchwork Tue Jul 14 11:15:36 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11662385 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 259D013B4 for ; Tue, 14 Jul 2020 11:19:02 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8227422208 for ; Tue, 14 Jul 2020 11:19:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LntLdF95"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lRnHD6+n" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8227422208 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=sHKEvyLnD/E6SV7TlkKfRSfIFRGrLXkr5MBA6p2iJc0=; b=LntLdF95MXJUGW1i8v3WyyCVY iqWf+Iq+748H5siQjecC3hlwrdOL05TaOwTQ55elW/fi/9SmgYOeA9SnrVIDD7gL1RvuCIAxEC0VZ fnNnYiEYH27kk0HwplgN4JCDAYewRyD3sCMcolTfjXzyk4x/1kFl3w5mwuzfxfhk/xiGA+4epYLn7 di7Q3pk8ox4s3mv5FbU+5cecTAoTn8ioAPcmMwOs7ooAODmkQ8060RXYGrvsyFmdjaQtz6ZXRbI4D MmHAtvVrCCdvR0at0kLv07u9iZXs9ssgjWyYZa2qgdK2TW/q6mspvEefQQKGHyppb58fBpmI7ItDc 2rPyK152g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvIvg-0003tS-Gp; Tue, 14 Jul 2020 11:16:56 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvIuk-0003Sr-6V for linux-arm-kernel@lists.infradead.org; Tue, 14 Jul 2020 11:16:02 +0000 Received: by mail-wr1-x441.google.com with SMTP id o11so20920447wrv.9 for ; Tue, 14 Jul 2020 04:15:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xDspo//ZGGv62/k8vhH8b8dLXko1WA1DYqLJUY7Z0pU=; b=lRnHD6+n0Kjyezcw88EVB0+8py6DiaAYhCbxlABYw2m8o9Zqwb0e0UYsTQn6UzdoyM Ai/Lwf+avt/HMmYhCR2/TG+yz4ONmkQc2lUl56ky4FIDgvtg1bdsR8ab93IYufj3BDun i0WFD7NuGJNJDoZQohH34gqSOOdzQKa+D1J8sCzkxCvJV+Jwbn1/J2Scn0vFBzHdFMU4 yHlh6N9RzslpQaPG35aqpOqxYCtYF2Q9jqYGfdLmmosobj45f6BOMGXsaHWrN8m60dsA vBG+Cnm/FE0W+t1lyKdF9znSpMDeukw6cl5PVzqvlV6+4bcIri+v2g7Y5SvFnTWu1qFI jtFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xDspo//ZGGv62/k8vhH8b8dLXko1WA1DYqLJUY7Z0pU=; b=HSj/j2Y7YSutNILktm+fh5priUwmkFpW4ojnrs8DO9yAYHe8KG3diPxCAT48I91/oY JVNACC5f1FRzh+uEpjjslTVeYIw5nDsKJCnKCtksPJkB7wgHJGFAZwCnxFUhUH6ICq6C ebbwDK0HD9R6Com8iN5BGs312qiyEZWhffzBd2bmnrL3DSV4b4imIJfY45mGAmNGZrTo yvl/PlWxds0+9Z7tzROeTmsU6Gmu5rbupHNj7ve7rTv9gz8BnN9dhnVNfbxOz10NHQp9 4z0p4HSTOaDMBfqRlpXo/Byp7bY9DbjkuAYX4zG1X3q9eGDFOXyShtAZjdyW3Y9pWM3e ahaQ== X-Gm-Message-State: AOAM533vC15uqJOGaj4wiDEnlVWH13D8iOyopTwGV0mwZO59ailzFePM H7FaWzSpvYwmYID9zOZPtoZz7w== X-Google-Smtp-Source: ABdhPJzIzSvAOB3xgad3Sen6dlJzxBYaenPpru9T4eTefZSfzMtOdkfpSmMn9BuJRx6p9P4nOKO/4A== X-Received: by 2002:a5d:6a90:: with SMTP id s16mr4580377wru.8.1594725357328; Tue, 14 Jul 2020 04:15:57 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id l8sm28566052wrq.15.2020.07.14.04.15.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 04:15:56 -0700 (PDT) From: Lee Jones To: dan.j.williams@intel.com, vkoul@kernel.org Subject: [PATCH 07/17] dma: altera-msgdma: Fix struct documentation blocks Date: Tue, 14 Jul 2020 12:15:36 +0100 Message-Id: <20200714111546.1755231-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200714111546.1755231-1-lee.jones@linaro.org> References: <20200714111546.1755231-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200714_071558_347896_535A704F X-CRM114-Status: GOOD ( 13.05 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:441 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dmaengine@vger.kernel.org, Stefan Roese , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Fix some misspelling/description issues, demote non-kerneldoc header to standard comment block and provide a new description for msgdma_desc_config()'s 'stride' parameter. Fixes the following W=1 kernel build warning(s): drivers/dma/altera-msgdma.c:163: warning: Function parameter or member 'node' not described in 'msgdma_sw_desc' drivers/dma/altera-msgdma.c:163: warning: Function parameter or member 'tx_list' not described in 'msgdma_sw_desc' drivers/dma/altera-msgdma.c:197: warning: Function parameter or member 'lock' not described in 'msgdma_device' drivers/dma/altera-msgdma.c:197: warning: Function parameter or member 'dev' not described in 'msgdma_device' drivers/dma/altera-msgdma.c:197: warning: Function parameter or member 'irq_tasklet' not described in 'msgdma_device' drivers/dma/altera-msgdma.c:197: warning: Function parameter or member 'pending_list' not described in 'msgdma_device' drivers/dma/altera-msgdma.c:197: warning: Function parameter or member 'free_list' not described in 'msgdma_device' drivers/dma/altera-msgdma.c:197: warning: Function parameter or member 'active_list' not described in 'msgdma_device' drivers/dma/altera-msgdma.c:197: warning: Function parameter or member 'done_list' not described in 'msgdma_device' drivers/dma/altera-msgdma.c:197: warning: Function parameter or member 'desc_free_cnt' not described in 'msgdma_device' drivers/dma/altera-msgdma.c:197: warning: Function parameter or member 'idle' not described in 'msgdma_device' drivers/dma/altera-msgdma.c:197: warning: Function parameter or member 'dmadev' not described in 'msgdma_device' drivers/dma/altera-msgdma.c:197: warning: Function parameter or member 'dmachan' not described in 'msgdma_device' drivers/dma/altera-msgdma.c:197: warning: Function parameter or member 'hw_desq' not described in 'msgdma_device' drivers/dma/altera-msgdma.c:197: warning: Function parameter or member 'sw_desq' not described in 'msgdma_device' drivers/dma/altera-msgdma.c:197: warning: Function parameter or member 'npendings' not described in 'msgdma_device' drivers/dma/altera-msgdma.c:197: warning: Function parameter or member 'slave_cfg' not described in 'msgdma_device' drivers/dma/altera-msgdma.c:197: warning: Function parameter or member 'irq' not described in 'msgdma_device' drivers/dma/altera-msgdma.c:197: warning: Function parameter or member 'csr' not described in 'msgdma_device' drivers/dma/altera-msgdma.c:197: warning: Function parameter or member 'desc' not described in 'msgdma_device' drivers/dma/altera-msgdma.c:197: warning: Function parameter or member 'resp' not described in 'msgdma_device' drivers/dma/altera-msgdma.c:265: warning: Function parameter or member 'stride' not described in 'msgdma_desc_config' Cc: Stefan Roese Signed-off-by: Lee Jones Reviewed-by: Stefan Roese --- drivers/dma/altera-msgdma.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/dma/altera-msgdma.c b/drivers/dma/altera-msgdma.c index 539e785039cac..321ac3a7aa418 100644 --- a/drivers/dma/altera-msgdma.c +++ b/drivers/dma/altera-msgdma.c @@ -153,7 +153,8 @@ struct msgdma_extended_desc { * struct msgdma_sw_desc - implements a sw descriptor * @async_tx: support for the async_tx api * @hw_desc: assosiated HW descriptor - * @free_list: node of the free SW descriprots list + * @node: node to move from the free list to the tx list + * @tx_list: transmit list node */ struct msgdma_sw_desc { struct dma_async_tx_descriptor async_tx; @@ -162,7 +163,7 @@ struct msgdma_sw_desc { struct list_head tx_list; }; -/** +/* * struct msgdma_device - DMA device structure */ struct msgdma_device { @@ -258,6 +259,7 @@ static void msgdma_free_desc_list(struct msgdma_device *mdev, * @dst: Destination buffer address * @src: Source buffer address * @len: Transfer length + * @stride: Read/write stride value to set */ static void msgdma_desc_config(struct msgdma_extended_desc *desc, dma_addr_t dst, dma_addr_t src, size_t len,