From patchwork Wed Jul 15 15:06:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11665717 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2C66313B1 for ; Wed, 15 Jul 2020 15:10:05 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DD38A20658 for ; Wed, 15 Jul 2020 15:10:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="htgKyABK"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="UyEhMAjQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD38A20658 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=igBL3TFzHerrDgkKYlzoZs9RLe4gVkM/4ywK+7HVsdw=; b=htgKyABKnjmC9zpgpW+JSnejw hcGiPavFrlhiCNlJZDXhcTYP2X9Dux6rIuKcOmLFfHIrJmP0VTftP0NiN5X07t+cy8lYx2MFsiBy4 8JQfAAFfpV4SmENEbLe46MkX+PKiHAy9qlfpAaN8pyB8kOJw0reBzGIZI0o8dQJjDATCYKOvW4XPr 9d5zjyh3rtcZX9J19tqlvpinIV6nfi8yUEQBGbaKOx8xBkOAqW0hRxu4orWu6r1Lno/PnVa7D88q1 NaCv3P2MVuUhiBYv5dCN3TiG4ZIeXaQ/fcpbs35WbMOwtKJ2a8GwM/V0jJXLCv47Te4Z0c28A5AC8 AIvbbVcSw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvj0w-00071W-I4; Wed, 15 Jul 2020 15:08:06 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvizf-0006WB-J2 for linux-arm-kernel@lists.infradead.org; Wed, 15 Jul 2020 15:06:49 +0000 Received: by mail-wm1-x342.google.com with SMTP id l2so6191108wmf.0 for ; Wed, 15 Jul 2020 08:06:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=P2yOByTJ584zq87efhS3Vkyk+agE9qVyWq/sL4PYeIk=; b=UyEhMAjQjWz7s63ZoKbqZd0he72PbgcQoERVqZzfPDdeHfi76qTF2aqAKxzkw+vs8v 1ccaVDSAO4pCzQ94UQJrxVt/sheMgiPUXVzxym6vO5O3kTo9gbcNiNZVaVD1plMF0J3k z3yGisz15rp6uRZwbOTBwSS7WRG2WW4RYhT3UooUQ1/ByKSkNAp8xkJVJkMzDKEaz/uV dY1tnRfjmei2kZiknTPr5tnLNurtxkTSnbU4QVjMd/PG1AQFoIo5f4IX91KQdnkdhecL G0V3E7kPOXw89FXa9PIId9kyqYzc/kbEl6QHQn+6MHKgA350J1Dw6gHOjtOneOkfuyyM 4CgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=P2yOByTJ584zq87efhS3Vkyk+agE9qVyWq/sL4PYeIk=; b=dF8Xhtzjzl2WcE2oJW/pN/5HqWEBL3vx7azr9lv0tLjmM7devOFlF3S/KFPUkVgNv5 jPjQbwHgj0U2LPA2KOYpGNSLkVP7X65248Lp5EtNyWk4D71yFjm3JcHFeXsaK9VfIlk7 YliQp039swFYjJeOV5rVIa7lq0pyuDnScXYekoSAXtUO2lB4/JHpKa3AYmY9VwuHykQd bm9v+kVP0VbXfWPzh6qsJDSr8bTIXMG5UgDJ3Hw8O6hasyDffvnhpDOH6YPvTcWRAlZq QcHeG0wdC3nykGf863Rfhk9uT8gCzALhRWwx8DvRttGQyLh7f0oHDzCZRujhMpVZZr/t xXzQ== X-Gm-Message-State: AOAM533r7HNVezHj5gCSAnlGFmFruLSYmBzzB0EvuJUstol/WW4uT5D0 dw5XX3hGcpi3f1v1dholkjrY3Q== X-Google-Smtp-Source: ABdhPJx39xtrPHkcaKWFcDV25x4ysJFEnVveAGzGMS6sEEHSQ9JC+ALsZmBUt/eVdulx8vVh0d6eMQ== X-Received: by 2002:a1c:f609:: with SMTP id w9mr9114757wmc.150.1594825606599; Wed, 15 Jul 2020 08:06:46 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id w2sm3906140wrs.77.2020.07.15.08.06.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2020 08:06:45 -0700 (PDT) From: Lee Jones To: broonie@kernel.org Subject: [PATCH 09/14] spi: spi-zynq-qspi: Add description for 2 missing attributes/parameters Date: Wed, 15 Jul 2020 16:06:27 +0100 Message-Id: <20200715150632.409077-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200715150632.409077-1-lee.jones@linaro.org> References: <20200715150632.409077-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200715_110647_725061_342BBC63 X-CRM114-Status: GOOD ( 12.15 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:342 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michal Simek , linux-kernel@vger.kernel.org, Sureshkumar Relli , linux-spi@vger.kernel.org, Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Fixes the following W=1 kernel build warning(s): drivers/spi/spi-zynq-qspi.c:143: warning: Function parameter or member 'dev' not described in 'zynq_qspi' drivers/spi/spi-zynq-qspi.c:334: warning: Function parameter or member 'spi' not described in 'zynq_qspi_config_op' drivers/spi/spi-zynq-qspi.c:334: warning: Excess function parameter 'qspi' description in 'zynq_qspi_config_op' Cc: Michal Simek Cc: Sureshkumar Relli Signed-off-by: Lee Jones Acked-by: Michal Simek --- drivers/spi/spi-zynq-qspi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-zynq-qspi.c b/drivers/spi/spi-zynq-qspi.c index bbf3d90561f54..5d8a5ee62fa23 100644 --- a/drivers/spi/spi-zynq-qspi.c +++ b/drivers/spi/spi-zynq-qspi.c @@ -119,6 +119,7 @@ /** * struct zynq_qspi - Defines qspi driver instance + * @dev: Pointer to the this device's information * @regs: Virtual address of the QSPI controller registers * @refclk: Pointer to the peripheral clock * @pclk: Pointer to the APB clock @@ -316,7 +317,7 @@ static void zynq_qspi_chipselect(struct spi_device *spi, bool assert) /** * zynq_qspi_config_op - Configure QSPI controller for specified transfer * @xqspi: Pointer to the zynq_qspi structure - * @qspi: Pointer to the spi_device structure + * @spi: Pointer to the spi_device structure * * Sets the operational mode of QSPI controller for the next QSPI transfer and * sets the requested clock frequency.