From patchwork Thu Jul 16 13:59:18 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11667615 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7118E13A4 for ; Thu, 16 Jul 2020 14:07:29 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3926D207BC for ; Thu, 16 Jul 2020 14:07:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WmC1rA97"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ZAvEsaeF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3926D207BC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=VR0ZwW8xlcIpPDM3+6gdHyHhS8W6FDxCJE+9Mzv31wI=; b=WmC1rA97b96ula7tydU14QaaC x55Azr5foUjf8rETbzuoc4bW4HEBgyUnMhoHNIm16b/tQ7D1jOQC3MiwLjNc57EcowO+eDRIcPh1R aQ+QyqZDXnJ1UdlWAcHs84Rz6sEDPqRLdPogV19KntnTaA5w6KmgeYl6f1PLHVzvNvMJvuPY69Kr8 MNmswJPvme61zqPiVIbGUzV5S5WMiQjnbKRI0B6pxCoMIYxcg+hJk2Yil8BfEH1RI9rJDUVxTbn8I MMvC1TxaoDJD8cPIJcdtT/F+D1/d2hOzgozzLZyfR4xtX23fjFHC6yseG7O7FG8W3CaqnNBBUzM9X b8ycsmO6A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jw4Ty-0005am-Iz; Thu, 16 Jul 2020 14:03:33 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jw4QX-0003z4-S0 for linux-arm-kernel@lists.infradead.org; Thu, 16 Jul 2020 13:59:59 +0000 Received: by mail-wr1-x441.google.com with SMTP id f7so7214085wrw.1 for ; Thu, 16 Jul 2020 06:59:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1SUhdNLbgzPAWgw1RQZwdPTaqr6bugMt+fbr6rtma0A=; b=ZAvEsaeFkwq5GcgDYK+/9rJcCLF1cuHMRI3FgfRAhfFpy2lSpeAOVYuwnpiWnp0j/u sodd9cME6J+7QQLoK5/xcLsLofod4oprz+mrBGP59qMiTR052FLl2aEyPlxrSmqz2H/Z 7evmx8t3cXfDTu2Zib3ya9hwIeg8ndWeLJ0UcSwl8wB+vZHcD/ePhbibd7Bs+Bq0gdcx 9w0dFgkWDfV3gxs9rw0mDHIKpZd7wYTXUiXE1P6DYVjJbfWxQrJo6nGgDMWd4cSHsfh4 W460RnonrWkqaNjrv7vciSSLANEpDQCyy9BjJE/VYE2Oa7rRev585J4xrIiecbtPLnHU dqqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1SUhdNLbgzPAWgw1RQZwdPTaqr6bugMt+fbr6rtma0A=; b=qp+7fj/93QFjqjzeH65SnOwRtCuuNgn/PulIvVUf8RMC1uPSK2o3VseZFLL0YK1IrT 0locz2UZbfRXrY9IaUPn8UiKuEKgiNf0hJFdBlf/KEEjd3cffki85dPaMlrm+8LHFk+h NHtxCt5p9qWivGWJOpZ2nfvbn5SgmgzD/v8ExW19hvY2q8b/QNcqjPAgAWnb3wG+fQj4 cZLX6OQ2e6NV+6ZjiKVy98eOrwP6TtHuRZeqt5OKcb3HNjWwHeHtiCPWY8swIcEFjssK xKPaolYt3Uv8LIBMaxB97S3vuOBRgvZAjON0Dtyw2sHD+YsT135x5TONa3SOckrI/f1j xHzw== X-Gm-Message-State: AOAM532GMt+pPm41c9O+0JP0IlnEhrgSwhTr9Pq489Z+QtWWwwPAnaZO iRtjXsO47vpNlToBq0vI2Z2+7nU3V2E= X-Google-Smtp-Source: ABdhPJzmqEBOwvn53W4FP2sjwDCd5ej/MlGX+VNRjOmTyGRQcbKaLe3I4Ls1WV4amb5DWzEuFZxDGQ== X-Received: by 2002:a5d:4b45:: with SMTP id w5mr5010385wrs.4.1594907997025; Thu, 16 Jul 2020 06:59:57 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id x18sm9351001wrq.13.2020.07.16.06.59.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2020 06:59:56 -0700 (PDT) From: Lee Jones To: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net Subject: [PATCH 20/30] iio: dac: ad5446: Complete 'struct ad5446_state' doc and demote unworthy kerneldocs Date: Thu, 16 Jul 2020 14:59:18 +0100 Message-Id: <20200716135928.1456727-21-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200716135928.1456727-1-lee.jones@linaro.org> References: <20200716135928.1456727-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200716_095958_029281_8DC3DE98 X-CRM114-Status: GOOD ( 11.61 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:441 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-iio@vger.kernel.org, Michael Hennerich , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Fixes the following W=1 kernel build warning(s): drivers/iio/dac/ad5446.c:48: warning: Function parameter or member 'dev' not described in 'ad5446_state' drivers/iio/dac/ad5446.c:48: warning: Function parameter or member 'cached_val' not described in 'ad5446_state' drivers/iio/dac/ad5446.c:48: warning: Function parameter or member 'pwr_down_mode' not described in 'ad5446_state' drivers/iio/dac/ad5446.c:48: warning: Function parameter or member 'pwr_down' not described in 'ad5446_state' drivers/iio/dac/ad5446.c:48: warning: Function parameter or member 'lock' not described in 'ad5446_state' drivers/iio/dac/ad5446.c:323: warning: cannot understand function prototype: 'enum ad5446_supported_spi_device_ids ' drivers/iio/dac/ad5446.c:545: warning: cannot understand function prototype: 'enum ad5446_supported_i2c_device_ids ' Cc: Michael Hennerich Signed-off-by: Lee Jones --- drivers/iio/dac/ad5446.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/iio/dac/ad5446.c b/drivers/iio/dac/ad5446.c index 8f8afc8999bc7..15c314f08a007 100644 --- a/drivers/iio/dac/ad5446.c +++ b/drivers/iio/dac/ad5446.c @@ -29,11 +29,14 @@ /** * struct ad5446_state - driver instance specific data - * @spi: spi_device + * @dev: this device * @chip_info: chip model specific constants, available modes etc * @reg: supply regulator * @vref_mv: actual reference voltage used - * @lock lock to protect the data buffer during write ops + * @cached_val: store/retrieve values during power down + * @pwr_down_mode: power down mode (1k, 100k or tristate) + * @pwr_down: true if the device is in power down + * @lock: lock to protect the data buffer during write ops */ struct ad5446_state { @@ -313,7 +316,7 @@ static int ad5660_write(struct ad5446_state *st, unsigned val) return spi_write(spi, data, sizeof(data)); } -/** +/* * ad5446_supported_spi_device_ids: * The AD5620/40/60 parts are available in different fixed internal reference * voltage options. The actual part numbers may look differently @@ -535,7 +538,7 @@ static int ad5622_write(struct ad5446_state *st, unsigned val) return i2c_master_send(client, (char *)&data, sizeof(data)); } -/** +/* * ad5446_supported_i2c_device_ids: * The AD5620/40/60 parts are available in different fixed internal reference * voltage options. The actual part numbers may look differently