From patchwork Thu Jul 16 13:59:21 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11667625 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3F17813B1 for ; Thu, 16 Jul 2020 14:08:00 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 16109207BC for ; Thu, 16 Jul 2020 14:08:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="A9YGBUJB"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="S1ggKKr4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 16109207BC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=R2oTvtOKVSrOhvAEs24dLd76xn/mRAxR1VrhW598FNg=; b=A9YGBUJBqK/g71beyC0/dOy01 372Ny5vM23nfLVPCQXd1pFN/IS8ZbG1xE7LrNAOgLTpn4w1W0NcwmYb0OXYOcXMg0vyyt5WW+vpAq wh2DNVwvlFkrkkT4zZ1Uq6v9fYmbRAUACFn0FuJxdG7q9BoKDsxzv5U4UHjfY0jy93SUreSipdVHC OI+yRUr142P8sGxNCLWA+klEniTHppcqQmv+CRSVzpfNUZpn86WKz1guukHAIHDJ8sxXThaqLJl4n UeDSVEuAvuYuPsaLSH3oN2DYOAsrQZwCFZaYO5kiuJtoSPgB/ZtVqlhqteT4wjpHP98dpKDYjvTqL AcUi9C1nA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jw4Vu-0000JV-In; Thu, 16 Jul 2020 14:05:30 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jw4Qb-00041B-Jz for linux-arm-kernel@lists.infradead.org; Thu, 16 Jul 2020 14:00:03 +0000 Received: by mail-wr1-x442.google.com with SMTP id f18so7226758wrs.0 for ; Thu, 16 Jul 2020 07:00:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=bkghzH4FwjGUVQFUZPoQ97cOQabOY+KdLhABNUZLqIk=; b=S1ggKKr4PsJt4mnmFy83hI5iE2gJWJql1bB9gOk+PK5KznVZKiv0CzTg8eyKCXNTcP Hb0EIspfFfeYzKpt/O41IvcFTDh7L52KazjEkdupAVnk2gJ8bPVCLzw9Ph6/P+/C67Le W65BHf1ymoCwyGb+rT7YXibxWdGo4P3Zg3gmUGEMdVwGeb991gHdRaFrLN+cpM6Ni59f 87Q3djAnHrpsXS14Q5Gm0Lp+kobOspNfNsFZ5emHq5g6uEsULserGcgTBSBvFcOuNdtN PnClSEw4/vzH4Z0eS+TjeSTu+aH4FHY1tiBDLOjG6WSO6Gmj9B0R0OtHEK9eW5OJlD54 fmXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bkghzH4FwjGUVQFUZPoQ97cOQabOY+KdLhABNUZLqIk=; b=gx7d6aEw8OUhohPtYPvqL1Ufe91FqaE8KMxPe5AW6Un4BeKT6Ni1jKegBdQiTAU5uS 5UzR3JKJfyceEwmDY6u6bzrY+m16rYseymqaeBaW8GI6RDDOWjhxjlaxC2E1tpaQRYv7 92XrpxmCcAGVSJOQQdkOyc74EClQ++xzy/D+3auOQJyamT74IS4UIWF2Fr08yRjrtcwj QFhhCa6JPR+E96IkAMO2Ns1UaFfUNsLTuqsb4HIAZKv7uU6gPXYZ+V6LA9cD8UXnrZwR /jIBTDgPqyDF6H6NpWo2N0PrVdGT1iCwd1Q919A3ax1IGdEXNY/Qifwy64qi/GdhtMux Fnyw== X-Gm-Message-State: AOAM5318X6O7hH26IbFBuOirNuvb4DmzudE2m0VgnUburMStl4Yku031 yzF/u4RlF5ydqsRKE4tSdmbN8w== X-Google-Smtp-Source: ABdhPJzeVMIR8thnmbqfUj0K3saB+lmylMEVfVpRaOION/gNn16Ry4C428YCMr2eRk7YrRcwvvAk/g== X-Received: by 2002:adf:9c8c:: with SMTP id d12mr5059867wre.369.1594908000543; Thu, 16 Jul 2020 07:00:00 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id x18sm9351001wrq.13.2020.07.16.06.59.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2020 07:00:00 -0700 (PDT) From: Lee Jones To: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net Subject: [PATCH 23/30] iio: dac: ad5758: Move and fix-up kerneldoc header and demote unworthy kerneldoc Date: Thu, 16 Jul 2020 14:59:21 +0100 Message-Id: <20200716135928.1456727-24-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200716135928.1456727-1-lee.jones@linaro.org> References: <20200716135928.1456727-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200716_100001_789902_07F6D453 X-CRM114-Status: GOOD ( 11.66 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:442 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Hennerich , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Popa , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Kerneldoc headers need to come directly before the function/struct that they are documenting. Also fix some missing descriptions and misspellings. Fixes the following W=1 kernel build warning(s): drivers/iio/dac/ad5758.c:111: warning: Function parameter or member 'reg' not described in 'ad5758_range' drivers/iio/dac/ad5758.c:111: warning: Function parameter or member 'min' not described in 'ad5758_range' drivers/iio/dac/ad5758.c:111: warning: Function parameter or member 'max' not described in 'ad5758_range' drivers/iio/dac/ad5758.c:122: warning: Function parameter or member 'gpio_reset' not described in 'ad5758_state' drivers/iio/dac/ad5758.c:122: warning: Function parameter or member 'd32' not described in 'ad5758_state' drivers/iio/dac/ad5758.c:137: warning: cannot understand function prototype: 'enum ad5758_output_range ' Cc: Michael Hennerich Cc: Stefan Popa Signed-off-by: Lee Jones --- drivers/iio/dac/ad5758.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/iio/dac/ad5758.c b/drivers/iio/dac/ad5758.c index 475646c82b40e..c34740d2c89a1 100644 --- a/drivers/iio/dac/ad5758.c +++ b/drivers/iio/dac/ad5758.c @@ -92,24 +92,24 @@ #define AD5758_FULL_SCALE_MICRO 65535000000ULL +struct ad5758_range { + int reg; + int min; + int max; +}; + /** * struct ad5758_state - driver instance specific data * @spi: spi_device * @lock: mutex lock + * @gpio_reset: gpio descriptor for the reset line * @out_range: struct which stores the output range * @dc_dc_mode: variable which stores the mode of operation * @dc_dc_ilim: variable which stores the dc-to-dc converter current limit * @slew_time: variable which stores the target slew time * @pwr_down: variable which contains whether a channel is powered down or not - * @data: spi transfer buffers + * @d32: spi transfer buffers */ - -struct ad5758_range { - int reg; - int min; - int max; -}; - struct ad5758_state { struct spi_device *spi; struct mutex lock; @@ -122,7 +122,7 @@ struct ad5758_state { __be32 d32[3]; }; -/** +/* * Output ranges corresponding to bits [3:0] from DAC_CONFIG register * 0000: 0 V to 5 V voltage range * 0001: 0 V to 10 V voltage range