From patchwork Thu Jul 16 13:59:24 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11667619 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 772C113B1 for ; Thu, 16 Jul 2020 14:07:54 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4334D207BC for ; Thu, 16 Jul 2020 14:07:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lClPdrl9"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="S/EfrnxZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4334D207BC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Ovj9NsvU0DjLGOyN3m2Wxn0UZiuSIKrLIgxjcJ8GNfs=; b=lClPdrl9iZxRWnEFgOF2rbUt4 XgQjCgM/2D4V+JICGwKdkpjEVnrk+pirQLgci6bC8Gpp/NPgOFnVrh9VNjq5YlRKGlhtHLyjwZXmO 13xiRzSgos5O5CBSKHa1TTNayK4DawIHkEyCHWPxJWRakWnGwRmpoZireH9dLXVf4wmfgjjHS8tdJ yztrQ1ECzFw6zITcTX5QdZIo+WWnbdGd5Mp5N0NRB11hYBsv0Y3JEEuARNZ4yP9ZE9k/VYGw0oTmY WdtQTGa4xawZelx66a2VUQYqN49FbeCYIBkh4wnh6inIZpsIBQWUuFE2l6FJpcjd2St8wWivXYP2G wbDrAOjyw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jw4W3-0000MB-EF; Thu, 16 Jul 2020 14:05:39 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jw4Qf-00043I-Cm for linux-arm-kernel@lists.infradead.org; Thu, 16 Jul 2020 14:00:06 +0000 Received: by mail-wr1-x443.google.com with SMTP id a6so7196328wrm.4 for ; Thu, 16 Jul 2020 07:00:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nXEWebe+sS+XiqWoQoRxhD9v/xPZIfBCkXrtYalx/AE=; b=S/EfrnxZYjtTtkIkqrTiVNAO5OH8CmVkGRufQpyGIg77dlImgq1h6B0imzE+9ppb0M 6HvNo8NcLmQOxsp6ag7w/kdzHmCBs96zl8c/zEgOU2ACSfiWCBalio12JP88lb93I95f RdSW/antLiyXbEPKnfErgset/xg3Xj1q/fGytgXXTvtC178ieanq6DkjBYmV54DukpI9 BUX1jhcPwI/vEm1dMhoiQlMxxjG6NChp1HKmc+74KOYiZ4nRuPqIttGsWWOOlDUJIDGz aX2dLkiI5FHZCcXmc9wk99oVxwJB+cRRo0L5je04QWne9mO7X3yQxjTwIUj1E85VfVoT btjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nXEWebe+sS+XiqWoQoRxhD9v/xPZIfBCkXrtYalx/AE=; b=QKYbEa/LDPUPH7QnrAAJfSub0PuitJvVW9y6L6iMqEaz1PUn3X62GPFWzENDGf0r+J wxRMy6w3cv7IzLRdzL6tyWbPW+9hRwR02PBM8+RPhKyHzg6vCOE4f7Dtu0CufzfVXFvm HF/QeYCyi/CaZdiVAqpp4J87YTfrMFlcHGL7YnairqqqiYhcJyehRHEkpTb9AR0a612F Sh5BrmgTVtb3kazGUPAVmFQnA8UcH+7gQiLX8bXYrcIlBP2zMlKmUh4lIn+Let7s8j30 3zx4gy4O3XnZaBEFniBcFiO5gKTqGhXSMmQ2iWfSazOngOusQh4aiaRLe6rgCNZppBBr jrmA== X-Gm-Message-State: AOAM530aII+ec5YPqYACIce9fJKWbc5dRi5aiP1lqZJE6WfKzrG2Xa/z do/aFv9qqo9vWN9j60jX02sdgQ== X-Google-Smtp-Source: ABdhPJxhU91vXkoK1eVdGWHiSEri1q4qS0BOtilZAXAQsoMS3FeyQ/3NdGqlOwnMCMBnpqIzSK5oiQ== X-Received: by 2002:adf:d084:: with SMTP id y4mr5079554wrh.161.1594908004260; Thu, 16 Jul 2020 07:00:04 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id x18sm9351001wrq.13.2020.07.16.07.00.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2020 07:00:03 -0700 (PDT) From: Lee Jones To: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net Subject: [PATCH 26/30] iio: dac: ad5791: Complete 'struct ad5791_chip_info' documentation Date: Thu, 16 Jul 2020 14:59:24 +0100 Message-Id: <20200716135928.1456727-27-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200716135928.1456727-1-lee.jones@linaro.org> References: <20200716135928.1456727-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200716_100005_505494_C0B13551 X-CRM114-Status: GOOD ( 10.97 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:443 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-iio@vger.kernel.org, Michael Hennerich , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org ... and remove seemingly pointless comment. Fixes the following W=1 kernel build warning(s): drivers/iio/dac/ad5791.c:97: warning: Function parameter or member 'ctrl' not described in 'ad5791_state' drivers/iio/dac/ad5791.c:97: warning: Function parameter or member 'pwr_down_mode' not described in 'ad5791_state' drivers/iio/dac/ad5791.c:97: warning: Function parameter or member 'pwr_down' not described in 'ad5791_state' drivers/iio/dac/ad5791.c:97: warning: Function parameter or member 'data' not described in 'ad5791_state' drivers/iio/dac/ad5791.c:103: warning: cannot understand function prototype: 'enum ad5791_supported_device_ids ' Cc: Michael Hennerich Signed-off-by: Lee Jones --- drivers/iio/dac/ad5791.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/iio/dac/ad5791.c b/drivers/iio/dac/ad5791.c index 1d11f39ed0474..d8485004b1010 100644 --- a/drivers/iio/dac/ad5791.c +++ b/drivers/iio/dac/ad5791.c @@ -76,9 +76,11 @@ struct ad5791_chip_info { * @chip_info: chip model specific constants * @vref_mv: actual reference voltage used * @vref_neg_mv: voltage of the negative supply - * @pwr_down_mode current power down mode + * @ctrl: control regster cache + * @pwr_down_mode: current power down mode + * @pwr_down: true if device is powered down + * @data: spi transfer buffers */ - struct ad5791_state { struct spi_device *spi; struct regulator *reg_vdd; @@ -96,10 +98,6 @@ struct ad5791_state { } data[3] ____cacheline_aligned; }; -/** - * ad5791_supported_device_ids: - */ - enum ad5791_supported_device_ids { ID_AD5760, ID_AD5780,