| Message ID | 20200716220055.GA19603@embeddedor (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [next] i2c: digicolor: Use fallthrough pseudo-keyword | expand |
Hi Gustavo, On Thu, Jul 16, 2020 at 05:00:55PM -0500, Gustavo A. R. Silva wrote: > Replace the existing /* fall through */ comments and its variants with > the new pseudo-keyword macro fallthrough[1]. > > [1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through This URL is likely to break at some point as documentation contest changes. Just refer to in kernel Documentation/process/deprecated.rst file. Other than that: Acked-by: Baruch Siach <baruch@tkos.co.il> Thanks, baruch > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> > --- > drivers/i2c/busses/i2c-digicolor.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-digicolor.c b/drivers/i2c/busses/i2c-digicolor.c > index 332f00437479..f67639dc74b7 100644 > --- a/drivers/i2c/busses/i2c-digicolor.c > +++ b/drivers/i2c/busses/i2c-digicolor.c > @@ -187,7 +187,7 @@ static irqreturn_t dc_i2c_irq(int irq, void *dev_id) > break; > } > i2c->state = STATE_WRITE; > - /* fall through */ > + fallthrough; > case STATE_WRITE: > if (i2c->msgbuf_ptr < i2c->msg->len) > dc_i2c_write_buf(i2c);
Hi Baruch, On 7/16/20 23:38, Baruch Siach wrote: > Hi Gustavo, > > On Thu, Jul 16, 2020 at 05:00:55PM -0500, Gustavo A. R. Silva wrote: >> Replace the existing /* fall through */ comments and its variants with >> the new pseudo-keyword macro fallthrough[1]. >> >> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through > > This URL is likely to break at some point as documentation contest changes. > Just refer to in kernel Documentation/process/deprecated.rst file. > You're right. Helpdesk just generated the proper doc for v5.7: https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through > Other than that: > > Acked-by: Baruch Siach <baruch@tkos.co.il> > I'll send v2 with the URL above and your Acked-by, shortly. Thanks -- Gustavo
diff --git a/drivers/i2c/busses/i2c-digicolor.c b/drivers/i2c/busses/i2c-digicolor.c index 332f00437479..f67639dc74b7 100644 --- a/drivers/i2c/busses/i2c-digicolor.c +++ b/drivers/i2c/busses/i2c-digicolor.c @@ -187,7 +187,7 @@ static irqreturn_t dc_i2c_irq(int irq, void *dev_id) break; } i2c->state = STATE_WRITE; - /* fall through */ + fallthrough; case STATE_WRITE: if (i2c->msgbuf_ptr < i2c->msg->len) dc_i2c_write_buf(i2c);
Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1]. [1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> --- drivers/i2c/busses/i2c-digicolor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)