From patchwork Fri Jul 17 20:52:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Rob Herring (Arm)" X-Patchwork-Id: 11671183 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 89EA013B6 for ; Fri, 17 Jul 2020 20:54:19 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 642E12074B for ; Fri, 17 Jul 2020 20:54:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="uuaSDJ34" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 642E12074B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=RrOa5TUAX1aO1i0zq/v14CK07sZ/SM1DgYkfLHY5IFc=; b=uuaSDJ34Cjhey6MHcHQZkoIDg j6jvm9dSFaCOMGvKsgZtLuPXnsj8JiX2H8iEyrS3lBovCth8xtj/Yyjk+4teR36gvRi72Hke5B2kA fiQL01D5WiS4mw6nOzjpQCIFe/ENYiJxs0LKnKwe87SEP/jhgdALx7Mo0xdpqmamFH7T8MeB8HQ4M 8wgpVt+9LKnDYGw3YSYIC5hoDZaPSUoi7Z/uTjVXlA9YsSMlZpdEm80DSgXi8JS5tH0saCq9CMVZQ rjH1833RnttwOLroecIMXp92l5HuZSDexi6BYX25D6aHoZGZGb3MCk0SaPjT2cihKnU+NIGiOIjvF moNGlpNYg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwXLV-0002eg-NO; Fri, 17 Jul 2020 20:52:42 +0000 Received: from mail-il1-f193.google.com ([209.85.166.193]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwXLS-0002dJ-FT for linux-arm-kernel@lists.infradead.org; Fri, 17 Jul 2020 20:52:39 +0000 Received: by mail-il1-f193.google.com with SMTP id t18so8463684ilh.2 for ; Fri, 17 Jul 2020 13:52:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lA6y1484mCfujwLhJ510Qn2HTKproByu1gKdBQz37Eo=; b=ED/afckgfsrJcy8pm+NBfA+UHPR6NBVSl5FjNZ2q4yM3/tyUczF12gsOwfWiaXEF0e XWrMvqYrktMPUW9FDJWGjzyRsTa2xn4xhfFyW0OciokeXPSDUnNMenMETz9XmQt8qoRb 0nfh9Gh69W8lRcY635GqNXtWkFPNOtRZRqGB1iuCTYbD//URnvTVxRjeKz0UDeRUCZLl TS4glOUQ7hC/2bmrzSSRAvPtMtBGUle0l2eKwhknh8OgoYPWytvfSwafftkCiIje+zUR PrsmX5qDndtRuawD8qJ+bgrmbdy9X08stfaGoO7wB1wlwXygkqct+48CkgtBVWsqvfOe ikvA== X-Gm-Message-State: AOAM530QSZW4CEtSBayDBrbTOW5BzoPtn2UL3247cVADi0GA7AqHvGi7 Y0LD0dCMnPp+GrVeM13tDw== X-Google-Smtp-Source: ABdhPJyx/gulu/KTsFX3iauAwSag59A89mCNqY2i4r9k8OMUlJTecA50WQpkSdggWHrYVxGOD+Zqdw== X-Received: by 2002:a05:6e02:ead:: with SMTP id u13mr11850062ilj.46.1595019156351; Fri, 17 Jul 2020 13:52:36 -0700 (PDT) Received: from xps15.herring.priv ([64.188.179.252]) by smtp.googlemail.com with ESMTPSA id 136sm4737492iou.50.2020.07.17.13.52.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 13:52:35 -0700 (PDT) From: Rob Herring To: Catalin Marinas , Will Deacon , Marc Zyngier Subject: [PATCH v3 1/3] KVM: arm64: Print warning when cpu erratum can cause guests to deadlock Date: Fri, 17 Jul 2020 14:52:31 -0600 Message-Id: <20200717205233.903344-2-robh@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200717205233.903344-1-robh@kernel.org> References: <20200717205233.903344-1-robh@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200717_165238_541217_D8097847 X-CRM114-Status: GOOD ( 10.85 ) X-Spam-Score: 0.3 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (0.3 points) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [robherring2[at]gmail.com] 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit [robherring2[at]gmail.com] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.166.193 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.166.193 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kvmarm@lists.cs.columbia.edu, James Morse , Julien Thierry , linux-arm-kernel@lists.infradead.org, Suzuki K Poulose Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org If guests don't have certain CPU erratum workarounds implemented, then there is a possibility a guest can deadlock the system. IOW, only trusted guests should be used on systems with the erratum. This is the case for Cortex-A57 erratum 832075. Cc: Marc Zyngier Cc: James Morse Cc: Julien Thierry Cc: Suzuki K Poulose Cc: Catalin Marinas Cc: Will Deacon Cc: kvmarm@lists.cs.columbia.edu Signed-off-by: Rob Herring --- v3: - s/work-arounds/workarounds/ arch/arm64/kvm/arm.c | 4 ++++ 1 file changed, 4 insertions(+) -- 2.25.1 diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c index 90cb90561446..9b070b5e212b 100644 --- a/arch/arm64/kvm/arm.c +++ b/arch/arm64/kvm/arm.c @@ -1653,6 +1653,10 @@ int kvm_arch_init(void *opaque) return -ENODEV; } + if (cpus_have_const_cap(ARM64_WORKAROUND_DEVICE_LOAD_ACQUIRE)) + kvm_info("Guests without required CPU erratum workarounds can deadlock system!\n" \ + "Only trusted guests should be used on this system.\n"); + for_each_online_cpu(cpu) { smp_call_function_single(cpu, check_kvm_target_cpu, &ret, 1); if (ret < 0) {