| Message ID | 20200722153146.8767-4-dmurphy@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Multicolor Framework v32 | expand |
Russel and Linus On 7/22/20 10:31 AM, Dan Murphy wrote: > The dependencies for the LP55XX LED drivers have been updated so that > the child devices (i.e. LP5521) now depends on the LP55XX_COMMON config > flag as opposed to the device selecting the LP55XX_COMMON flag. The > LP55XX_COMMON needs to be set in the defconfig. > > Signed-off-by: Dan Murphy <dmurphy@ti.com> > --- > arch/arm/configs/u8500_defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/configs/u8500_defconfig b/arch/arm/configs/u8500_defconfig > index 28dd7cf56048..dea599e1c17e 100644 > --- a/arch/arm/configs/u8500_defconfig > +++ b/arch/arm/configs/u8500_defconfig > @@ -113,6 +113,7 @@ CONFIG_NEW_LEDS=y > CONFIG_LEDS_CLASS=y > CONFIG_LEDS_LM3530=y > CONFIG_LEDS_GPIO=y > +CONFIG_LEDS_LP55XX_COMMON=y > CONFIG_LEDS_LP5521=y > CONFIG_LEDS_TRIGGER_HEARTBEAT=y > CONFIG_RTC_CLASS=y I missed adding you to the patch. Can you kindly review this change? Dan
On Wed, Jul 22, 2020 at 5:32 PM Dan Murphy <dmurphy@ti.com> wrote: > The dependencies for the LP55XX LED drivers have been updated so that > the child devices (i.e. LP5521) now depends on the LP55XX_COMMON config > flag as opposed to the device selecting the LP55XX_COMMON flag. The > LP55XX_COMMON needs to be set in the defconfig. > > Signed-off-by: Dan Murphy <dmurphy@ti.com> OK then I guess you have good reasons to have it like this. Acked-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
diff --git a/arch/arm/configs/u8500_defconfig b/arch/arm/configs/u8500_defconfig index 28dd7cf56048..dea599e1c17e 100644 --- a/arch/arm/configs/u8500_defconfig +++ b/arch/arm/configs/u8500_defconfig @@ -113,6 +113,7 @@ CONFIG_NEW_LEDS=y CONFIG_LEDS_CLASS=y CONFIG_LEDS_LM3530=y CONFIG_LEDS_GPIO=y +CONFIG_LEDS_LP55XX_COMMON=y CONFIG_LEDS_LP5521=y CONFIG_LEDS_TRIGGER_HEARTBEAT=y CONFIG_RTC_CLASS=y
The dependencies for the LP55XX LED drivers have been updated so that the child devices (i.e. LP5521) now depends on the LP55XX_COMMON config flag as opposed to the device selecting the LP55XX_COMMON flag. The LP55XX_COMMON needs to be set in the defconfig. Signed-off-by: Dan Murphy <dmurphy@ti.com> --- arch/arm/configs/u8500_defconfig | 1 + 1 file changed, 1 insertion(+)