From patchwork Fri Jul 24 18:08:57 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 11683951 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id F368F1392 for ; Fri, 24 Jul 2020 18:11:14 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CB8CA20674 for ; Fri, 24 Jul 2020 18:11:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="TIAoJWip"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="2gPXnyeE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CB8CA20674 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-Id:Date:Subject:To:From:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=9xzyvAV5ZhEu4HXLP8Vx2MzGRliqukMM1s4y5EurO7Q=; b=TIAoJWip6CN6CsGptcHXJFRqro uAm3ykkpt0HOstuTZxLBd4Ipa6G9V3GakZ4z7Gg9PQOx/mXf/pSnknfoJewO7HdfU6IAWOXCWnMGb m9EvZeTh+QQo3KInVSXIVwNu9gjN/e0uQ4g/M2x3+ct1k+vBFa6vRbIQp6GEoiMF6asPJgIgxEEbU 0hem63w3qsK2wnWiTgScYdtTdQSxog3+9KPDnHcukDmz4/GLxszQ68SpmamKX4F7Vk0Y0QgNz1I5z sl1ObR9BdXSiZgxhezklXDApgmXLsE2b7d8Ktv9nOPEkiZ9yZ8yjNz8VpoO0Xaqx9K4tfaYud+Hx5 KLmqd8kw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jz28F-0007rD-1g; Fri, 24 Jul 2020 18:09:19 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jz28B-0007qK-Uu for linux-arm-kernel@lists.infradead.org; Fri, 24 Jul 2020 18:09:16 +0000 Received: from kozik-lap.mshome.net (unknown [194.230.155.213]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 57AC220674; Fri, 24 Jul 2020 18:09:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595614155; bh=WKWTRR3OpiM//OpvSkAaN+ab6FB8ru2WmmhyV77aIRk=; h=From:To:Subject:Date:From; b=2gPXnyeEqHeBv1avgOINVK3OnB1zXEJC7lajj6Dv/xOENZqwz9h58oaGxlkTc/rEN nMGB/wuDe4JEhjQaFydwD/rKx0y/lVH7PA8Vz3TJ25/LRo10tcPGyZ+rz2yb5nxqXa Vq9x1oqEh/EjnsOgRGQTr0husbnavBANkD/fZc1w= From: Krzysztof Kozlowski To: Lukasz Luba , Krzysztof Kozlowski , Kukjin Kim , linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [RFC] memory: exynos5422-dmc: Document mutex scope Date: Fri, 24 Jul 2020 20:08:57 +0200 Message-Id: <20200724180857.22119-1-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200724_140916_108194_B1E4498B X-CRM114-Status: GOOD ( 12.06 ) X-Spam-Score: -5.2 (-----) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-5.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at https://www.dnswl.org/, high trust [198.145.29.99 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.0 DKIMWL_WL_HIGH DKIMwl.org - Whitelisted High sender X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Document scope of the mutex used by driver. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Lukasz Luba --- It seems mutex was introduced to protect: 1. setting actual frequency/voltage, 2. dmc->curr_rate (in exynos5_dmc_get_cur_freq()). However dmc->curr_rate in exynos5_dmc_get_status() is not protected. Is it a bug? --- drivers/memory/samsung/exynos5422-dmc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/memory/samsung/exynos5422-dmc.c b/drivers/memory/samsung/exynos5422-dmc.c index 93e9c2429c0d..0388066a7d96 100644 --- a/drivers/memory/samsung/exynos5422-dmc.c +++ b/drivers/memory/samsung/exynos5422-dmc.c @@ -114,6 +114,7 @@ struct exynos5_dmc { void __iomem *base_drexi0; void __iomem *base_drexi1; struct regmap *clk_regmap; + /* Protects curr_rate and frequency/voltage setting section */ struct mutex lock; unsigned long curr_rate; unsigned long curr_volt;